Ensure vendored loader does not cache missing modules. #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, calling `requireModule('foo')` would **create** a
`foo` module (with no exports) due to eager caching in the list of
"seen" modules.
This means that code like this:
```js
let Ember;
try {
Ember = requireModule('ember')['default'];
} catch {
Ember = window.Ember;
}
return Ember;
```
Will properly fallback to `window.Ember` the first time, but all
subsequent runs will end up finding a module and returning `{}`.
patricklx
pushed a commit
to patricklx/ember-inspector
that referenced
this pull request
Sep 19, 2022
Prior to this change, calling `requireModule('foo')` would **create** a
`foo` module (with no exports) due to eager caching in the list of
"seen" modules.
This means that code like this:
```js
let Ember;
try {
Ember = requireModule('ember')['default'];
} catch {
Ember = window.Ember;
}
return Ember;
```
Will properly fallback to `window.Ember` the first time, but all
subsequent runs will end up finding a module and returning `{}`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, calling
requireModule('foo')would create afoomodule (with no exports) due to eager caching in the list of "seen" modules.This means that code like this:
Will properly fallback to
window.Emberthe first time, but all subsequent runs will end up finding a module and returning{}.This addresses at least part of #1595 (cannot confirm if it is fully resolved, due to raciness and testing timing).