Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app config tab #1577

Merged
merged 6 commits into from
May 13, 2021
Merged

Conversation

hannakim91
Copy link
Contributor

@hannakim91 hannakim91 commented May 12, 2021

Description

Added app config tab to info tab. Currently longer objects get cut off. Will look at changing that in the future.
Closes #1159

Screenshots

Screen Shot 2021-05-12 at 9 30 02 AM

app/routes/app-config.js Outdated Show resolved Hide resolved
app/routes/app-config.js Outdated Show resolved Hide resolved
app/routes/libraries.js Outdated Show resolved Hide resolved
ember_debug/general-debug.js Outdated Show resolved Hide resolved
tests/unit/controllers/app-config-test.js Outdated Show resolved Hide resolved
tests/unit/routes/app-config-test.js Outdated Show resolved Hide resolved
@nummi
Copy link
Collaborator

nummi commented May 12, 2021

Looks great to me! 👍

@RobbieTheWagner RobbieTheWagner merged commit bc2ef94 into emberjs:master May 13, 2021
patricklx pushed a commit to patricklx/ember-inspector that referenced this pull request Sep 19, 2022
* WIP: Found CLI config object in same object providing info for libraries tab

* Add app config tab to Info

* Make requested changes from PR comments

* Update app/routes/app-config.js

* Update app/routes/app-config.js

* Update app/routes/app-config.js

Co-authored-by: Robert Wagner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Add Application Configuration Information
3 participants