Use requireModule('ember') instead of window.Ember
#1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Mar 22, 2021
RobbieTheWagner
force-pushed
the
require-ember
branch
from
670cf55 to
5c9519e
Compare
RobbieTheWagner
changed the title
window.EmberrequireModule('ember') instead of window.Ember
pzuraq
approved these changes
Apr 26, 2021
| /* eslint no-console: 0 */ | ||
| const Ember = window.Ember; | ||
| let Ember; |
There was a problem hiding this comment.
can you extract the logic of getting ember to some common function,
maybe getEmber()?
There was a problem hiding this comment.
We definitely could! @avihai-yosef would you be interested in opening a PR to do that?
Merged
This was referenced May 19, 2021
patricklx
pushed a commit
to patricklx/ember-inspector
that referenced
this pull request
Sep 19, 2022
* Use require('ember') instead of `window.Ember`
* require('ember') || window.Ember
* Try requireModule
* Try require.has
* requireModule again
* requireModule again
* Fix issues with deprecation re-entry and debug class name logging
* Fix tests for 3.27+
* Wrap ember require in try/catch
* Skip mixin tests
Co-authored-by: Chris Garrett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshots