Avoid errors when using older Ember versions. #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With ember-cli-htmlbars 4.2, there is a check to disable co-location support on old ember versions (which, even when compiled, would fail at runtime due to missing `setComponentTemplate`). This is causing build failures when running ember-try with old Ember versions. Since we don't actually run the app or its tests in ember-try, we can work around the problem by skipping template compilation for now. Co-authored-by: Godfrey Chan <[email protected]>
Merged
RobbieTheWagner
approved these changes
Dec 14, 2019
delete-merged-branch
bot
deleted the
prevent-colocation-for-older-ember
branch
nummi
pushed a commit
to nummi/ember-inspector
that referenced
this pull request
Apr 1, 2020
With ember-cli-htmlbars 4.2, there is a check to disable co-location support on old ember versions (which, even when compiled, would fail at runtime due to missing `setComponentTemplate`). This is causing build failures when running ember-try with old Ember versions. Since we don't actually run the app or its tests in ember-try, we can work around the problem by skipping template compilation for now. Co-authored-by: Godfrey Chan <[email protected]>
nummi
pushed a commit
to nummi/ember-inspector
that referenced
this pull request
Apr 5, 2020
With ember-cli-htmlbars 4.2, there is a check to disable co-location support on old ember versions (which, even when compiled, would fail at runtime due to missing `setComponentTemplate`). This is causing build failures when running ember-try with old Ember versions. Since we don't actually run the app or its tests in ember-try, we can work around the problem by skipping template compilation for now. Co-authored-by: Godfrey Chan <[email protected]>
patricklx
pushed a commit
to patricklx/ember-inspector
that referenced
this pull request
Sep 19, 2022
With ember-cli-htmlbars 4.2, there is a check to disable co-location support on old ember versions (which, even when compiled, would fail at runtime due to missing `setComponentTemplate`). This is causing build failures when running ember-try with old Ember versions. Since we don't actually run the app or its tests in ember-try, we can work around the problem by skipping template compilation for now. Co-authored-by: Godfrey Chan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With ember-cli-htmlbars 4.2, there is a check to disable co-location support on old ember versions (which, even when compiled, would fail at runtime due to missing
setComponentTemplate). This is causing build failures when running ember-try with old Ember versions. Since we don't actually run the app or its tests in ember-try, we can work around the problem by skipping template compilation for now.Paired with @rwjblue