Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no-new-mixins #1099

Merged
merged 1 commit into from
Dec 14, 2019
Merged

Fix no-new-mixins #1099

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions tests/ember_debug/object-inspector-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable ember/no-new-mixins */
import { find, settled, visit } from '@ember/test-helpers';
import Mixin from '@ember/object/mixin';
import Component from '@ember/component';
Expand Down Expand Up @@ -222,7 +223,6 @@ module('Ember Debug - Object Inspector', function(hooks) {
});

test('Correct mixin order with es6 class', function (assert) {

class MyMixinClass extends Mixin {
toString() {
return 'MyMixin';
Expand Down Expand Up @@ -329,14 +329,11 @@ module('Ember Debug - Object Inspector', function(hooks) {
});

test('Correct mixin properties', function (assert) {

// eslint-disable-next-line ember/no-new-mixins
class MyMixin extends Mixin {
toString() {
return 'MyMixin1';
}
}
// eslint-disable-next-line ember/no-new-mixins
class MyMixin2 extends Mixin {
toString() {
return 'MyMixin2';
Expand Down Expand Up @@ -562,7 +559,6 @@ module('Ember Debug - Object Inspector', function(hooks) {
});

test('Property grouping can be customized using _debugInfo', function(assert) {
// eslint-disable-next-line ember/no-new-mixins
let mixinToSkip = Mixin.create({});

let Inspected = EmberObject.extend(mixinToSkip, {
Expand Down Expand Up @@ -627,7 +623,6 @@ module('Ember Debug - Object Inspector', function(hooks) {
});

test('Property grouping can be customized using _debugInfo when using Proxy', function(assert) {

class MyMixin extends Mixin {
toString() {
return 'MixinToSkip';
Expand Down