Use XPath to select elements #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This renames the `inspectDOMElement` API to `inspectDOMNode`, and changes the argument from a CSS selector to an XPath selector. The problem with CSS selectors are that they only support selecting elements, whereas XPath allows us to select any arbitrary DOM node, including text nodes, comments etc. This commit sets a better foundation for supporting things other than classic components. Since Glimmer components, route templates, "tagless" classic components etc have "outer HTML" semantics, they don't necessarily have a single element. Going forward, we will likely want to select the first node in a component's "bounds", which could be an arbitrary DOM node (i.e. may or may not be an element node, so CSS selectors are not sufficient).
rwjblue
approved these changes
Nov 5, 2019
RobbieTheWagner
approved these changes
Nov 5, 2019
patricklx
pushed a commit
to patricklx/ember-inspector
that referenced
this pull request
Sep 19, 2022
This renames the `inspectDOMElement` API to `inspectDOMNode`, and changes the argument from a CSS selector to an XPath selector. The problem with CSS selectors are that they only support selecting elements, whereas XPath allows us to select any arbitrary DOM node, including text nodes, comments etc. This commit sets a better foundation for supporting things other than classic components. Since Glimmer components, route templates, "tagless" classic components etc have "outer HTML" semantics, they don't necessarily have a single element. Going forward, we will likely want to select the first node in a component's "bounds", which could be an arbitrary DOM node (i.e. may or may not be an element node, so CSS selectors are not sufficient).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames the
inspectDOMElementAPI toinspectDOMNode, and changes the argument from a CSS selector to an XPath selector.The problem with CSS selectors are that they only support selecting elements, whereas XPath allows us to select any arbitrary DOM node, including text nodes, comments etc.
This commit sets a better foundation for supporting things other than classic components. Since Glimmer components, route templates, "tagless" classic components etc have "outer HTML" semantics, they don't necessarily have a single element. Going forward, we will likely want to select the first node in a component's "bounds", which could be an arbitrary DOM node (i.e. may or may not be an element node, so CSS selectors are not sufficient).