Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "::" instead of "/" when displaying component names #1048

Merged

Conversation

camerondubas
Copy link
Contributor

@camerondubas camerondubas commented Oct 3, 2019

Hey all, first PR to this repo 👍

This PR updates the display of component names to use :: instead of /, so that it matches the Angle Bracket Nested Invocation RFC

In addition, this updates the component names used when "Inspecting" components so that they also match this syntax.

Before:
Screen Shot 2019-10-03 at 3 39 32 PM

After:
Screen Shot 2019-10-03 at 3 37 41 PM

Copy link
Collaborator

@nummi nummi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for contributing!

@nummi nummi merged commit 353bea5 into emberjs:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants