Misc Component Cleanup #1044
Merged
Misc Component Cleanup #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nummi
force-pushed
the
misc-component-cleanup
branch
from
6581779 to
16649e7
Compare
`</>, this, @, etc.`
`</>, this, @, etc.`
`</>, this, @, etc.`
This seems to be covering an edge case that no longer exists
`</>, this, @, etc.`
isDragging was used to keep the col-resize cursor active
nummi
force-pushed
the
misc-component-cleanup
branch
from
16649e7 to
504e2fd
Compare
nummi
force-pushed
the
misc-component-cleanup
branch
from
acf985e to
00351dd
Compare
RobbieTheWagner
approved these changes
Oct 1, 2019
|
This is 🔥 . Love removing all the controller injections! |
patricklx
pushed a commit
to patricklx/ember-inspector
that referenced
this pull request
Sep 19, 2022
* <DraggableColumn>
`</>, this, @, etc.`
* <DragHandle>
`</>, this, @, etc.`
* Install element-modifiers
* <ResizableColumn>
`</>, this, @, etc.`
* Move DraggableColumn components under Ui
* Remove #setWidth from Ui::ResizableColumn
This seems to be covering an edge case that no longer exists
* <MainContent>
`</>, this, @, etc.`
* Remove {{x-app}}
* Remove isDragging from application controller
isDragging was used to keep the col-resize cursor active
* Rename component MainContent to MonitorContentHeight
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MainContent / MonitorContentHeight
See commits: df45d75 and acf985e
The new component name describes what it actually does.
X-App
See commit eb52384
This component existed to apply two classes:
is-draggingandinactive. This is now handled in the application template.Drag Handle
See commit 504e2fd for changed code.
We were doing a lot of passing around the Application controller and
setIsDraggingaction just to keep the column drag cursor from being glitchy. I removed all of that and just expand the width of the drag column so the hover style (column cursor) stays in place.(The column cursor is applied on hover of the drag handle. If you drag your cursor quickly to the left or right you are briefly not hovering until the UI catches up — this displays the default cursor. To fix this we were tracking
isDraggingat the application level, applying a class to the root to keep the column cursor. There was a lot of plumbing involved and I replaced it simply by increasing the width of the hover area onmousedown.)Default width of column:
On
mousedown:It's a little difficult to see in an animated GIF but here is the glitch without the CSS fix: