Tidy up render-tree tab #1025
Tidy up render-tree tab #1025
Conversation
app/controllers/render-tree.js
Outdated
| } | ||
|
|
||
| return this.model.filter((item) => { | ||
| const regExp = new RegExp(this.escapedSearch); | ||
| return !!recursiveMatch(item, regExp); |
There was a problem hiding this comment.
I'm not sure what the !! is here for since recursiveMatch seems to only return a boolean value. Am I crazy?
There was a problem hiding this comment.
@nummi if it's not needed, should we go ahead and remove?
nummi
force-pushed
the
render-performance-cleanup
branch
3 times, most recently
from
9b79c27 to
9a9f463
Compare
nummi
force-pushed
the
render-performance-cleanup
branch
from
9a9f463 to
d3e094a
Compare
| @@ -58,6 +58,12 @@ | |||
| } | |||
| } | |||
|
|
|||
| .list.list--css-striping { | |||
There was a problem hiding this comment.
This just seemed like the easiest way to get striping working again.
🤷♂️
There was a problem hiding this comment.
Is there not an existing class for striping?
There was a problem hiding this comment.
We do. It’s based on passing a boolean to a row. I think I was struggling with this since the dataset is nested.
app/controllers/render-tree.js
Outdated
| } | ||
|
|
||
| return this.model.filter((item) => { | ||
| const regExp = new RegExp(this.escapedSearch); | ||
| return !!recursiveMatch(item, regExp); |
nummi
force-pushed
the
render-performance-cleanup
branch
from
d3e094a to
c596af0
Compare
| @@ -114,24 +114,6 @@ module('Render Tree Tab', function(hooks) { | |||
| assert.dom(rows[0].querySelector('.js-render-profile-name')).hasText('First View Rendering'); | |||
| assert.dom(rows[1].querySelector('.js-render-profile-name')).hasText('Second View Rendering'); | |||
|
|
|||
| await fillIn('.js-render-profiles-search input', 'first'); | |||
There was a problem hiding this comment.
@nummi do we not need these tests anymore?
There was a problem hiding this comment.
Search filtering is still tested in the lines below these — the code removed here was testing the (broken, see GIF) functionality of opening of children rows.
nummi
force-pushed
the
render-performance-cleanup
branch
2 times, most recently
from
68a011f to
a584904
Compare
- fix table striping
- remove observer
- fix search highlighting
- action, this, {{on}}, etc.
- use Ui:Disclosure
nummi
force-pushed
the
render-performance-cleanup
branch
from
a584904 to
a4fbd1d
Compare
I simply removed the observer for now because the functionality it provided is not very helpful:
I believe this was meant to expand every list item. In the future we could expand the tree where necessary.