Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing an attributes adds quotes to the value #952

Closed
locks opened this issue Apr 2, 2019 · 3 comments · Fixed by #954
Closed

Editing an attributes adds quotes to the value #952

locks opened this issue Apr 2, 2019 · 3 comments · Fixed by #954
Assignees
@RobbieTheWagner
Labels
bug

Comments

@locks
Copy link
Contributor

locks commented Apr 2, 2019

When editing an attribute in the Inspector object side panel, quotes are added to the value being edited. If this value is then submitted, the quotes are escaped:

  1. Screenshot 2019-04-02 at 15 21 57
  2. Screenshot 2019-04-02 at 15 22 01
  3. Screenshot 2019-04-02 at 15 22 09
@locks locks added the bug label Apr 2, 2019
@RobbieTheWagner RobbieTheWagner self-assigned this Apr 2, 2019
@nummi
Copy link
Collaborator

nummi commented Apr 2, 2019

Do we need the quotes at all?

@locks
Copy link
Contributor Author

locks commented Apr 2, 2019

That we are adding the quotes to the input field is what I consider the bug!

@RobbieTheWagner
Copy link
Member

It was probably intended to show the type as a string, but not sure why it is adding them.

RobbieTheWagner added a commit that referenced this issue Apr 2, 2019
@RobbieTheWagner
Remove adding of quotes around string values
8f6087c 
Fixes #952
@RobbieTheWagner RobbieTheWagner mentioned this issue Apr 2, 2019
Merged
RobbieTheWagner added a commit that referenced this issue Apr 17, 2019
@RobbieTheWagner
Remove adding of quotes around string values
0f94177 
Fixes #952
RobbieTheWagner added a commit that referenced this issue Apr 17, 2019
@RobbieTheWagner
Ensure we do not add quotes twice to strings when edited (#954)
8fe181d 
* Remove adding of quotes around string values

Fixes #952

* Revert "Remove adding of quotes around string values"

This reverts commit 8f6087c.

* Remove quotes before wrapping in quotes again

* Abstract parseText to a util function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RobbieTheWagner RobbieTheWagner

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure we do not add quotes twice to strings when edited emberjs/ember-inspector
3 participants
@nummi @locks @RobbieTheWagner