3.12 (#1008)

* Update to 3.12

* es5-getter-ember-codemod

* Testing code mods

* ember-modules-codemod

* Fix lint

app/adapters/basic.js

@@ -85,13 +85,13 @@ export default EmberObject.extend({
     when a message from EmberDebug is received
   **/
   onMessageReceived(callback) {
-    this.get('_messageCallbacks').pushObject(callback);
+    this._messageCallbacks.pushObject(callback);
   },
 
   _messageCallbacks: computed(function() { return []; }),
 
   _messageReceived(message) {
-    this.get('_messageCallbacks').forEach(callback => {
+    this._messageCallbacks.forEach(callback => {
       callback(message);
     });
   },

app/adapters/bookmarklet.js

@@ -26,7 +26,7 @@ export default BasicAdapter.extend({
 
   sendMessage(options) {
     options = options || {};
-    this.get('inspectedWindow').postMessage(options, this.get('inspectedWindowURL'));
+    this.inspectedWindow.postMessage(options, this.inspectedWindowURL);
   },
 
   /**
@@ -43,7 +43,7 @@ export default BasicAdapter.extend({
   _connect() {
     window.addEventListener('message', e => {
       let message = e.data;
-      if (e.origin !== this.get('inspectedWindowURL')) {
+      if (e.origin !== this.inspectedWindowURL) {
         return;
       }
       // close inspector if inspected window is unloading

app/adapters/web-extension.js

@@ -25,15 +25,15 @@ export default BasicAdapter.extend({
 
   sendMessage(options) {
     options = options || {};
-    this.get('_chromePort').postMessage(options);
+    this._chromePort.postMessage(options);
   },
 
   _chromePort: computed(function() {
     return chrome.runtime.connect();
   }),
 
   _connect() {
-    let chromePort = this.get('_chromePort');
+    let chromePort = this._chromePort;
     chromePort.postMessage({ appId: chrome.devtools.inspectedWindow.tabId });
 
     chromePort.onMessage.addListener(message => {

app/adapters/websocket.js

@@ -10,19 +10,19 @@ export default BasicAdapter.extend({
 
   sendMessage(options) {
     options = options || {};
-    this.get('socket').emit('emberInspectorMessage', options);
+    this.socket.emit('emberInspectorMessage', options);
   },
 
   _connect() {
-    this.get('socket').on('emberInspectorMessage', message => {
+    this.socket.on('emberInspectorMessage', message => {
       run(() => {
         this._messageReceived(message);
       });
     });
   },
 
   _disconnect() {
-    this.get('socket').removeAllListeners('emberInspectorMessage');
+    this.socket.removeAllListeners('emberInspectorMessage');
   },
 
   willDestroy() {

app/components/app-picker.js

@@ -11,7 +11,7 @@ export default Component.extend({
 
   selectedDidChange: observer('selectedApp', function() {
     // Change app being debugged
-    const applicationId = this.get('selectedApp');
+    const applicationId = this.selectedApp;
     const port = getOwner(this).lookup('port:main');
     port.set('applicationId', applicationId);
   }),

app/components/deprecation-item-source.js

@@ -15,7 +15,7 @@ export default Component.extend({
 
   url: computed('model.map.{line,source}', 'known', function() {
     let source = this.get('model.map.source');
-    if (this.get('known')) {
+    if (this.known) {
       return `${source}:${this.get('model.map.line')}`;
     } else {
       return 'Unkown source';

app/components/drag-handle.js

@@ -79,8 +79,8 @@ export default Component.extend({
 
   style: computed('side', 'position', 'left', function() {
     let string;
-    if (this.get('side')) {
-      string = `${this.get('side')}: ${(this.get('position') + this.get('left'))}px;`;
+    if (this.side) {
+      string = `${this.side}: ${(this.position + this.left)}px;`;
     } else {
       string = '';
     }
@@ -92,14 +92,14 @@ export default Component.extend({
     let containerOffsetLeft = getOffsetLeft(container);
     let containerOffsetRight = containerOffsetLeft + container.offsetWidth;
 
-    let position = this.get('isLeft') ?
+    let position = this.isLeft ?
       e.pageX - containerOffsetLeft :
       containerOffsetRight - e.pageX;
 
-    position -= this.get('left');
-    if (position >= this.get('minWidth') && position <= this.get('maxWidth')) {
+    position -= this.left;
+    if (position >= this.minWidth && position <= this.maxWidth) {
       this.set('position', position);
-      this.get('on-drag')(position);
+      this['on-drag'](position);
     }
   }
 });

app/components/draggable-column.js

@@ -27,7 +27,7 @@ export default Component.extend({
    * @method triggerResize
    */
   triggerResize() {
-    this.get('layoutService').trigger('resize', { source: 'draggable-column' });
+    this.layoutService.trigger('resize', { source: 'draggable-column' });
   },
 
   actions: {

app/components/item-types.js

@@ -4,6 +4,6 @@ import { computed } from '@ember/object';
 export default Component.extend({
   tagName: '',
   typeClass: computed('type', function() {
-    return `js-${this.get('type')}-type`;
+    return `js-${this.type}-type`;
   })
 });

app/components/list-cell.js

@@ -62,7 +62,7 @@ export default Component.extend({
    * @type {SafeString}
    */
   safeStyle: computed('style', function() {
-    return htmlSafe(this.get('style'));
+    return htmlSafe(this.style);
   }),
 
   /**
@@ -121,6 +121,6 @@ export default Component.extend({
    * @method click
    */
   click() {
-    this.get('on-click')();
+    this['on-click']();
   }
 });

app/components/list-content.js

@@ -60,7 +60,7 @@ export default Component.extend(Evented, {
    */
   setupHeight() {
     this.set('contentHeight', this.get('layoutService.contentHeight'));
-    this.get('layoutService').on('content-height-update', this, this.updateContentHeight);
+    this.layoutService.on('content-height-update', this, this.updateContentHeight);
   },
 
   /**
@@ -76,7 +76,7 @@ export default Component.extend(Evented, {
    * @param  {Number} height The app's new content height
    */
   updateContentHeight(height) {
-    let previousHeight = this.get('contentHeight');
+    let previousHeight = this.contentHeight;
     this.set('contentHeight', height);
     if (previousHeight === 0 && height > 0) {
       this.rerender();
@@ -90,14 +90,14 @@ export default Component.extend(Evented, {
    * @method willDestroyElement
    */
   willDestroyElement() {
-    this.get('layoutService').off('content-height-update', this, this.updateContentHeight);
+    this.layoutService.off('content-height-update', this, this.updateContentHeight);
     return this._super(...arguments);
   },
 
   attributeBindings: ['style'],
 
   style: computed('height', function() {
-    return htmlSafe(`height:${this.get('height')}px`);
+    return htmlSafe(`height:${this.height}px`);
   }),
 
   /**
@@ -114,8 +114,8 @@ export default Component.extend(Evented, {
    * @type {Integer}
    */
   height: computed('contentHeight', 'headerHeight', function() {
-    let headerHeight = this.get('headerHeight');
-    let contentHeight = this.get('contentHeight');
+    let headerHeight = this.headerHeight;
+    let contentHeight = this.contentHeight;
 
     // In testing list-view is created before `contentHeight` is set
     // which will trigger an exception

app/components/list.js

@@ -105,8 +105,8 @@ export default Component.extend({
    * @param  {Object} newAttrs and oldAttrs
    */
   didUpdateAttrs() {
-    let oldSchema = this.get('oldSchema');
-    let newSchema = this.get('schema');
+    let oldSchema = this.oldSchema;
+    let newSchema = this.schema;
     if (newSchema && newSchema !== oldSchema) {
       scheduleOnce('actions', this, this.setupColumns);
     }
@@ -138,9 +138,9 @@ export default Component.extend({
   didInsertElement() {
     scheduleOnce('afterRender', this, this.setupColumns);
     this.onResize = () => {
-      this.get('debounceColumnWidths').perform();
+      this.debounceColumnWidths.perform();
     };
-    this.get('layoutService').on('content-height-update', this.onResize);
+    this.layoutService.on('content-height-update', this.onResize);
     return this._super(...arguments);
   },
 
@@ -220,7 +220,7 @@ export default Component.extend({
     if (listHeader) {
       listHeader.removeEventListener('contextmenu', this.showBasicContext);
     }
-    this.get('layoutService').off('content-height-update', this.onResize);
+    this.layoutService.off('content-height-update', this.onResize);
     return this._super(...arguments);
   },
 
@@ -242,10 +242,10 @@ export default Component.extend({
    */
   setupColumns() {
     let resizableColumns = new ResizableColumns({
-      key: this.get('storageKey'),
+      key: this.storageKey,
       tableWidth: this.getTableWidth(),
-      minWidth: this.get('minWidth'),
-      storage: this.get('storage'),
+      minWidth: this.minWidth,
+      storage: this.storage,
       columnSchema: this.get('schema.columns') || []
     });
     resizableColumns.build();

app/components/main-content.js

@@ -16,7 +16,7 @@ export default Component.extend({
 
   didInsertElement() {
     this._performUpdateHeight = () => {
-      this.get('updateHeightDebounce').perform();
+      this.updateHeightDebounce.perform();
     };
 
     window.addEventListener('resize', this._performUpdateHeight);
@@ -48,7 +48,7 @@ export default Component.extend({
    * @method updateHeight
    */
   updateHeight() {
-    this.get('layoutService').updateContentHeight(this.element.clientHeight);
+    this.layoutService.updateContentHeight(this.element.clientHeight);
   },
 
   willDestroyElement() {

app/components/mixin-detail.js

@@ -42,19 +42,19 @@ export default Component.extend({
   }),
 
   sendToConsole: action(function ({ name }) {
-    let objectId = this.get('objectId');
+    let objectId = this.objectId;
 
-    this.get('port').send('objectInspector:sendToConsole', {
+    this.port.send('objectInspector:sendToConsole', {
       objectId,
       property: name
     });
   }),
 
   calculate: action(function ({ name }) {
-    let objectId = this.get('objectId');
-    let mixinIndex = this.get('mixinDetails.model.mixins').indexOf(this.get('model'));
+    let objectId = this.objectId;
+    let mixinIndex = this.get('mixinDetails.model.mixins').indexOf(this.model);
 
-    this.get('port').send('objectInspector:calculate', {
+    this.port.send('objectInspector:calculate', {
       objectId,
       mixinIndex,
       property: name
@@ -63,17 +63,17 @@ export default Component.extend({
 
   actions: {
     digDeeper({ name }) {
-      let objectId = this.get('objectId');
+      let objectId = this.objectId;
 
-      this.get('port').send('objectInspector:digDeeper', {
+      this.port.send('objectInspector:digDeeper', {
         objectId,
         property: name
       });
     },
 
     saveProperty(property, value, dataType) {
-      this.get('port').send('objectInspector:saveProperty', {
-        objectId: this.get('objectId'),
+      this.port.send('objectInspector:saveProperty', {
+        objectId: this.objectId,
         property,
         value,
         dataType

app/components/mixin-details.js

@@ -34,7 +34,7 @@ export default Component.extend({
   },
 
   traceErrors: action(function () {
-    this.get('port').send('objectInspector:traceErrors', {
+    this.port.send('objectInspector:traceErrors', {
       objectId: this.get('model.objectId')
     });
   }),

app/components/mixin-property.js

@@ -21,7 +21,7 @@ export default Component.extend({
   dateValue: null,
 
   isCalculated: computed('valueType', function () {
-    return this.get('valueType') !== 'type-descriptor';
+    return this.valueType !== 'type-descriptor';
   }),
 
   valueType: alias('model.value.type'),
@@ -63,28 +63,28 @@ export default Component.extend({
 
   valueClick: action(function () {
     if (this.canDig()) {
-      this.get('mixin').send('digDeeper', this.get('model'));
+      this.mixin.send('digDeeper', this.model);
       return;
     }
 
-    if (this.get('isComputedProperty') && !this.get('isCalculated')) {
-      this.get('mixin').send('calculate', this.get('model'));
+    if (this.isComputedProperty && !this.isCalculated) {
+      this.mixin.send('calculate', this.model);
       return;
     }
 
-    if (this.get('isFunction') || this.get('model.overridden') || this.get('model.readOnly')) {
+    if (this.isFunction || this.get('model.overridden') || this.get('model.readOnly')) {
       return;
     }
 
     let value = this.get('model.value.inspect');
-    let type = this.get('valueType');
+    let type = this.valueType;
     if (type === 'type-string') {
       // If the value is not already wrapped in quotes, wrap it
       if (!value.startsWith('"') && !value.endsWith('"')) {
         value = `"${value}"`;
       }
     }
-    if (!this.get('isDate')) {
+    if (!this.isDate) {
       this.set('txtValue', value);
     } else {
       this.set('dateValue', new Date(value));
@@ -95,13 +95,13 @@ export default Component.extend({
   actions: {
     saveProperty() {
       let realValue, dataType;
-      if (!this.get('isDate')) {
-        realValue = parseText(this.get('txtValue'));
+      if (!this.isDate) {
+        realValue = parseText(this.txtValue);
       } else {
-        realValue = this.get('dateValue').getTime();
+        realValue = this.dateValue.getTime();
         dataType = 'date';
       }
-      this.get('mixin').send('saveProperty', this.get('model.name'), realValue, dataType);
+      this.mixin.send('saveProperty', this.get('model.name'), realValue, dataType);
     },
 
     finishedEditing() {