Skip to content

Commit

Permalink
Merge pull request #293 from teddyzeenny/upgrade-ember-cli
Browse files Browse the repository at this point in the history
Upgrade to ember-cli 0.1.12
  • Loading branch information
teddyzeenny committed Feb 2, 2015
2 parents 7189d26 + 4a82b1e commit 2d39818
Show file tree
Hide file tree
Showing 60 changed files with 286 additions and 289 deletions.
2 changes: 1 addition & 1 deletion .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,5 @@ indent_size = 2
indent_style = space
indent_size = 2

[*.md]
[*.{diff,md}]
trim_trailing_whitespace = false
4 changes: 2 additions & 2 deletions .jshintrc
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"window",
"-Promise"
],
"browser" : true,
"boss" : true,
"browser": true,
"boss": true,
"curly": true,
"debug": false,
"devel": true,
Expand Down
5 changes: 5 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ cache:
directories:
- node_modules

before_install:
- "npm config set spin false"
- "npm install -g npm@^2"


install:
- npm install -g bower
- npm install
Expand Down
2 changes: 1 addition & 1 deletion Brocfile.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* global require, module */

var EmberApp = require('ember-cli/lib/broccoli/ember-app');
var compileES6 = require('ember-cli/node_modules/broccoli-es6-concatenator');
var compileES6 = require('broccoli-es6-concatenator');
var mergeTrees = require('broccoli-merge-trees');
var wrapFiles = require('broccoli-wrap');
var pickFiles = require('broccoli-static-compiler');
Expand Down
2 changes: 1 addition & 1 deletion app/components/drag-handle.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import Ember from "ember";

export default Ember.Component.extend({
classNames: ['drag-handle'],
classNameBindings: ['isLeft:drag-handle--left', 'isRight:drag-handle--right'],
classNameBindings: ['isLeft:drag-handle--left', 'isRight:drag-handle--right', 'class'],
attributeBindings: ['style'],
position: 0,
side: '',
Expand Down
3 changes: 3 additions & 0 deletions app/components/draggable-column.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ export default Component.extend({
side: 'left',
minWidth: 60,
setIsDragging: 'setIsDragging',
classes: function() {
return this.get('classNames').join(' ');
}.property('classNames.[]'),
actions: {
setIsDragging: function(isDragging) {
this.sendAction('setIsDragging', isDragging);
Expand Down
4 changes: 4 additions & 0 deletions app/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,15 @@

<link rel="stylesheet" href="assets/vendor.css">
<link rel="stylesheet" href="assets/ember-inspector.css">

{{content-for 'head-footer'}}
</head>
<body>
{{content-for 'body'}}

<script src="assets/vendor.js"></script>
<script src="assets/ember-inspector.js"></script>

{{content-for 'body-footer'}}
</body>
</html>
2 changes: 1 addition & 1 deletion app/router.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ var Router = Ember.Router.extend({
});

Router.map(function() {
this.resource('application-detected', { path: '/' }, function() {
this.resource('app-detected', { path: '/' }, function() {
this.resource('view-tree', { path: '/' });
this.resource('route-tree');

Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{#resizable-column width=width classNames=classNames}}
{{#resizable-column width=width class=classes}}
{{yield}}
{{/resizable-column}}

Expand Down
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<svg version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px"
width="14px" height="14px" viewBox="0 0 54.203 55.142" enable-background="new 0 0 54.203 55.142" xml:space="preserve">
<path fill="#797979" d="M54.203,21.472l-0.101-1.042h0.101c-0.042-0.159-0.101-0.311-0.146-0.468l-1.82-18.786l-6.056,6.055
C41.277,2.741,34.745,0,27.571,0C12.344,0,0,12.344,0,27.571s12.344,27.571,27.571,27.571c12.757,0,23.485-8.666,26.632-20.431
h-8.512c-2.851,7.228-9.881,12.349-18.12,12.349c-10.764,0-19.49-8.726-19.49-19.489s8.727-19.489,19.49-19.489
c4.942,0,9.441,1.853,12.873,4.887l-6.536,6.536L54.203,21.472z"/>
</svg>
<svg version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px"
width="14px" height="14px" viewBox="0 0 54.203 55.142" enable-background="new 0 0 54.203 55.142" xml:space="preserve">
<path fill="#797979" d="M54.203,21.472l-0.101-1.042h0.101c-0.042-0.159-0.101-0.311-0.146-0.468l-1.82-18.786l-6.056,6.055
C41.277,2.741,34.745,0,27.571,0C12.344,0,0,12.344,0,27.571s12.344,27.571,27.571,27.571c12.757,0,23.485-8.666,26.632-20.431
h-8.512c-2.851,7.228-9.881,12.349-18.12,12.349c-10.764,0-19.49-8.726-19.49-19.489s8.727-19.489,19.49-19.489
c4.942,0,9.441,1.853,12.873,4.887l-6.536,6.536L54.203,21.472z"/>
</svg>
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
4 changes: 0 additions & 4 deletions app/templates/iframes.handlebars

This file was deleted.

4 changes: 4 additions & 0 deletions app/templates/iframes.hbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
<div class="dropdown">
{{view 'select' content=model value=selectedApp optionValuePath="content.val" optionLabelPath="content.name" class="dropdown__select"}}
<div class="dropdown__arrow"></div>
</div>
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
15 changes: 7 additions & 8 deletions bower.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,14 @@
"dependencies": {
"handlebars": "~1.3.0",
"jquery": "^1.11.1",
"ember": "1.7.0",
"ember-data": "1.0.0-beta.10",
"ember-resolver": "~0.1.7",
"loader.js": "stefanpenner/loader.js#1.0.1",
"ember-cli-shims": "stefanpenner/ember-cli-shims#0.0.3",
"ember-cli-test-loader": "rwjblue/ember-cli-test-loader#0.0.4",
"ember-load-initializers": "stefanpenner/ember-load-initializers#0.0.2",
"ember": "1.8.1",
"ember-resolver": "~0.1.11",
"loader.js": "ember-cli/loader.js#1.0.1",
"ember-cli-shims": "ember-cli/ember-cli-shims#0.0.3",
"ember-cli-test-loader": "ember-cli/ember-cli-test-loader#0.1.0",
"ember-load-initializers": "ember-cli/ember-load-initializers#0.0.2",
"ember-qunit": "0.1.8",
"ember-qunit-notifications": "0.0.4",
"ember-qunit-notifications": "0.0.5",
"qunit": "~1.15.0",
"pikaday": "~1.2.0",
"moment": "~2.8.4"
Expand Down
6 changes: 3 additions & 3 deletions config/environment.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,16 @@ module.exports = function(environment) {

if (environment === 'development') {
// ENV.APP.LOG_RESOLVER = true;
//ENV.APP.LOG_ACTIVE_GENERATION = true;
// ENV.APP.LOG_ACTIVE_GENERATION = true;
// ENV.APP.LOG_TRANSITIONS = true;
// ENV.APP.LOG_TRANSITIONS_INTERNAL = true;
//ENV.APP.LOG_VIEW_LOOKUPS = true;
// ENV.APP.LOG_VIEW_LOOKUPS = true;
}

if (environment === 'test') {
// Testem prefers this...
ENV.baseURL = '/';
ENV.locationType = 'auto';
ENV.locationType = 'none';

// keep test console output quieter
ENV.APP.LOG_ACTIVE_GENERATION = false;
Expand Down
12 changes: 8 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,21 +37,25 @@
},
"devDependencies": {
"body-parser": "^1.2.0",
"broccoli-asset-rev": "0.3.1",
"broccoli-asset-rev": "^2.0.0",
"broccoli-concat": "0.0.12",
"broccoli-ember-hbs-template-compiler": "^1.6.1",
"broccoli-es6-concatenator": "^0.1.11",
"broccoli-file-remover": "^0.3.1",
"broccoli-jshint": "^0.5.3",
"broccoli-merge-trees": "^0.2.1",
"broccoli-sass": "0.2.4",
"broccoli-static-compiler": "^0.2.1",
"broccoli-wrap": "0.0.2",
"ember-cli": "0.1.4",
"ember-cli": "0.1.12",
"ember-cli-6to5": "^3.0.0",
"ember-cli-app-version": "0.3.1",
"ember-cli-content-security-policy": "0.3.0",
"ember-cli-dependency-checker": "0.0.7",
"ember-cli-ic-ajax": "0.1.1",
"ember-cli-inject-live-reload": "^1.3.0",
"ember-cli-qunit": "0.1.0",
"ember-data": "1.0.0-beta.10",
"ember-cli-qunit": "0.3.1",
"ember-cli-uglify": "1.0.1",
"ember-export-application-global": "^1.0.0",
"ember-pikaday": "^0.2.1",
"express": "^4.8.5",
Expand Down
2 changes: 1 addition & 1 deletion testem.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"framework": "qunit",
"test_page": "tests/index.html",
"test_page": "tests/index.html?hidepassed",
"launch_in_ci": [
"PhantomJS"
],
Expand Down
4 changes: 2 additions & 2 deletions tests/ember_debug/view_debug_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ function setupApp(){
});

setTemplate('application', '{{outlet}}');
setTemplate('simple', 'Simple {{input class="simple-input"}} {{view Ember.View classNames="simple-view"}}');
setTemplate('simple', 'Simple {{input class="simple-input"}} {{view "select" classNames="simple-view"}}');
setTemplate('comments/index', '{{#each}}{{this}}{{/each}}');
setTemplate('posts', 'Posts');
}
Expand Down Expand Up @@ -283,7 +283,7 @@ test("Highlighting Views on hover", function() {
})
.then(function() {
var previewDiv = findByLabel('preview-div');
equal(findByLabel('layer-view', previewDiv).text(), 'Ember.View', "Views without controllers can be configured to be highlighted.");
equal(findByLabel('layer-view', previewDiv).text(), 'Ember.Select', "Views without controllers can be configured to be highlighted.");
port.trigger('view:inspectViews', { inspect: false });
return wait();
})
Expand Down
21 changes: 8 additions & 13 deletions tests/helpers/start-app.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,21 @@ import Ember from 'ember';
import Application from '../../app';
import Router from '../../router';
import config from '../../config/environment';
var guidFor = Ember.guidFor;
let { generateGuid } = Ember;

export default function startApp(attrs) {
var App;

var attributes = Ember.merge({}, config.APP);
attributes = Ember.merge(attributes, attrs); // use defaults, but you can override;

Router.reopen({
location: 'none'
Application.initializer({
name: generateGuid() + "-detectEmberApplication",
initialize: function(container, application) {
container.lookup('route:app-detected').reopen({
model: Ember.K,
});
}
});

Ember.run(function() {
Expand All @@ -20,16 +25,6 @@ export default function startApp(attrs) {
App.injectTestHelpers();
});

App.initializer({
name: guidFor(App) + "-detectEmberApplication",
initialize: function(container, application) {
container.lookup('route:application-detected').reopen({
model: Ember.K,
});
}
});

App.reset(); // this shouldn't be needed, i want to be able to "start an app at a specific URL"

return App;
}
Expand Down
24 changes: 6 additions & 18 deletions tests/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -13,26 +13,11 @@
<link rel="stylesheet" href="assets/vendor.css">
<link rel="stylesheet" href="assets/ember-inspector.css">
<link rel="stylesheet" href="assets/test-support.css">
<style>
#ember-testing-container {
position: absolute;
background: white;
bottom: 0;
right: 0;
width: 640px;
height: 384px;
overflow: auto;
z-index: 9999;
border: 1px solid #ccc;
}
#ember-testing {
zoom: 50%;
}
</style>

{{content-for 'head-footer'}}
{{content-for 'test-head-footer'}}
</head>
<body>
<div id="qunit"></div>
<div id="qunit-fixture"></div>

{{content-for 'body'}}
{{content-for 'test-body'}}
Expand All @@ -42,5 +27,8 @@
<script src="ember_debug.js"></script>
<script src="testem.js"></script>
<script src="assets/test-loader.js"></script>

{{content-for 'body-footer'}}
{{content-for 'test-body-footer'}}
</body>
</html>
6 changes: 0 additions & 6 deletions tests/test-helper.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,6 @@ import {

setResolver(resolver);

document.write('<div id="ember-testing-container"><div id="ember-testing"></div></div>');

QUnit.config.urlConfig.push({ id: 'nocontainer', label: 'Hide container'});
var containerVisibility = QUnit.urlParams.nocontainer ? 'hidden' : 'visible';
document.getElementById('ember-testing-container').style.visibility = containerVisibility;

window.NO_EMBER_DEBUG = true;


Expand Down
Loading

0 comments on commit 2d39818

Please sign in to comment.