Update development dependencies #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertdeblock
force-pushed
the
update-dev-deps
branch
from
39ba900 to
ad1471b
Compare
bertdeblock
commented
Aug 18, 2023
| @@ -1035,7 +1035,7 @@ describe('ember-cli-babel', function() { | |||
| expect( | |||
| output.read() | |||
| ).to.deep.equal({ | |||
| "foo.js": `define(\"foo\", [], function () {\n \"use strict\";\n\n Ember.String.camelize('stuff-here');\n});` | |||
| "foo.js": `define("foo", [], function () {\n "use strict";\n\n Ember.String.camelize('stuff-here');\n});` | |||
There was a problem hiding this comment.
These escapes were marked as unnecessary by ESLint.
| @@ -30,8 +30,7 @@ | |||
| }, | |||
| "scripts": { | |||
| "build": "ember build", | |||
| "changelog": "lerna-changelog", | |||
There was a problem hiding this comment.
Remnant of an older release setup.
| @@ -7,10 +10,10 @@ export default class ApplicationController extends Controller { | |||
| constructor() { | |||
| super(...arguments); | |||
|
|
|||
| this.animal = new Animal('dog'); | |||
| set(this, 'animal', new Animal('dog')); | |||
There was a problem hiding this comment.
Fixes by eslint-plugin-ember.
| @@ -6,13 +6,6 @@ const browsers = [ | |||
| 'last 1 Safari versions' | |||
| ]; | |||
|
|
|||
| const isCI = !!process.env.CI; | |||
There was a problem hiding this comment.
Fixes the Uncaught TypeError: (0 , _emberBabel.extends) is not a function error.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly silences a bunch of logs / warnings / vulnerabilities.
Reviewing commit per commit should make this PR clearer.