Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ember-try away from bower #57

Merged
merged 5 commits into from
Jan 18, 2018
Merged

Conversation

thoov
Copy link
Member

@thoov thoov commented Jan 17, 2018

Fixes: #56

@thoov thoov requested a review from rwjblue January 17, 2018 23:18
@@ -39,7 +39,8 @@
"ember-load-initializers": "^1.0.0",
"ember-qunit-assert-helpers": "^0.2.1",
"ember-resolver": "^4.0.0",
"ember-source": "http://builds.emberjs.com/beta/shas/08bc55d20f76f874b6a7ceefd4007dde1aa7c9dc.tgz",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yarn is complaining about this so I updated it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine (we want to use a tagged release anyways), though I am curious what yarns issue was?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screen shot 2018-01-17 at 5 07 27 pm
@rwjblue This is the error

@locks locks merged commit c0eb458 into emberjs:master Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants