Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint-plugin-n to eslint config for node files #9057

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

gitKrystan
Copy link
Contributor

@gitKrystan gitKrystan commented Oct 25, 2023

Description

  • Tweak .vscode/settings.json so that VSCode ESLint server finds TSConfig files as expected
  • Add eslint-plugin-n to ESLint config for Node files
  • Splits ESLint config for "config" type Node files (e.g. babel, eslint, rollup config files) from project Node files, which have slightly different rules
  • Enables the --report-unused-disable-directives so that ESLint will error in that case
  • Fixes all of the resulting lint errors
  • Adds a VSCode task config for running pnpm lint and populating the VSCode Problems panel

Progress on #9041

Notes for the release

@gitKrystan gitKrystan changed the title eslint node config Add eslint-plugin-n to eslint config for node files Oct 25, 2023
@gitKrystan gitKrystan merged commit a8f8630 into main Oct 25, 2023
20 checks passed
@delete-merged-branch delete-merged-branch bot deleted the eslint-node-config branch October 25, 2023 23:31
@gitKrystan gitKrystan added 🏷️ chore This PR primarily refactors code or updates dependencies 🎯 canary PR is targeting canary (default) labels Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 canary PR is targeting canary (default) 🏷️ chore This PR primarily refactors code or updates dependencies
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants