Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(types): split out lint and type commands to be per-package #9032

Merged
merged 35 commits into from
Oct 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
98a1820
stash
runspired Oct 21, 2023
47bb92e
stash progress on lint and tsc split out
runspired Oct 22, 2023
80846b5
cleanup
runspired Oct 22, 2023
12a0a7a
more cleanup
runspired Oct 22, 2023
2c78c09
attempt to fix deps
runspired Oct 22, 2023
43e8934
get more things working
runspired Oct 22, 2023
4dfdfdf
more lockfile cleanup
runspired Oct 22, 2023
ab9091a
things
runspired Oct 22, 2023
3eafbdf
fix builds
runspired Oct 22, 2023
102221e
fix test
runspired Oct 22, 2023
9c21db2
port turbo work
runspired Oct 23, 2023
16da562
small tweaks
runspired Oct 23, 2023
1e097a3
fix boolean
runspired Oct 23, 2023
65cb750
decycle
runspired Oct 23, 2023
2b89b3a
fix another cycle
runspired Oct 23, 2023
6c9f7ca
build
runspired Oct 23, 2023
652564e
fix build
runspired Oct 23, 2023
83f267c
more improvements
runspired Oct 23, 2023
e19a24d
fix main tests
runspired Oct 23, 2023
96cfae2
more fixups
runspired Oct 23, 2023
76ed67c
remove some dead stuff
runspired Oct 23, 2023
f592341
remove unused pnpm peer ignores
runspired Oct 23, 2023
0a5a4f0
cleanup test commands
runspired Oct 23, 2023
d113465
more task cleanup
runspired Oct 23, 2023
a255d2e
fixup some tests
runspired Oct 23, 2023
0dcf844
some turbo cleanup
runspired Oct 23, 2023
844f544
more command cleanup
runspired Oct 23, 2023
25f520d
make tests nicer?
runspired Oct 23, 2023
0db854c
fix fastboot tests
runspired Oct 23, 2023
ad01695
gets it all working
runspired Oct 23, 2023
b3c4fa4
test:production
runspired Oct 23, 2023
3fe1040
fix test:production
runspired Oct 23, 2023
f7fa79e
fixup some test runs
runspired Oct 23, 2023
de9102d
skip adapter prod
runspired Oct 23, 2023
e255537
more test fixes for prod
runspired Oct 23, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .eslintrc.js → ._eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ module.exports = {
env: {
browser: true,
node: false,
es6: true,
es2022: true,
},
overrides: [
{
Expand Down
54 changes: 0 additions & 54 deletions .eslintignore

This file was deleted.

6 changes: 6 additions & 0 deletions .github/actions/setup/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,12 @@ runs:
with:
bun-version: latest

- name: 'Setup local TurboRepo server'
if: ${{ inputs.repo-token }}
uses: felixmosh/turborepo-gh-artifacts@v2
with:
repo-token: ${{ inputs.repo-token }}

- name: Configure Parallel Builds
if: ${{ inputs.parallel-build == 'true' }}
shell: bash
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/alpha-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ on:
- cron: '0 20 * * 2' # weekly (Tuesday) 12 PM PST
- cron: '0 20 * * 5' # weekly (Friday) 12 PM PST

env:
TURBO_API: http://127.0.0.1:9080
TURBO_TOKEN: this-is-not-a-secret
TURBO_TEAM: myself

jobs:
release:
name: Run publish script
Expand All @@ -26,6 +31,7 @@ jobs:
- uses: ./.github/actions/setup
with:
install: true
repo-token: ${{ secrets.GITHUB_TOKEN }}
- name: Make sure git user is setup
run: |
git config --local user.email '[email protected]'
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/asset-size-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ on:
- synchronize
- ready_for_review

env:
TURBO_API: http://127.0.0.1:9080
TURBO_TOKEN: this-is-not-a-secret
TURBO_TEAM: myself

concurrency:
group: asset-size-${{ github.head_ref || github.ref_name }}
cancel-in-progress: true
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/beta-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@ name: Canary-Mirror-Beta Release
on:
workflow_dispatch:

env:
TURBO_API: http://127.0.0.1:9080
TURBO_TOKEN: this-is-not-a-secret
TURBO_TEAM: myself

jobs:
release:
name: Run publish script
Expand All @@ -25,6 +30,7 @@ jobs:
with:
build-addons: true
install: true
repo-token: ${{ secrets.GITHUB_TOKEN }}
- name: Make sure git user is setup
run: |
git config --local user.email '[email protected]'
Expand Down
10 changes: 10 additions & 0 deletions .github/workflows/compat-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ on:
branches:
- main

env:
TURBO_API: http://127.0.0.1:9080
TURBO_TOKEN: this-is-not-a-secret
TURBO_TEAM: myself

concurrency:
group: compat-${{ github.head_ref || github.ref_name }}
cancel-in-progress: true
Expand All @@ -19,6 +24,7 @@ jobs:
with:
restore-broccoli-cache: true
install: true
repo-token: ${{ secrets.GITHUB_TOKEN }}
- name: Run Tests
run: pnpm test:fastboot
embroider:
Expand All @@ -30,6 +36,7 @@ jobs:
with:
restore-broccoli-cache: true
install: true
repo-token: ${{ secrets.GITHUB_TOKEN }}
- name: Run Tests
run: pnpm test:embroider
env:
Expand All @@ -40,6 +47,8 @@ jobs:
steps:
- uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4
- uses: ./.github/actions/setup
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
- name: Install dependencies w/o lockfile
run: pnpm install --no-lockfile
- name: Basic Tests
Expand All @@ -58,5 +67,6 @@ jobs:
node-version: ${{ matrix.node-version }}
restore-broccoli-cache: true
install: true
repo-token: ${{ secrets.GITHUB_TOKEN }}
- name: Basic Tests
run: pnpm test
5 changes: 5 additions & 0 deletions .github/workflows/deprecations-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@ name: 'Check Deprecations'
on:
workflow_dispatch:

env:
TURBO_API: http://127.0.0.1:9080
TURBO_TOKEN: this-is-not-a-secret
TURBO_TEAM: myself

jobs:
test-all-deprecations:
runs-on: ubuntu-latest
Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/docs-and-blueprint-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ on:
branches:
- main

env:
TURBO_API: http://127.0.0.1:9080
TURBO_TOKEN: this-is-not-a-secret
TURBO_TEAM: myself

concurrency:
group: docs-${{ github.head_ref || github.ref_name }}
cancel-in-progress: true
Expand All @@ -18,7 +23,8 @@ jobs:
- uses: ./.github/actions/setup
with:
install: true
repo-token: ${{ secrets.GITHUB_TOKEN }}
- name: Test Docs
run: pnpm test:docs
- name: Test Blueprints
run: pnpm --filter blueprint-tests run test
run: pnpm test:blueprints
6 changes: 6 additions & 0 deletions .github/workflows/infra-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ on:
- synchronize
- ready_for_review

env:
TURBO_API: http://127.0.0.1:9080
TURBO_TOKEN: this-is-not-a-secret
TURBO_TEAM: myself

concurrency:
group: infra-${{ github.head_ref || github.ref_name }}
cancel-in-progress: true
Expand All @@ -24,6 +29,7 @@ jobs:
with:
restore-broccoli-cache: true
install: true
repo-token: ${{ secrets.GITHUB_TOKEN }}
- name: pnpm test infra compatWith 3.0
env:
COMPAT_WITH: '3.0'
Expand Down
18 changes: 14 additions & 4 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ on:
tags:
- '*'

env:
TURBO_API: http://127.0.0.1:9080
TURBO_TOKEN: this-is-not-a-secret
TURBO_TEAM: myself

concurrency:
group: ci-${{ github.head_ref || github.ref_name }}
cancel-in-progress: true
Expand All @@ -26,10 +31,11 @@ jobs:
with:
restore-lint-caches: true
install: true
- name: Lint js
run: pnpm lint:js
- name: Check for TypeScript problems
run: pnpm problems
repo-token: ${{ secrets.GITHUB_TOKEN }}
- name: Lint
run: pnpm lint
- name: Check Uncompiled Packages for TypeScript Compilation Errors
run: pnpm check:types

special-build-tests:
timeout-minutes: 20
Expand All @@ -40,6 +46,7 @@ jobs:
with:
restore-broccoli-cache: true
install: true
repo-token: ${{ secrets.GITHUB_TOKEN }}
- if: |
github.event_name == 'pull_request' && (
github.base_ref == 'main' || github.base_ref == 'beta'
Expand Down Expand Up @@ -82,6 +89,7 @@ jobs:
jobs: 2
parallel-build: true
install: true
repo-token: ${{ secrets.GITHUB_TOKEN }}

- name: Check for Test Failure Retry
id: retry-test-failures
Expand Down Expand Up @@ -147,6 +155,7 @@ jobs:
with:
restore-broccoli-cache: true
install: true
repo-token: ${{ secrets.GITHUB_TOKEN }}
- name: Basic tests with ${{ matrix.scenario }}
timeout-minutes: 12
env:
Expand All @@ -173,6 +182,7 @@ jobs:
with:
restore-broccoli-cache: true
install: true
repo-token: ${{ secrets.GITHUB_TOKEN }}
- name: Basic tests with ${{ matrix.release }}
env:
CI: true
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/partner-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ on:
- synchronize
- ready_for_review

env:
TURBO_API: http://127.0.0.1:9080
TURBO_TOKEN: this-is-not-a-secret
TURBO_TEAM: myself

concurrency:
group: partners-${{ github.head_ref || github.ref_name }}
cancel-in-progress: true
Expand Down Expand Up @@ -54,6 +59,7 @@ jobs:
restore-broccoli-cache: true
install: true
build-addons: true
repo-token: ${{ secrets.GITHUB_TOKEN }}
- name: Generate package tarballs
run: node ./scripts/packages-for-commit.js
- name: Run Tests
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/perf-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ on:
- synchronize
- ready_for_review

env:
TURBO_API: http://127.0.0.1:9080
TURBO_TOKEN: this-is-not-a-secret
TURBO_TEAM: myself

concurrency:
group: perf-${{ github.head_ref || github.ref_name }}
cancel-in-progress: true
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/perf-over-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ on:
- synchronize
- ready_for_review

env:
TURBO_API: http://127.0.0.1:9080
TURBO_TOKEN: this-is-not-a-secret
TURBO_TEAM: myself

concurrency:
group: perf-release-${{ github.head_ref || github.ref_name }}
cancel-in-progress: true
Expand Down
7 changes: 4 additions & 3 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -22,18 +22,19 @@ packages/rest/addon
packages/active-record/addon
packages/data-worker/addon
packages/schema-record/addon/
packages/core/addon/
packages/core-types/addon

# dependencies
bower_components
node_modules
scripts/asset-size-tracking/current-data.json

# misc
.turbo/
.env*
.pnp*
.sass-cache
/.eslintcache
.eslintcache
/onnect.lock
coverage/*
libpeerconnection.log
Expand Down Expand Up @@ -65,6 +66,6 @@ benchmarks/results/*.json
/packages/*/DEBUG
/tests/*/DEBUG

.vscode/
!.vscode/
.idea/
*.iml
3 changes: 0 additions & 3 deletions .prettierrc

This file was deleted.

5 changes: 5 additions & 0 deletions .prettierrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
module.exports = {
singleQuote: true,
trailingComma: 'es5',
printWidth: 120
}
5 changes: 5 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"files.associations": {
"turbo.json": "jsonc"
}
}
2 changes: 1 addition & 1 deletion @types/ember-data-qunit-asserts/index.d.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { CacheOperation, NotificationType } from "@ember-data/store/-private/managers/notification-manager";
import type { StableDocumentIdentifier } from "@ember-data/store/-types/cache/identifier";
import type { StableRecordIdentifier } from "@warp-drive/core";
import type { StableRecordIdentifier } from "@warp-drive/core-types";

declare global {
interface DeprecationConfig {
Expand Down
1 change: 0 additions & 1 deletion @types/ember/index.d.ts

This file was deleted.

Loading