Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable request cache without hydration, better error handling by Fetch Handler #8518

Merged
merged 4 commits into from
Apr 1, 2023
Merged

feat: enable request cache without hydration, better error handling by Fetch Handler #8518

merged 4 commits into from
Apr 1, 2023

Conversation

runspired
Copy link
Contributor

@runspired runspired commented Mar 30, 2023 •
edited
Loading

  • handle 400/500 errors
  • handle returned JSON
  • ensures any opcode can be cached and hydrated
  • ensures non-store issued requests can be cached if desired (by supplying the store)

resolves #8514
resolves #8519

@runspired runspired added 🎯 canary PR is targeting canary (default) 🏷️ feat This PR introduces a new feature labels Mar 30, 2023
@runspired runspired changed the base branch from main to silent-store April 1, 2023 00:30
@runspired runspired changed the base branch from silent-store to main April 1, 2023 00:30
@runspired
feat: enable request cache without hydration (#8528)
01f5dc3 
* fix: enable cache without hydration

* move test files to correct location

* add more tests
@runspired runspired changed the title feat: FetchHandler - better error handling feat: enable request cache without hydration, better error handling by Fetch Handler Apr 1, 2023
@runspired runspired merged commit eb74f57 into main Apr 1, 2023
@delete-merged-branch delete-merged-branch bot deleted the improved-fetch branch April 1, 2023 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🎯 canary PR is targeting canary (default) 🏷️ feat This PR introduces a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cache] attributes of records got missing [Request] Make fetch a bit less basic
1 participant
@runspired