fix: de-cycle ember-concurrency access of promise #8435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
added a commit
that referenced
this pull request
Feb 27, 2023
* fix: de-cycle ember-concurrency access of promise * decycle another
This was referenced Feb 27, 2023
runspired
added a commit
that referenced
this pull request
Feb 27, 2023
* fix: de-cycle ember-concurrency access of promise * decycle another
runspired
added a commit
that referenced
this pull request
Feb 27, 2023
runspired
added a commit
that referenced
this pull request
Feb 27, 2023
sergiofenoll
added a commit
to kanselarij-vlaanderen/frontend-kaleidos
that referenced
this pull request
Jul 11, 2023
It's good that we match the minor of Ember we're using elsewhere, but we also specifically need it to resolve a deprecation, which was fixed in this PR: emberjs/data#8435 TL;DR: accessing promise proxies, which are returned by ED in stuff like store.query and such is deprecated, as they will soon become regular promises. Ember concurrency was accessing these proxies in some way, but this was triggering the deprecation. See: machty/ember-concurrency#463
fivetanley
added a commit
to fivetanley/data
that referenced
this pull request
Oct 16, 2023
backporting emberjs#8435 to 4.4
fivetanley
added a commit
to fivetanley/data
that referenced
this pull request
Oct 16, 2023
backporting emberjs#8435 to 4.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #8312