Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: embroider compat #8427

Merged
merged 6 commits into from
Feb 25, 2023
Merged

fix: embroider compat #8427

merged 6 commits into from
Feb 25, 2023

Conversation

runspired
Copy link
Contributor

resolves #8396

@runspired runspired added 🏷️ bug This PR primarily fixes a reported issue backport-release PR targets the current release branch labels Feb 25, 2023
fix

Verified

This commit was signed with the committer’s verified signature.
drashna Drashna Jaelre
@runspired runspired merged commit e0f92a2 into release Feb 25, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-embroider-release branch February 25, 2023 09:19
@Techn1x
Copy link

Techn1x commented Jun 30, 2023

This feels like it should be backported to 4.8 LTS, but I don't know how complicated that task would be

(as a result I'm skipping all the way to 4.12.. hitting other issues instead with that)

@runspired
Copy link
Contributor Author

It's too difficult to support 4.8 at this point, and I suspect this was one of dozens of PRs that would need backported for this fix to actually apply there. Sorry for the inconvenience :(

@Techn1x
Copy link

Techn1x commented Jul 7, 2023

That's okay :) totally understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-release PR targets the current release branch 🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants