Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: uuid polyfill logic #8159

Merged
merged 2 commits into from
Sep 2, 2022
Merged

fix: uuid polyfill logic #8159

merged 2 commits into from
Sep 2, 2022

Conversation

runspired
Copy link
Contributor

rollup doesn't understand importSync, so we can't use it within a module.

cc @kiwi-josh

@jrjohnson this will need back ported.

@runspired runspired added 🎯 release PR should be backported to release 🎯 canary PR is targeting canary (default) 🎯 lts The PR should be backported to the most recent LTS 🏷️ bug This PR primarily fixes a reported issue labels Sep 1, 2022
@github-actions
Copy link

github-actions bot commented Sep 1, 2022

Asset Size Report for c44b280

Modern Builds

☑️ EmberData has not changed in size

If any packages had changed sizes they would be listed here.

Changeset



Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '163.11 KB' │
│ compressed │ '34.86 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '44.71 KB' │
│  compressed  │ '9.56 KB'  │
│ % Of Library │   '27.4'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 44.23 KB  | 9.45 KB    | 98.9          | 27.1
	@ember-data/model/index                           | 486.00 B  | 103.87 B   | 1.1           | 0.3

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '42.30 KB' │
│  compressed  │ '9.04 KB'  │
│ % Of Library │   '25.9'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 41.31 KB  | 8.83 KB    | 97.6          | 25.3
	@ember-data/store/index                           | 1022.00 B | 218.43 B   | 2.4           | 0.6

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '21.99 KB' │
│  compressed  │ '4.70 KB'  │
│ % Of Library │   '13.5'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 21.99 KB  | 4.70 KB    | 100.0         | 13.5

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '20.42 KB' │
│  compressed  │ '4.36 KB'  │
│ % Of Library │   '12.5'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.36 KB   | 1.57 KB    | 36.0          | 4.5
	@ember-data/serializer/-private                   | 5.60 KB   | 1.20 KB    | 27.4          | 3.4
	@ember-data/serializer/json-api                   | 3.79 KB   | 829.47 B   | 18.6          | 2.3
	@ember-data/serializer/rest                       | 2.87 KB   | 627.07 B   | 14.0          | 1.8
	@ember-data/serializer/index                      | 611.00 B  | 130.58 B   | 2.9           | 0.4
	@ember-data/serializer/transform                  | 215.00 B  | 45.95 B    | 1.0           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.93 KB' │
│  compressed  │ '3.41 KB'  │
│ % Of Library │   '9.8'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 7.88 KB   | 1.68 KB    | 49.5          | 4.8
	@ember-data/adapter/-private                      | 3.79 KB   | 828.40 B   | 23.8          | 2.3
	@ember-data/adapter/error                         | 1.82 KB   | 398.81 B   | 11.4          | 1.1
	@ember-data/adapter/index                         | 1.41 KB   | 309.05 B   | 8.9           | 0.9
	@ember-data/adapter/json-api                      | 1.03 KB   | 226.33 B   | 6.5           | 0.6

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '8.32 KB' │
│  compressed  │ '1.78 KB' │
│ % Of Library │   '5.1'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 1.98 KB   | 434.29 B   | 23.8          | 1.2
	ember-data/-private                               | 1.53 KB   | 335.76 B   | 18.4          | 0.9
	ember-data/adapters/errors                        | 1.19 KB   | 260.10 B   | 14.3          | 0.7
	ember-data/setup-container                        | 368.00 B  | 78.65 B    | 4.3           | 0.2
	ember-data/relationships                          | 318.00 B  | 67.96 B    | 3.7           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 58.56 B    | 3.2           | 0.2
	ember-data/serializers/json-api                   | 251.00 B  | 53.64 B    | 2.9           | 0.2
	ember-data/adapters/json-api                      | 245.00 B  | 52.36 B    | 2.9           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 51.93 B    | 2.9           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 51.93 B    | 2.9           | 0.1
	ember-data/transform                              | 241.00 B  | 51.50 B    | 2.8           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 50.65 B    | 2.8           | 0.1
	ember-data/serializer                             | 232.00 B  | 49.58 B    | 2.7           | 0.1
	ember-data/adapter                                | 226.00 B  | 48.30 B    | 2.7           | 0.1
	ember-data/model                                  | 222.00 B  | 47.44 B    | 2.6           | 0.1
	ember-data/store                                  | 222.00 B  | 47.44 B    | 2.6           | 0.1
	ember-data/attr                                   | 218.00 B  | 46.59 B    | 2.6           | 0.1
	ember-data/version                                | 161.00 B  | 34.41 B    | 1.9           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.67 KB' │
│  compressed  │ '1.42 KB' │
│ % Of Library │   '4.1'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.96 KB   | 648.45 B   | 44.4          | 1.8
	ember-inflector/lib/system/inflections            | 1.59 KB   | 347.73 B   | 23.8          | 1.0
	ember-inflector/lib/system                        | 471.00 B  | 100.66 B   | 6.9           | 0.3
	ember-inflector/index                             | 379.00 B  | 81.00 B    | 5.6           | 0.2
	ember-inflector/lib/helpers/pluralize             | 369.00 B  | 78.86 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 332.00 B  | 70.95 B    | 4.9           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 67.96 B    | 4.7           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 63.26 B    | 4.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.77 KB'  │
│  compressed  │ '605.49 B' │
│ % Of Library │   '1.7'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.27 KB   | 497.55 B   | 82.2          | 1.4
	@ember-data/debug/setup                           | 505.00 B  | 107.93 B   | 17.8          | 0.3

Modern Builds (No Rollup)

EmberData increased by +130.0 B uncompressed but decreased by -48.0 B compressed

Warnings

⚠️ The uncompressed size of the package @ember-data/store has increased by +130.0 B.

Changeset


EmberData 202.12 KB +130.0 B (38.59 KB -48.0 B compressed)
    @ember-data/store 63.85 KB +130.0 B (12.19 KB -48.0 B compressed)
        @ember-data/store/-private/caches/identifier-cache 3.64 KB +49.0 B (712.55 B -18.09 B compressed)
        @ember-data/store/-private/utils/uuid-polyfill 786.0 B +81.0 B (150.07 B -29.91 B compressed)

Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '202.12 KB' │
│ compressed │ '38.59 KB'  │
│  packages  │      8      │
│  modules   │     124     │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '63.85 KB' │
│  compressed  │ '12.19 KB' │
│ % Of Library │   '31.6'   │
└──────────────┴────────────┘
	Module                                                                        | Bytes     | Compressed | % of Package  | % Of Library
	---------------------------------------------------------------------------------------------------------------------------------
	@ember-data/store/-private/store-service                                      | 10.69 KB  | 2.04 KB    | 16.7          | 5.3
	@ember-data/store/-private/managers/record-data-manager                       | 7.77 KB   | 1.48 KB    | 12.2          | 3.8
	@ember-data/store/-private/caches/instance-cache                              | 5.76 KB   | 1.10 KB    | 9.0           | 2.8
	@ember-data/store/-private/network/fetch-manager                              | 4.89 KB   | 955.23 B   | 7.7           | 2.4
	@ember-data/store/-private/record-arrays/identifier-array                     | 4.27 KB   | 834.56 B   | 6.7           | 2.1
	@ember-data/store/-private/caches/identifier-cache                            | 3.64 KB   | 712.55 B   | 5.7           | 1.8
	@ember-data/store/-private/network/snapshot                                   | 3.31 KB   | 647.25 B   | 5.2           | 1.6
	@ember-data/store/-private/managers/record-array-manager                      | 3.07 KB   | 600.86 B   | 4.8           | 1.5
	@ember-data/store/-private/index                                              | 2.74 KB   | 534.80 B   | 4.3           | 1.4
	@ember-data/store/-private/proxies/promise-proxies                            | 1.68 KB   | 328.02 B   | 2.6           | 0.8
	@ember-data/store/-private/managers/record-data-store-wrapper                 | 1.62 KB   | 317.32 B   | 2.5           | 0.8
	@ember-data/store/-private/network/request-cache                              | 1.61 KB   | 313.89 B   | 2.5           | 0.8
	@ember-data/store/-private/legacy-model-support/shim-model-class              | 1.55 KB   | 302.24 B   | 2.4           | 0.8
	@ember-data/store/-private/network/finders                                    | 1.51 KB   | 295.94 B   | 2.4           | 0.7
	@ember-data/store/-private/legacy-model-support/schema-definition-service     | 1.37 KB   | 268.64 B   | 2.2           | 0.7
	@ember-data/store/-private/legacy-model-support/record-reference              | 1.34 KB   | 261.76 B   | 2.1           | 0.7
	@ember-data/store/index                                                       | 1022.00 B | 195.13 B   | 1.6           | 0.5
	@ember-data/store/-private/utils/uuid-polyfill                                | 786.00 B  | 150.07 B   | 1.2           | 0.4
	@ember-data/store/-private/managers/record-notification-manager               | 753.00 B  | 143.77 B   | 1.2           | 0.4
	@ember-data/store/-private/network/snapshot-record-array                      | 691.00 B  | 131.93 B   | 1.1           | 0.3
	@ember-data/store/-private/utils/construct-resource                           | 688.00 B  | 131.36 B   | 1.1           | 0.3
	@ember-data/store/-private/utils/common                                       | 572.00 B  | 109.21 B   | 0.9           | 0.3
	@ember-data/store/-private/utils/coerce-id                                    | 473.00 B  | 90.31 B    | 0.7           | 0.2
	@ember-data/store/-private/proxies/promise-proxy-base                         | 403.00 B  | 76.94 B    | 0.6           | 0.2
	@ember-data/store/-private/caches/record-data-for                             | 325.00 B  | 62.05 B    | 0.5           | 0.2
	@ember-data/store/-private/utils/identifer-debug-consts                       | 304.00 B  | 58.04 B    | 0.5           | 0.1
	@ember-data/store/-private/utils/promise-record                               | 291.00 B  | 55.56 B    | 0.4           | 0.1
	@ember-data/store/-private/utils/serializer-response                          | 258.00 B  | 49.26 B    | 0.4           | 0.1
	@ember-data/store/-private/utils/normalize-model-name                         | 219.00 B  | 41.81 B    | 0.3           | 0.1
	@ember-data/store/-debug/index                                                | 207.00 B  | 39.52 B    | 0.3           | 0.1
	@ember-data/store/-private/utils/is-non-empty-string                          | 204.00 B  | 38.95 B    | 0.3           | 0.1

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '51.05 KB' │
│  compressed  │ '9.75 KB'  │
│ % Of Library │   '25.3'   │
└──────────────┴────────────┘
	Module                                                      | Bytes     | Compressed | % of Package  | % Of Library
	---------------------------------------------------------------------------------------------------------------
	@ember-data/model/-private/model                            | 11.25 KB  | 2.15 KB    | 22.0          | 5.6
	@ember-data/model/-private/legacy-relationships-support     | 7.90 KB   | 1.51 KB    | 15.5          | 3.9
	@ember-data/model/-private/record-state                     | 6.52 KB   | 1.25 KB    | 12.8          | 3.2
	@ember-data/model/-private/references/has-many              | 3.20 KB   | 625.87 B   | 6.3           | 1.6
	@ember-data/model/-private/references/belongs-to            | 2.81 KB   | 550.07 B   | 5.5           | 1.4
	@ember-data/model/-private/promise-many-array               | 2.70 KB   | 528.30 B   | 5.3           | 1.3
	@ember-data/model/-private/legacy-data-fetch                | 2.59 KB   | 505.58 B   | 5.1           | 1.3
	@ember-data/model/-private/many-array                       | 2.35 KB   | 459.00 B   | 4.6           | 1.2
	@ember-data/model/-private/errors                           | 2.31 KB   | 451.55 B   | 4.5           | 1.1
	@ember-data/model/-private/index                            | 1.48 KB   | 290.02 B   | 2.9           | 0.7
	@ember-data/model/-private/relationship-meta                | 991.00 B  | 189.21 B   | 1.9           | 0.5
	@ember-data/model/-private/notify-changes                   | 913.00 B  | 174.32 B   | 1.7           | 0.4
	@ember-data/model/-private/attr                             | 839.00 B  | 160.19 B   | 1.6           | 0.4
	@ember-data/model/-private/has-many                         | 817.00 B  | 155.99 B   | 1.6           | 0.4
	@ember-data/model/-private/belongs-to                       | 736.00 B  | 140.52 B   | 1.4           | 0.4
	@ember-data/model/-private/deprecated-promise-proxy         | 681.00 B  | 130.02 B   | 1.3           | 0.3
	@ember-data/model/-private/promise-belongs-to               | 615.00 B  | 117.42 B   | 1.2           | 0.3
	@ember-data/model/-private/util                             | 522.00 B  | 99.66 B    | 1.0           | 0.3
	@ember-data/model/index                                     | 486.00 B  | 92.79 B    | 0.9           | 0.2
	@ember-data/model/-private/diff-array                       | 445.00 B  | 84.96 B    | 0.9           | 0.2
	@ember-data/model/-private/model-for-mixin                  | 407.00 B  | 77.70 B    | 0.8           | 0.2
	@ember-data/model/-private/legacy-data-utils                | 395.00 B  | 75.41 B    | 0.8           | 0.2
	@ember-data/model/-private/promise-proxy-base               | 284.00 B  | 54.22 B    | 0.5           | 0.1

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '28.68 KB' │
│  compressed  │ '5.48 KB'  │
│ % Of Library │   '14.2'   │
└──────────────┴────────────┘
	Module                                                                            | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private/record-data                                      | 6.99 KB   | 1.33 KB    | 24.4          | 3.5
	@ember-data/record-data/-private/graph/index                                      | 5.88 KB   | 1.12 KB    | 20.5          | 2.9
	@ember-data/record-data/-private/graph/operations/replace-related-records         | 3.63 KB   | 710.45 B   | 12.7          | 1.8
	@ember-data/record-data/-private/graph/-edge-definition                           | 2.97 KB   | 580.24 B   | 10.3          | 1.5
	@ember-data/record-data/-private/graph/-utils                                     | 2.10 KB   | 411.45 B   | 7.3           | 1.0
	@ember-data/record-data/-private/graph/operations/update-relationship             | 1.51 KB   | 295.37 B   | 5.3           | 0.7
	@ember-data/record-data/-private/graph/operations/replace-related-record          | 1.21 KB   | 236.56 B   | 4.2           | 0.6
	@ember-data/record-data/-private/graph/operations/add-to-related-records          | 829.00 B  | 158.28 B   | 2.8           | 0.4
	@ember-data/record-data/-private/graph/operations/remove-from-related-records     | 708.00 B  | 135.17 B   | 2.4           | 0.3
	@ember-data/record-data/-private/relationships/state/belongs-to                   | 707.00 B  | 134.98 B   | 2.4           | 0.3
	@ember-data/record-data/-private/relationships/state/has-many                     | 692.00 B  | 132.12 B   | 2.4           | 0.3
	@ember-data/record-data/-private/index                                            | 497.00 B  | 94.89 B    | 1.7           | 0.2
	@ember-data/record-data/-private/coerce-id                                        | 379.00 B  | 72.36 B    | 1.3           | 0.2
	@ember-data/record-data/-private/graph/-state                                     | 293.00 B  | 55.94 B    | 1.0           | 0.1
	@ember-data/record-data/-private/normalize-link                                   | 238.00 B  | 45.44 B    | 0.8           | 0.1
	@ember-data/record-data/-private/graph/-operations                                | 150.00 B  | 28.63 B    | 0.5           | 0.1

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.43 KB' │
│  compressed  │ '4.28 KB'  │
│ % Of Library │   '11.1'   │
└──────────────┴────────────┘
	Module                                                     | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                                | 7.36 KB   | 1.40 KB    | 32.8          | 3.6
	@ember-data/serializer/-private/embedded-records-mixin     | 4.59 KB   | 898.14 B   | 20.5          | 2.3
	@ember-data/serializer/json-api                            | 3.79 KB   | 741.00 B   | 16.9          | 1.9
	@ember-data/serializer/rest                                | 2.87 KB   | 560.19 B   | 12.8          | 1.4
	@ember-data/serializer/-private/index                      | 1018.00 B | 194.36 B   | 4.4           | 0.5
	@ember-data/serializer/index                               | 611.00 B  | 116.65 B   | 2.7           | 0.3
	@ember-data/serializer/-private/transforms/date            | 530.00 B  | 101.19 B   | 2.3           | 0.3
	@ember-data/serializer/-private/transforms/boolean         | 504.00 B  | 96.22 B    | 2.2           | 0.2
	@ember-data/serializer/-private/transforms/number          | 439.00 B  | 83.81 B    | 1.9           | 0.2
	@ember-data/serializer/-private/transforms/string          | 371.00 B  | 70.83 B    | 1.6           | 0.2
	@ember-data/serializer/-private/transforms/transform       | 226.00 B  | 43.15 B    | 1.0           | 0.1
	@ember-data/serializer/transform                           | 215.00 B  | 41.05 B    | 0.9           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '18.04 KB' │
│  compressed  │ '3.44 KB'  │
│ % Of Library │   '8.9'    │
└──────────────┴────────────┘
	Module                                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                                      | 7.88 KB   | 1.50 KB    | 43.7          | 3.9
	@ember-data/adapter/-private/build-url-mixin                  | 1.92 KB   | 374.99 B   | 10.6          | 0.9
	@ember-data/adapter/error                                     | 1.82 KB   | 356.27 B   | 10.1          | 0.9
	@ember-data/adapter/index                                     | 1.41 KB   | 276.08 B   | 7.8           | 0.7
	@ember-data/adapter/json-api                                  | 1.03 KB   | 202.19 B   | 5.7           | 0.5
	@ember-data/adapter/-private/index                            | 1.03 KB   | 201.62 B   | 5.7           | 0.5
	@ember-data/adapter/-private/utils/serialize-query-params     | 769.00 B  | 146.82 B   | 4.2           | 0.4
	@ember-data/adapter/-private/utils/determine-body-promise     | 556.00 B  | 106.15 B   | 3.0           | 0.3
	@ember-data/adapter/-private/utils/parse-response-headers     | 488.00 B  | 93.17 B    | 2.6           | 0.2
	@ember-data/adapter/-private/utils/fetch                      | 450.00 B  | 85.91 B    | 2.4           | 0.2
	@ember-data/adapter/-private/utils/serialize-into-hash        | 382.00 B  | 72.93 B    | 2.1           | 0.2
	@ember-data/adapter/-private/utils/continue-on-reject         | 222.00 B  | 42.38 B    | 1.2           | 0.1
	@ember-data/adapter/-private/fastboot-interface               | 147.00 B  | 28.06 B    | 0.8           | 0.1

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '8.64 KB' │
│  compressed  │ '1.65 KB' │
│ % Of Library │   '4.3'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 1.98 KB   | 387.97 B   | 23.0          | 1.0
	ember-data/-private/index                         | 1.49 KB   | 291.55 B   | 17.3          | 0.7
	ember-data/adapters/errors                        | 1.19 KB   | 232.36 B   | 13.8          | 0.6
	ember-data/-private/core                          | 368.00 B  | 70.26 B    | 4.2           | 0.2
	ember-data/setup-container                        | 368.00 B  | 70.26 B    | 4.2           | 0.2
	ember-data/relationships                          | 318.00 B  | 60.71 B    | 3.6           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 52.31 B    | 3.1           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 47.92 B    | 2.8           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 46.77 B    | 2.8           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 46.39 B    | 2.7           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 46.39 B    | 2.7           | 0.1
	ember-data/transform                              | 241.00 B  | 46.01 B    | 2.7           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 45.25 B    | 2.7           | 0.1
	ember-data/serializer                             | 232.00 B  | 44.29 B    | 2.6           | 0.1
	ember-data/adapter                                | 226.00 B  | 43.15 B    | 2.6           | 0.1
	ember-data/model                                  | 222.00 B  | 42.38 B    | 2.5           | 0.1
	ember-data/store                                  | 222.00 B  | 42.38 B    | 2.5           | 0.1
	ember-data/attr                                   | 218.00 B  | 41.62 B    | 2.5           | 0.1
	ember-data/version                                | 161.00 B  | 30.73 B    | 1.8           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.67 KB' │
│  compressed  │ '1.27 KB' │
│ % Of Library │   '3.3'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.96 KB   | 579.28 B   | 44.4          | 1.5
	ember-inflector/lib/system/inflections            | 1.59 KB   | 310.64 B   | 23.8          | 0.8
	ember-inflector/lib/system                        | 471.00 B  | 89.92 B    | 6.9           | 0.2
	ember-inflector/index                             | 379.00 B  | 72.36 B    | 5.6           | 0.2
	ember-inflector/lib/helpers/pluralize             | 369.00 B  | 70.45 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 332.00 B  | 63.38 B    | 4.9           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 60.71 B    | 4.7           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 56.51 B    | 4.3           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.77 KB'  │
│  compressed  │ '540.91 B' │
│ % Of Library │   '1.4'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.27 KB   | 444.48 B   | 82.2          | 1.1
	@ember-data/debug/setup                           | 505.00 B  | 96.42 B    | 17.8          | 0.2

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

Performance Report for c44b280

Scenario - basic-record-materialization: ☑️ Performance is stable

☑️ duration
phase no difference [-38ms to 44ms]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [-4ms to 3ms]
☑️ Phase [start-data-generation] => [start-push-payload]
phase no difference [-2ms to 3ms]
☑️ Phase [start-push-payload] => [start-peek-records]
phase no difference [-14ms to 10ms]
☑️ Phase [start-peek-records] => [start-record-materialization]
phase no difference [0ms to 0ms]
☑️ Phase [start-record-materialization] => [end-record-materialization]
phase no difference [-15ms to 18ms]
☑️ Phase [end-record-materialization] => [Test End]
phase no difference [-1ms to 3ms]

Scenario - relationship-materialization-simple: ☑️ Performance is stable

☑️ duration
phase no difference [-8ms to 10ms]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-6ms to 2ms]
☑️ Phase [start-find-all] => [start-materialization]
phase no difference [-1ms to 8ms]
☑️ Phase [start-materialization] => [end-materialization]
phase no difference [-4ms to 2ms]
☑️ Phase [end-materialization] => [Test End]
phase no difference [0ms to 2ms]

Scenario - relationship-materialization-complex: ☑️ Performance is stable

☑️ duration
phase no difference [-51ms to 50ms]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [-3ms to 4ms]
☑️ Phase [start-data-generation] => [start-push-payload]
phase no difference [-2ms to 0ms]
☑️ Phase [start-push-payload] => [start-peek-records]
phase no difference [-7ms to 10ms]
☑️ Phase [start-peek-records] => [start-record-materialization]
phase no difference [0ms to 0ms]
☑️ Phase [start-record-materialization] => [start-relationship-materialization]
phase no difference [-9ms to 3ms]
☑️ Phase [start-relationship-materialization] => [end-relationship-materialization]
phase no difference [-40ms to 32ms]
☑️ Phase [end-relationship-materialization] => [Test End]
phase no difference [-9ms to 5ms]

Scenario - unload: ☑️ Performance is stable

☑️ duration
phase no difference [-21ms to 2ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-10ms to 1ms]
☑️ Phase [start-push-payload] => [start-unload-records]
phase no difference [-8ms to 1ms]
☑️ Phase [start-unload-records] => [end-unload-records]
phase no difference [-1ms to 2ms]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [0ms to 0ms]

Scenario - unload-all: ☑️ Performance is stable

☑️ duration
phase no difference [-8ms to 19ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-1ms to 6ms]
☑️ Phase [start-push-payload] => [start-materialization]
phase no difference [-9ms to 4ms]
☑️ Phase [start-materialization] => [start-unload-all]
phase no difference [0ms to 7ms]
☑️ Phase [start-unload-all] => [end-unload-all]
phase no difference [-1ms to 5ms]
☑️ Phase [end-unload-all] => [Test End]
phase no difference [0ms to 0ms]

Scenario - destroy: ☑️ Performance is stable

☑️ duration
phase no difference [-10ms to 9ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-4ms to 4ms]
☑️ Phase [start-push-payload] => [start-destroy-records]
phase no difference [-5ms to 3ms]
☑️ Phase [start-destroy-records] => [end-destroy-records]
phase no difference [-1ms to 3ms]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [0ms to 0ms]

Scenario - add-children: ✅ Performance improved

✅ duration
phase estimated improvement -8ms [-17ms to 0ms] OR -1.05% [-2.16% to -0.05%]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-10ms to 1ms]
☑️ Phase [start-push-initial-payload] => [start-push-update-payload]
phase no difference [-4ms to 1ms]
☑️ Phase [start-push-update-payload] => [end-push-update-payload]
phase no difference [-3ms to 2ms]
☑️ Phase [end-push-update-payload] => [Test End]
phase no difference [0ms to 0ms]

Scenario - unused-relationships: ☑️ Performance is stable

☑️ duration
phase no difference [-7ms to 10ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-4ms to 4ms]
☑️ Phase [start-push-payload] => [end-push-payload]
phase no difference [-4ms to 4ms]
☑️ Phase [end-push-payload] => [Test End]
phase no difference [0ms to 0ms]

@runspired runspired merged commit 7a1b6d1 into master Sep 2, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/polyfill branch September 2, 2022 00:00
@github-actions
Copy link

github-actions bot commented Sep 2, 2022

Commit v Release Performance Report for c44b280

Scenario - basic-record-materialization: ✅ Performance improved

✅ duration
phase estimated improvement -1643ms [-1708ms to -1590ms] OR -35.22% [-36.62% to -34.08%]
✅ Phase [navigationStart] => [start-data-generation]
phase estimated improvement -3ms [-5ms to -1ms] OR -1.24% [-2.09% to -0.4%]
☑️ Phase [start-data-generation] => [start-push-payload]
phase no difference [-4ms to 0ms]
✅ Phase [start-push-payload] => [start-peek-records]
phase estimated improvement -755ms [-765ms to -744ms] OR -33.12% [-33.58% to -32.67%]
✅ Phase [start-peek-records] => [start-record-materialization]
phase estimated improvement -120ms [-121ms to -118ms] OR -96.75% [-97.68% to -95.35%]
✅ Phase [start-record-materialization] => [end-record-materialization]
phase estimated improvement -516ms [-536ms to -492ms] OR -47.32% [-49.18% to -45.16%]
✅ Phase [end-record-materialization] => [Test End]
phase estimated improvement -175ms [-189ms to -171ms] OR -78.99% [-85.43% to -77.23%]

Scenario - relationship-materialization-simple: ✅ Performance improved

✅ duration
phase estimated improvement -437ms [-447ms to -427ms] OR -37.65% [-38.51% to -36.78%]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-4ms to 2ms]
✅ Phase [start-find-all] => [start-materialization]
phase estimated improvement -84ms [-88ms to -80ms] OR -18.99% [-19.93% to -18.06%]
✅ Phase [start-materialization] => [end-materialization]
phase estimated improvement -272ms [-275ms to -269ms] OR -78.61% [-79.5% to -77.74%]
✅ Phase [end-materialization] => [Test End]
phase estimated improvement -81ms [-83ms to -79ms] OR -70.62% [-72.24% to -68.78%]

Scenario - relationship-materialization-complex: ✅ Performance improved

✅ duration
phase estimated improvement -1138ms [-1164ms to -1108ms] OR -20.32% [-20.79% to -19.8%]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [-5ms to 1ms]
☑️ Phase [start-data-generation] => [start-push-payload]
phase no difference [-1ms to 0ms]
✅ Phase [start-push-payload] => [start-peek-records]
phase estimated improvement -326ms [-332ms to -321ms] OR -29.79% [-30.28% to -29.26%]
✅ Phase [start-peek-records] => [start-record-materialization]
phase estimated improvement -59ms [-60ms to -57ms] OR -96.27% [-97.6% to -93.38%]
✅ Phase [start-record-materialization] => [start-relationship-materialization]
phase estimated improvement -228ms [-232ms to -224ms] OR -48.26% [-49.11% to -47.42%]
✅ Phase [start-relationship-materialization] => [end-relationship-materialization]
phase estimated improvement -342ms [-367ms to -317ms] OR -11.52% [-12.37% to -10.68%]
✅ Phase [end-relationship-materialization] => [Test End]
phase estimated improvement -170ms [-176ms to -164ms] OR -31.09% [-32.19% to -30.01%]

Scenario - unload: ✅ Performance improved

✅ duration
phase estimated improvement -301ms [-310ms to -293ms] OR -21.69% [-22.36% to -21.11%]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-7ms to 1ms]
✅ Phase [start-push-payload] => [start-unload-records]
phase estimated improvement -179ms [-183ms to -175ms] OR -26.44% [-27.05% to -25.86%]
✅ Phase [start-unload-records] => [end-unload-records]
phase estimated improvement -118ms [-121ms to -116ms] OR -39.51% [-40.31% to -38.85%]
✅ Phase [end-unload-records] => [Test End]
phase estimated improvement -1ms [-1ms to 0ms] OR -1.75% [-2.06% to -1.46%]

Scenario - unload-all: ✅ Performance improved

✅ duration
phase estimated improvement -16204ms [-16306ms to -16130ms] OR -88% [-88.55% to -87.59%]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-9ms to 1ms]
✅ Phase [start-push-payload] => [start-materialization]
phase estimated improvement -498ms [-505ms to -491ms] OR -33.84% [-34.33% to -33.34%]
✅ Phase [start-materialization] => [start-unload-all]
phase estimated improvement -402ms [-407ms to -398ms] OR -55.27% [-55.97% to -54.64%]
✅ Phase [start-unload-all] => [end-unload-all]
phase estimated improvement -15315ms [-15376ms to -15252ms] OR -97.79% [-98.18% to -97.39%]
✅ Phase [end-unload-all] => [Test End]
phase estimated improvement -1ms [-1ms to -1ms] OR -2.38% [-2.79% to -2.03%]

Scenario - destroy: ✅ Performance improved

✅ duration
phase estimated improvement -452ms [-464ms to -440ms] OR -29.62% [-30.42% to -28.85%]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-7ms to 1ms]
✅ Phase [start-push-payload] => [start-destroy-records]
phase estimated improvement -167ms [-172ms to -163ms] OR -25.05% [-25.75% to -24.38%]
✅ Phase [start-destroy-records] => [end-destroy-records]
phase estimated improvement -281ms [-284ms to -279ms] OR -62.9% [-63.54% to -62.3%]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [0ms to 0ms]

Scenario - add-children: ✅ Performance improved

✅ duration
phase estimated improvement -223ms [-231ms to -215ms] OR -23.05% [-23.9% to -22.21%]
✅ Phase [navigationStart] => [start-push-initial-payload]
phase estimated improvement -6ms [-11ms to -1ms] OR -1.54% [-2.73% to -0.27%]
✅ Phase [start-push-initial-payload] => [start-push-update-payload]
phase estimated improvement -85ms [-88ms to -83ms] OR -33% [-33.85% to -32.23%]
✅ Phase [start-push-update-payload] => [end-push-update-payload]
phase estimated improvement -91ms [-94ms to -89ms] OR -42.3% [-43.42% to -41.2%]
✅ Phase [end-push-update-payload] => [Test End]
phase estimated improvement -41ms [-41ms to -40ms] OR -56.64% [-57.43% to -56%]

Scenario - unused-relationships: ✅ Performance improved

✅ duration
phase estimated improvement -229ms [-239ms to -220ms] OR -20.07% [-20.91% to -19.28%]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-8ms to 1ms]
✅ Phase [start-push-payload] => [end-push-payload]
phase estimated improvement -193ms [-199ms to -187ms] OR -27.67% [-28.46% to -26.85%]
✅ Phase [end-push-payload] => [Test End]
phase estimated improvement -31ms [-32ms to -30ms] OR -48.86% [-50.49% to -47.58%]

runspired added a commit that referenced this pull request Sep 7, 2022
backport #8159 to release-4-6

* fix polyfill logic

* fix lint

Co-authored-by: Chris Thoburn <[email protected]>
@jrjohnson jrjohnson removed the 🎯 release PR should be backported to release label Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 canary PR is targeting canary (default) 🎯 lts The PR should be backported to the most recent LTS 🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants