-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: uuid polyfill logic #8159
fix: uuid polyfill logic #8159
Conversation
Asset Size Report for c44b280 Modern Builds ☑️ EmberData has not changed in sizeIf any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis (Modern)
Modern Builds (No Rollup) EmberData increased by +130.0 B uncompressed but decreased by -48.0 B compressedWarningsChangeset
Full Asset Analysis (Modern)
|
Performance Report for c44b280 Scenario - basic-record-materialization: ☑️ Performance is stable
Scenario - relationship-materialization-simple: ☑️ Performance is stable
Scenario - relationship-materialization-complex: ☑️ Performance is stable
Scenario - unload: ☑️ Performance is stable
Scenario - unload-all: ☑️ Performance is stable
Scenario - destroy: ☑️ Performance is stable
Scenario - add-children: ✅ Performance improved
Scenario - unused-relationships: ☑️ Performance is stable
|
Commit v Release Performance Report for c44b280 Scenario - basic-record-materialization: ✅ Performance improved
Scenario - relationship-materialization-simple: ✅ Performance improved
Scenario - relationship-materialization-complex: ✅ Performance improved
Scenario - unload: ✅ Performance improved
Scenario - unload-all: ✅ Performance improved
Scenario - destroy: ✅ Performance improved
Scenario - add-children: ✅ Performance improved
Scenario - unused-relationships: ✅ Performance improved
|
backport #8159 to release-4-6 * fix polyfill logic * fix lint Co-authored-by: Chris Thoburn <[email protected]>
rollup doesn't understand
importSync
, so we can't use it within a module.cc @kiwi-josh
@jrjohnson this will need back ported.