feat: deprecate v1 cache #8129

runspired · 2022-08-17T02:48:19Z

In order to activate singleton manager we have to deprecate v1.

Consumers can opt-in to a singleton manager by marking all V1 deprecations as resolved. This means specifying compatWith of at least 4.8, which also means having fixed all other deprecations introduced prior to and during 4.8.

enable opt-in usage of singleton manager
deprecate V1 APIs
do another pass on V2 APIs

Documentation will be its own PR once we finish the new RFC(s) for v2 cache.

[-] document V2 APIs
[-] Submit RFC for revised V2 spec (actual implementation has diverged somewhat from original RFC due to improved understanding of requirements)

github-actions · 2022-08-17T02:52:18Z

Asset Size Report for 9b6c9b5

Modern Builds

✅ EmberData shrank by -5.11 KB (-828.0 B compressed)

If any packages had changed sizes they would be listed here.

Changeset


EmberData 163.11 KB -5.11 KB (34.82 KB -828.0 B compressed)
    @ember-data/store 42.3 KB -4.69 KB (9.03 KB -760.4 B compressed)
        @ember-data/store/-private 41.31 KB -4.69 KB (8.82 KB -760.4 B compressed)
    @ember-data/model 44.71 KB -79.0 B (9.54 KB -12.51 B compressed)
        @ember-data/model/-private 44.23 KB -79.0 B (9.44 KB -12.51 B compressed)
    @ember-data/record-data 21.99 KB -348.0 B (4.69 KB -55.09 B compressed)
        @ember-data/record-data/-private 21.99 KB -348.0 B (4.69 KB -55.09 B compressed)

Full Asset Analysis (Modern)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '163.11 KB' │
│ compressed │ '34.82 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '44.71 KB' │
│  compressed  │ '9.54 KB'  │
│ % Of Library │   '27.4'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 44.23 KB  | 9.44 KB    | 98.9          | 27.1
	@ember-data/model/index                           | 486.00 B  | 103.74 B   | 1.1           | 0.3

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '42.30 KB' │
│  compressed  │ '9.03 KB'  │
│ % Of Library │   '25.9'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 41.31 KB  | 8.82 KB    | 97.6          | 25.3
	@ember-data/store/index                           | 1022.00 B | 218.16 B   | 2.4           | 0.6

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '21.99 KB' │
│  compressed  │ '4.69 KB'  │
│ % Of Library │   '13.5'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 21.99 KB  | 4.69 KB    | 100.0         | 13.5

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '20.42 KB' │
│  compressed  │ '4.36 KB'  │
│ % Of Library │   '12.5'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.36 KB   | 1.57 KB    | 36.0          | 4.5
	@ember-data/serializer/-private                   | 5.60 KB   | 1.19 KB    | 27.4          | 3.4
	@ember-data/serializer/json-api                   | 3.79 KB   | 828.45 B   | 18.6          | 2.3
	@ember-data/serializer/rest                       | 2.87 KB   | 626.30 B   | 14.0          | 1.8
	@ember-data/serializer/index                      | 611.00 B  | 130.42 B   | 2.9           | 0.4
	@ember-data/serializer/transform                  | 215.00 B  | 45.89 B    | 1.0           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.93 KB' │
│  compressed  │ '3.40 KB'  │
│ % Of Library │   '9.8'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 7.88 KB   | 1.68 KB    | 49.5          | 4.8
	@ember-data/adapter/-private                      | 3.79 KB   | 827.38 B   | 23.8          | 2.3
	@ember-data/adapter/error                         | 1.82 KB   | 398.32 B   | 11.4          | 1.1
	@ember-data/adapter/index                         | 1.41 KB   | 308.66 B   | 8.9           | 0.9
	@ember-data/adapter/json-api                      | 1.03 KB   | 226.05 B   | 6.5           | 0.6

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '8.32 KB' │
│  compressed  │ '1.78 KB' │
│ % Of Library │   '5.1'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 1.98 KB   | 433.75 B   | 23.8          | 1.2
	ember-data/-private                               | 1.53 KB   | 335.35 B   | 18.4          | 0.9
	ember-data/adapters/errors                        | 1.19 KB   | 259.78 B   | 14.3          | 0.7
	ember-data/setup-container                        | 368.00 B  | 78.55 B    | 4.3           | 0.2
	ember-data/relationships                          | 318.00 B  | 67.88 B    | 3.7           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 58.48 B    | 3.2           | 0.2
	ember-data/serializers/json-api                   | 251.00 B  | 53.57 B    | 2.9           | 0.2
	ember-data/adapters/json-api                      | 245.00 B  | 52.29 B    | 2.9           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 51.87 B    | 2.9           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 51.87 B    | 2.9           | 0.1
	ember-data/transform                              | 241.00 B  | 51.44 B    | 2.8           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 50.59 B    | 2.8           | 0.1
	ember-data/serializer                             | 232.00 B  | 49.52 B    | 2.7           | 0.1
	ember-data/adapter                                | 226.00 B  | 48.24 B    | 2.7           | 0.1
	ember-data/model                                  | 222.00 B  | 47.38 B    | 2.6           | 0.1
	ember-data/store                                  | 222.00 B  | 47.38 B    | 2.6           | 0.1
	ember-data/attr                                   | 218.00 B  | 46.53 B    | 2.6           | 0.1
	ember-data/version                                | 161.00 B  | 34.36 B    | 1.9           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.67 KB' │
│  compressed  │ '1.42 KB' │
│ % Of Library │   '4.1'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.96 KB   | 647.65 B   | 44.4          | 1.8
	ember-inflector/lib/system/inflections            | 1.59 KB   | 347.30 B   | 23.8          | 1.0
	ember-inflector/lib/system                        | 471.00 B  | 100.54 B   | 6.9           | 0.3
	ember-inflector/index                             | 379.00 B  | 80.90 B    | 5.6           | 0.2
	ember-inflector/lib/helpers/pluralize             | 369.00 B  | 78.76 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 332.00 B  | 70.87 B    | 4.9           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 67.88 B    | 4.7           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 63.18 B    | 4.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.77 KB'  │
│  compressed  │ '604.74 B' │
│ % Of Library │   '1.7'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.27 KB   | 496.94 B   | 82.2          | 1.4
	@ember-data/debug/setup                           | 505.00 B  | 107.79 B   | 17.8          | 0.3

Modern Builds (No Rollup)

✅ EmberData shrank by -679.0 B (-90.0 B compressed)

If any packages had changed sizes they would be listed here.

Changeset


EmberData 202.0 KB -679.0 B (38.64 KB -90.0 B compressed)
    @ember-data/store 63.72 KB -203.0 B (12.19 KB -26.91 B compressed)
        @ember-data/store/-private/managers/record-data-manager 7.77 KB -91.0 B (1.49 KB -12.06 B compressed)
        @ember-data/store/-private/caches/instance-cache 5.76 KB -61.0 B (1.1 KB -8.09 B compressed)
        @ember-data/store/-private/record-arrays/identifier-array 4.27 KB -51.0 B (836.08 B -6.76 B compressed)
    @ember-data/model 51.05 KB -76.0 B (9.76 KB -10.07 B compressed)
        @ember-data/model/-private/legacy-relationships-support 7.9 KB -76.0 B (1.51 KB -10.07 B compressed)
    @ember-data/record-data 28.68 KB -400.0 B (5.49 KB -53.02 B compressed)
        @ember-data/record-data/-private/record-data 6.99 KB -400.0 B (1.34 KB -53.02 B compressed)

Full Asset Analysis (Modern)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '202.00 KB' │
│ compressed │ '38.64 KB'  │
│  packages  │      8      │
│  modules   │     124     │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '63.72 KB' │
│  compressed  │ '12.19 KB' │
│ % Of Library │   '31.5'   │
└──────────────┴────────────┘
	Module                                                                        | Bytes     | Compressed | % of Package  | % Of Library
	---------------------------------------------------------------------------------------------------------------------------------
	@ember-data/store/-private/store-service                                      | 10.69 KB  | 2.05 KB    | 16.8          | 5.3
	@ember-data/store/-private/managers/record-data-manager                       | 7.77 KB   | 1.49 KB    | 12.2          | 3.8
	@ember-data/store/-private/caches/instance-cache                              | 5.76 KB   | 1.10 KB    | 9.0           | 2.9
	@ember-data/store/-private/network/fetch-manager                              | 4.89 KB   | 956.97 B   | 7.7           | 2.4
	@ember-data/store/-private/record-arrays/identifier-array                     | 4.27 KB   | 836.08 B   | 6.7           | 2.1
	@ember-data/store/-private/caches/identifier-cache                            | 3.60 KB   | 704.48 B   | 5.6           | 1.8
	@ember-data/store/-private/network/snapshot                                   | 3.31 KB   | 648.43 B   | 5.2           | 1.6
	@ember-data/store/-private/managers/record-array-manager                      | 3.07 KB   | 601.95 B   | 4.8           | 1.5
	@ember-data/store/-private/index                                              | 2.74 KB   | 535.77 B   | 4.3           | 1.4
	@ember-data/store/-private/proxies/promise-proxies                            | 1.68 KB   | 328.61 B   | 2.6           | 0.8
	@ember-data/store/-private/managers/record-data-store-wrapper                 | 1.62 KB   | 317.90 B   | 2.5           | 0.8
	@ember-data/store/-private/network/request-cache                              | 1.61 KB   | 314.46 B   | 2.5           | 0.8
	@ember-data/store/-private/legacy-model-support/shim-model-class              | 1.55 KB   | 302.79 B   | 2.4           | 0.8
	@ember-data/store/-private/network/finders                                    | 1.51 KB   | 296.48 B   | 2.4           | 0.7
	@ember-data/store/-private/legacy-model-support/schema-definition-service     | 1.37 KB   | 269.13 B   | 2.2           | 0.7
	@ember-data/store/-private/legacy-model-support/record-reference              | 1.34 KB   | 262.24 B   | 2.1           | 0.7
	@ember-data/store/index                                                       | 1022.00 B | 195.48 B   | 1.6           | 0.5
	@ember-data/store/-private/managers/record-notification-manager               | 753.00 B  | 144.03 B   | 1.2           | 0.4
	@ember-data/store/-private/utils/uuid-polyfill                                | 705.00 B  | 134.85 B   | 1.1           | 0.3
	@ember-data/store/-private/network/snapshot-record-array                      | 691.00 B  | 132.17 B   | 1.1           | 0.3
	@ember-data/store/-private/utils/construct-resource                           | 688.00 B  | 131.60 B   | 1.1           | 0.3
	@ember-data/store/-private/utils/common                                       | 572.00 B  | 109.41 B   | 0.9           | 0.3
	@ember-data/store/-private/utils/coerce-id                                    | 473.00 B  | 90.47 B    | 0.7           | 0.2
	@ember-data/store/-private/proxies/promise-proxy-base                         | 403.00 B  | 77.08 B    | 0.6           | 0.2
	@ember-data/store/-private/caches/record-data-for                             | 325.00 B  | 62.16 B    | 0.5           | 0.2
	@ember-data/store/-private/utils/identifer-debug-consts                       | 304.00 B  | 58.14 B    | 0.5           | 0.1
	@ember-data/store/-private/utils/promise-record                               | 291.00 B  | 55.66 B    | 0.4           | 0.1
	@ember-data/store/-private/utils/serializer-response                          | 258.00 B  | 49.35 B    | 0.4           | 0.1
	@ember-data/store/-private/utils/normalize-model-name                         | 219.00 B  | 41.89 B    | 0.3           | 0.1
	@ember-data/store/-debug/index                                                | 207.00 B  | 39.59 B    | 0.3           | 0.1
	@ember-data/store/-private/utils/is-non-empty-string                          | 204.00 B  | 39.02 B    | 0.3           | 0.1

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '51.05 KB' │
│  compressed  │ '9.76 KB'  │
│ % Of Library │   '25.3'   │
└──────────────┴────────────┘
	Module                                                      | Bytes     | Compressed | % of Package  | % Of Library
	---------------------------------------------------------------------------------------------------------------
	@ember-data/model/-private/model                            | 11.25 KB  | 2.15 KB    | 22.0          | 5.6
	@ember-data/model/-private/legacy-relationships-support     | 7.90 KB   | 1.51 KB    | 15.5          | 3.9
	@ember-data/model/-private/record-state                     | 6.52 KB   | 1.25 KB    | 12.8          | 3.2
	@ember-data/model/-private/references/has-many              | 3.20 KB   | 627.01 B   | 6.3           | 1.6
	@ember-data/model/-private/references/belongs-to            | 2.81 KB   | 551.07 B   | 5.5           | 1.4
	@ember-data/model/-private/promise-many-array               | 2.70 KB   | 529.26 B   | 5.3           | 1.3
	@ember-data/model/-private/legacy-data-fetch                | 2.59 KB   | 506.50 B   | 5.1           | 1.3
	@ember-data/model/-private/many-array                       | 2.35 KB   | 459.83 B   | 4.6           | 1.2
	@ember-data/model/-private/errors                           | 2.31 KB   | 452.37 B   | 4.5           | 1.1
	@ember-data/model/-private/index                            | 1.48 KB   | 290.55 B   | 2.9           | 0.7
	@ember-data/model/-private/relationship-meta                | 991.00 B  | 189.55 B   | 1.9           | 0.5
	@ember-data/model/-private/notify-changes                   | 913.00 B  | 174.63 B   | 1.7           | 0.4
	@ember-data/model/-private/attr                             | 839.00 B  | 160.48 B   | 1.6           | 0.4
	@ember-data/model/-private/has-many                         | 817.00 B  | 156.27 B   | 1.6           | 0.4
	@ember-data/model/-private/belongs-to                       | 736.00 B  | 140.78 B   | 1.4           | 0.4
	@ember-data/model/-private/deprecated-promise-proxy         | 681.00 B  | 130.26 B   | 1.3           | 0.3
	@ember-data/model/-private/promise-belongs-to               | 615.00 B  | 117.63 B   | 1.2           | 0.3
	@ember-data/model/-private/util                             | 522.00 B  | 99.84 B    | 1.0           | 0.3
	@ember-data/model/index                                     | 486.00 B  | 92.96 B    | 0.9           | 0.2
	@ember-data/model/-private/diff-array                       | 445.00 B  | 85.11 B    | 0.9           | 0.2
	@ember-data/model/-private/model-for-mixin                  | 407.00 B  | 77.85 B    | 0.8           | 0.2
	@ember-data/model/-private/legacy-data-utils                | 395.00 B  | 75.55 B    | 0.8           | 0.2
	@ember-data/model/-private/promise-proxy-base               | 284.00 B  | 54.32 B    | 0.5           | 0.1

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '28.68 KB' │
│  compressed  │ '5.49 KB'  │
│ % Of Library │   '14.2'   │
└──────────────┴────────────┘
	Module                                                                            | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private/record-data                                      | 6.99 KB   | 1.34 KB    | 24.4          | 3.5
	@ember-data/record-data/-private/graph/index                                      | 5.88 KB   | 1.12 KB    | 20.5          | 2.9
	@ember-data/record-data/-private/graph/operations/replace-related-records         | 3.63 KB   | 711.75 B   | 12.7          | 1.8
	@ember-data/record-data/-private/graph/-edge-definition                           | 2.97 KB   | 581.29 B   | 10.3          | 1.5
	@ember-data/record-data/-private/graph/-utils                                     | 2.10 KB   | 412.20 B   | 7.3           | 1.0
	@ember-data/record-data/-private/graph/operations/update-relationship             | 1.51 KB   | 295.90 B   | 5.3           | 0.7
	@ember-data/record-data/-private/graph/operations/replace-related-record          | 1.21 KB   | 236.99 B   | 4.2           | 0.6
	@ember-data/record-data/-private/graph/operations/add-to-related-records          | 829.00 B  | 158.57 B   | 2.8           | 0.4
	@ember-data/record-data/-private/graph/operations/remove-from-related-records     | 708.00 B  | 135.42 B   | 2.4           | 0.3
	@ember-data/record-data/-private/relationships/state/belongs-to                   | 707.00 B  | 135.23 B   | 2.4           | 0.3
	@ember-data/record-data/-private/relationships/state/has-many                     | 692.00 B  | 132.36 B   | 2.4           | 0.3
	@ember-data/record-data/-private/index                                            | 497.00 B  | 95.06 B    | 1.7           | 0.2
	@ember-data/record-data/-private/coerce-id                                        | 379.00 B  | 72.49 B    | 1.3           | 0.2
	@ember-data/record-data/-private/graph/-state                                     | 293.00 B  | 56.04 B    | 1.0           | 0.1
	@ember-data/record-data/-private/normalize-link                                   | 238.00 B  | 45.52 B    | 0.8           | 0.1
	@ember-data/record-data/-private/graph/-operations                                | 150.00 B  | 28.69 B    | 0.5           | 0.1

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.43 KB' │
│  compressed  │ '4.29 KB'  │
│ % Of Library │   '11.1'   │
└──────────────┴────────────┘
	Module                                                     | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                                | 7.36 KB   | 1.41 KB    | 32.8          | 3.6
	@ember-data/serializer/-private/embedded-records-mixin     | 4.59 KB   | 899.77 B   | 20.5          | 2.3
	@ember-data/serializer/json-api                            | 3.79 KB   | 742.35 B   | 16.9          | 1.9
	@ember-data/serializer/rest                                | 2.87 KB   | 561.21 B   | 12.8          | 1.4
	@ember-data/serializer/-private/index                      | 1018.00 B | 194.72 B   | 4.4           | 0.5
	@ember-data/serializer/index                               | 611.00 B  | 116.87 B   | 2.7           | 0.3
	@ember-data/serializer/-private/transforms/date            | 530.00 B  | 101.37 B   | 2.3           | 0.3
	@ember-data/serializer/-private/transforms/boolean         | 504.00 B  | 96.40 B    | 2.2           | 0.2
	@ember-data/serializer/-private/transforms/number          | 439.00 B  | 83.97 B    | 1.9           | 0.2
	@ember-data/serializer/-private/transforms/string          | 371.00 B  | 70.96 B    | 1.6           | 0.2
	@ember-data/serializer/-private/transforms/transform       | 226.00 B  | 43.22 B    | 1.0           | 0.1
	@ember-data/serializer/transform                           | 215.00 B  | 41.12 B    | 0.9           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '18.04 KB' │
│  compressed  │ '3.45 KB'  │
│ % Of Library │   '8.9'    │
└──────────────┴────────────┘
	Module                                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                                      | 7.88 KB   | 1.51 KB    | 43.7          | 3.9
	@ember-data/adapter/-private/build-url-mixin                  | 1.92 KB   | 375.67 B   | 10.6          | 0.9
	@ember-data/adapter/error                                     | 1.82 KB   | 356.92 B   | 10.1          | 0.9
	@ember-data/adapter/index                                     | 1.41 KB   | 276.58 B   | 7.8           | 0.7
	@ember-data/adapter/json-api                                  | 1.03 KB   | 202.56 B   | 5.7           | 0.5
	@ember-data/adapter/-private/index                            | 1.03 KB   | 201.99 B   | 5.7           | 0.5
	@ember-data/adapter/-private/utils/serialize-query-params     | 769.00 B  | 147.09 B   | 4.2           | 0.4
	@ember-data/adapter/-private/utils/determine-body-promise     | 556.00 B  | 106.35 B   | 3.0           | 0.3
	@ember-data/adapter/-private/utils/parse-response-headers     | 488.00 B  | 93.34 B    | 2.6           | 0.2
	@ember-data/adapter/-private/utils/fetch                      | 450.00 B  | 86.07 B    | 2.4           | 0.2
	@ember-data/adapter/-private/utils/serialize-into-hash        | 382.00 B  | 73.06 B    | 2.1           | 0.2
	@ember-data/adapter/-private/utils/continue-on-reject         | 222.00 B  | 42.46 B    | 1.2           | 0.1
	@ember-data/adapter/-private/fastboot-interface               | 147.00 B  | 28.11 B    | 0.8           | 0.1

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '8.64 KB' │
│  compressed  │ '1.65 KB' │
│ % Of Library │   '4.3'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 1.98 KB   | 388.67 B   | 23.0          | 1.0
	ember-data/-private/index                         | 1.49 KB   | 292.08 B   | 17.3          | 0.7
	ember-data/adapters/errors                        | 1.19 KB   | 232.78 B   | 13.8          | 0.6
	ember-data/-private/core                          | 368.00 B  | 70.39 B    | 4.2           | 0.2
	ember-data/setup-container                        | 368.00 B  | 70.39 B    | 4.2           | 0.2
	ember-data/relationships                          | 318.00 B  | 60.82 B    | 3.6           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 52.41 B    | 3.1           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 48.01 B    | 2.8           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 46.86 B    | 2.8           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 46.48 B    | 2.7           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 46.48 B    | 2.7           | 0.1
	ember-data/transform                              | 241.00 B  | 46.09 B    | 2.7           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 45.33 B    | 2.7           | 0.1
	ember-data/serializer                             | 232.00 B  | 44.37 B    | 2.6           | 0.1
	ember-data/adapter                                | 226.00 B  | 43.22 B    | 2.6           | 0.1
	ember-data/model                                  | 222.00 B  | 42.46 B    | 2.5           | 0.1
	ember-data/store                                  | 222.00 B  | 42.46 B    | 2.5           | 0.1
	ember-data/attr                                   | 218.00 B  | 41.69 B    | 2.5           | 0.1
	ember-data/version                                | 161.00 B  | 30.79 B    | 1.8           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.67 KB' │
│  compressed  │ '1.28 KB' │
│ % Of Library │   '3.3'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.96 KB   | 580.34 B   | 44.4          | 1.5
	ember-inflector/lib/system/inflections            | 1.59 KB   | 311.21 B   | 23.8          | 0.8
	ember-inflector/lib/system                        | 471.00 B  | 90.09 B    | 6.9           | 0.2
	ember-inflector/index                             | 379.00 B  | 72.49 B    | 5.6           | 0.2
	ember-inflector/lib/helpers/pluralize             | 369.00 B  | 70.58 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 332.00 B  | 63.50 B    | 4.9           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 60.82 B    | 4.7           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 56.61 B    | 4.3           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.77 KB'  │
│  compressed  │ '541.89 B' │
│ % Of Library │   '1.4'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.27 KB   | 445.29 B   | 82.2          | 1.1
	@ember-data/debug/setup                           | 505.00 B  | 96.59 B    | 17.8          | 0.2

github-actions · 2022-08-17T03:40:46Z

Performance Report for 9b6c9b5

Scenario - basic-record-materialization: ✅ Performance improved

✅ duration
phase estimated improvement -164ms [-200ms to -139ms] OR -4.98% [-6.07% to -4.24%]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [-1ms to 4ms]
☑️ Phase [start-data-generation] => [start-push-payload]
phase no difference [-1ms to 3ms]
✅ Phase [start-push-payload] => [start-peek-records]
phase estimated improvement -144ms [-152ms to -136ms] OR -8.47% [-8.96% to -8%]
☑️ Phase [start-peek-records] => [start-record-materialization]
phase no difference [0ms to 0ms]
✅ Phase [start-record-materialization] => [end-record-materialization]
phase estimated improvement -16ms [-38ms to -1ms] OR -1.92% [-4.54% to -0.08%]
☑️ Phase [end-record-materialization] => [Test End]
phase no difference [-10ms to 0ms]

Scenario - relationship-materialization-simple: ✅ Performance improved

✅ duration
phase estimated improvement -23ms [-30ms to -16ms] OR -3.07% [-4.03% to -2.09%]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-3ms to 2ms]
✅ Phase [start-find-all] => [start-materialization]
phase estimated improvement -22ms [-25ms to -19ms] OR -5.65% [-6.45% to -4.81%]
⚠️ Phase [start-materialization] => [end-materialization]
phase estimated regression +4ms [1ms to 7ms] OR +4.9% [1.3% to 9.31%]
✅ Phase [end-materialization] => [Test End]
phase estimated improvement -2ms [-4ms to 0ms] OR -4.33% [-10.29% to -0.91%]

Scenario - relationship-materialization-complex: ✅ Performance improved

✅ duration
phase estimated improvement -132ms [-166ms to -97ms] OR -2.85% [-3.59% to -2.09%]
✅ Phase [navigationStart] => [start-data-generation]
phase estimated improvement -2ms [-4ms to 0ms] OR -0.96% [-1.75% to -0.14%]
☑️ Phase [start-data-generation] => [start-push-payload]
phase no difference [-1ms to 1ms]
✅ Phase [start-push-payload] => [start-peek-records]
phase estimated improvement -70ms [-76ms to -64ms] OR -8.26% [-8.95% to -7.56%]
☑️ Phase [start-peek-records] => [start-record-materialization]
phase no difference [0ms to 0ms]
☑️ Phase [start-record-materialization] => [start-relationship-materialization]
phase no difference [-6ms to 2ms]
✅ Phase [start-relationship-materialization] => [end-relationship-materialization]
phase estimated improvement -47ms [-76ms to -19ms] OR -1.75% [-2.8% to -0.71%]
✅ Phase [end-relationship-materialization] => [Test End]
phase estimated improvement -7ms [-13ms to 0ms] OR -1.78% [-3.33% to -0.1%]

Scenario - unload: ✅ Performance improved

✅ duration
phase estimated improvement -47ms [-56ms to -39ms] OR -4.12% [-4.86% to -3.41%]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-4ms to 4ms]
✅ Phase [start-push-payload] => [start-unload-records]
phase estimated improvement -48ms [-51ms to -44ms] OR -8.6% [-9.24% to -7.92%]
☑️ Phase [start-unload-records] => [end-unload-records]
phase no difference [0ms to 2ms]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [0ms to 0ms]

Scenario - unload-all: ✅ Performance improved

✅ duration
phase estimated improvement -99ms [-113ms to -86ms] OR -4.27% [-4.86% to -3.71%]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-5ms to 2ms]
✅ Phase [start-push-payload] => [start-materialization]
phase estimated improvement -92ms [-99ms to -86ms] OR -8.5% [-9.13% to -7.91%]
☑️ Phase [start-materialization] => [start-unload-all]
phase no difference [-3ms to 4ms]
✅ Phase [start-unload-all] => [end-unload-all]
phase estimated improvement -6ms [-10ms to -2ms] OR -1.67% [-2.76% to -0.68%]
☑️ Phase [end-unload-all] => [Test End]
phase no difference [0ms to 0ms]

Scenario - destroy: ✅ Performance improved

✅ duration
phase estimated improvement -51ms [-59ms to -43ms] OR -4.52% [-5.23% to -3.83%]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-4ms to 2ms]
✅ Phase [start-push-payload] => [start-destroy-records]
phase estimated improvement -47ms [-51ms to -44ms] OR -8.54% [-9.21% to -7.91%]
☑️ Phase [start-destroy-records] => [end-destroy-records]
phase no difference [-3ms to 1ms]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [0ms to 0ms]

Scenario - add-children: ✅ Performance improved

✅ duration
phase estimated improvement -53ms [-60ms to -46ms] OR -6.62% [-7.47% to -5.64%]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-4ms to 6ms]
✅ Phase [start-push-initial-payload] => [start-push-update-payload]
phase estimated improvement -21ms [-23ms to -20ms] OR -10.94% [-11.87% to -9.96%]
✅ Phase [start-push-update-payload] => [end-push-update-payload]
phase estimated improvement -33ms [-35ms to -31ms] OR -20.32% [-21.53% to -18.95%]
☑️ Phase [end-push-update-payload] => [Test End]
phase no difference [0ms to 0ms]

Scenario - unused-relationships: ✅ Performance improved

✅ duration
phase estimated improvement -50ms [-58ms to -43ms] OR -5.25% [-6.02% to -4.47%]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-5ms to 2ms]
✅ Phase [start-push-payload] => [end-push-payload]
phase estimated improvement -48ms [-52ms to -45ms] OR -8.8% [-9.36% to -8.24%]
☑️ Phase [end-push-payload] => [Test End]
phase no difference [0ms to 0ms]

github-actions · 2022-08-26T06:37:44Z

Commit v Release Performance Report for 9b6c9b5

Scenario - basic-record-materialization: ✅ Performance improved

✅ duration
phase estimated improvement -1359ms [-1410ms to -1303ms] OR -34.2% [-35.5% to -32.79%]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [-4ms to 1ms]
☑️ Phase [start-data-generation] => [start-push-payload]
phase no difference [-3ms to 1ms]
✅ Phase [start-push-payload] => [start-peek-records]
phase estimated improvement -605ms [-612ms to -598ms] OR -32.8% [-33.19% to -32.41%]
✅ Phase [start-peek-records] => [start-record-materialization]
phase estimated improvement -92ms [-93ms to -91ms] OR -96.39% [-97.52% to -95.48%]
✅ Phase [start-record-materialization] => [end-record-materialization]
phase estimated improvement -442ms [-452ms to -417ms] OR -48.22% [-49.26% to -45.48%]
✅ Phase [end-record-materialization] => [Test End]
phase estimated improvement -156ms [-377ms to -133ms] OR -75% [-181.11% to -63.81%]

Scenario - relationship-materialization-simple: ✅ Performance improved

✅ duration
phase estimated improvement -379ms [-387ms to -370ms] OR -35.04% [-35.76% to -34.22%]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-5ms to 0ms]
✅ Phase [start-find-all] => [start-materialization]
phase estimated improvement -73ms [-77ms to -69ms] OR -17.79% [-18.72% to -16.92%]
✅ Phase [start-materialization] => [end-materialization]
phase estimated improvement -246ms [-250ms to -243ms] OR -77.27% [-78.3% to -76.24%]
✅ Phase [end-materialization] => [Test End]
phase estimated improvement -61ms [-63ms to -59ms] OR -64.26% [-66.18% to -62.28%]

Scenario - relationship-materialization-complex: ✅ Performance improved

✅ duration
phase estimated improvement -919ms [-938ms to -900ms] OR -19.64% [-20.04% to -19.23%]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [-4ms to 1ms]
✅ Phase [start-data-generation] => [start-push-payload]
phase estimated improvement -1ms [-1ms to 0ms] OR -0.41% [-0.82% to -0.01%]
✅ Phase [start-push-payload] => [start-peek-records]
phase estimated improvement -249ms [-253ms to -244ms] OR -27.66% [-28.17% to -27.19%]
✅ Phase [start-peek-records] => [start-record-materialization]
phase estimated improvement -47ms [-48ms to -45ms] OR -95.6% [-98.86% to -92.84%]
✅ Phase [start-record-materialization] => [start-relationship-materialization]
phase estimated improvement -199ms [-201ms to -196ms] OR -47.64% [-48.21% to -46.99%]
✅ Phase [start-relationship-materialization] => [end-relationship-materialization]
phase estimated improvement -273ms [-288ms to -257ms] OR -11.26% [-11.86% to -10.61%]
✅ Phase [end-relationship-materialization] => [Test End]
phase estimated improvement -154ms [-162ms to -147ms] OR -33.63% [-35.5% to -32.17%]

Scenario - unload: ✅ Performance improved

✅ duration
phase estimated improvement -254ms [-263ms to -246ms] OR -20.4% [-21.06% to -19.72%]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-4ms to 1ms]
✅ Phase [start-push-payload] => [start-unload-records]
phase estimated improvement -149ms [-152ms to -145ms] OR -25.61% [-26.18% to -24.99%]
✅ Phase [start-unload-records] => [end-unload-records]
phase estimated improvement -107ms [-110ms to -104ms] OR -40.1% [-41.19% to -38.77%]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [0ms to 0ms]

Scenario - unload-all: ✅ Performance improved

✅ duration
phase estimated improvement -13599ms [-13642ms to -13560ms] OR -87.73% [-88% to -87.47%]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-5ms to 0ms]
✅ Phase [start-push-payload] => [start-materialization]
phase estimated improvement -387ms [-391ms to -383ms] OR -32.32% [-32.68% to -31.97%]
✅ Phase [start-materialization] => [start-unload-all]
phase estimated improvement -344ms [-346ms to -341ms] OR -55.68% [-56.1% to -55.26%]
✅ Phase [start-unload-all] => [end-unload-all]
phase estimated improvement -12886ms [-12906ms to -12827ms] OR -97.79% [-97.94% to -97.35%]
☑️ Phase [end-unload-all] => [Test End]
phase no difference [0ms to 0ms]

Scenario - destroy: ✅ Performance improved

✅ duration
phase estimated improvement -373ms [-381ms to -366ms] OR -27.3% [-27.84% to -26.75%]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-5ms to 1ms]
✅ Phase [start-push-payload] => [start-destroy-records]
phase estimated improvement -145ms [-148ms to -142ms] OR -25.14% [-25.66% to -24.66%]
✅ Phase [start-destroy-records] => [end-destroy-records]
phase estimated improvement -226ms [-229ms to -223ms] OR -58.44% [-59.21% to -57.69%]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [0ms to 0ms]

Scenario - add-children: ✅ Performance improved

✅ duration
phase estimated improvement -191ms [-197ms to -185ms] OR -21.02% [-21.72% to -20.37%]
✅ Phase [navigationStart] => [start-push-initial-payload]
phase estimated improvement -6ms [-10ms to -2ms] OR -1.52% [-2.5% to -0.38%]
✅ Phase [start-push-initial-payload] => [start-push-update-payload]
phase estimated improvement -76ms [-78ms to -74ms] OR -31.93% [-32.77% to -31.07%]
✅ Phase [start-push-update-payload] => [end-push-update-payload]
phase estimated improvement -76ms [-78ms to -74ms] OR -39.96% [-40.97% to -38.92%]
✅ Phase [end-push-update-payload] => [Test End]
phase estimated improvement -34ms [-35ms to -34ms] OR -52.7% [-53.46% to -52.05%]

Scenario - unused-relationships: ✅ Performance improved

✅ duration
phase estimated improvement -185ms [-192ms to -178ms] OR -18.2% [-18.88% to -17.48%]
✅ Phase [navigationStart] => [start-push-payload]
phase estimated improvement -3ms [-7ms to 0ms] OR -0.89% [-1.81% to -0.1%]
✅ Phase [start-push-payload] => [end-push-payload]
phase estimated improvement -153ms [-156ms to -149ms] OR -26.03% [-26.65% to -25.36%]
✅ Phase [end-push-payload] => [Test End]
phase estimated improvement -26ms [-27ms to -26ms] OR -45.46% [-47.33% to -44.36%]

runspired added 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166 🏷️ feat This PR introduces a new feature 🏷️ deprecation 5.0 Roadmap labels Aug 17, 2022

runspired added the 🎯 canary PR is targeting canary (default) label Aug 17, 2022

runspired force-pushed the runspired/v2.1-cache branch 2 times, most recently from d1a3735 to be37ef9 Compare August 26, 2022 05:31

runspired force-pushed the runspired/v2.1-cache branch from be37ef9 to e794cc1 Compare August 29, 2022 18:15

runspired added 12 commits August 29, 2022 14:25

activate singleton manager

ea18e72

activate via deprecation

26a7afb

simplify implementation

8862bb3

fixup tests

7ccb268

update tests

872019e

polish simplification, fix tests

297db00

fix tests

6fe2225

fix prototype extensions

51c1002

fix docs test

659b310

fix docs

8b54c8b

singleton record-data only

9179e41

fix docs

7bc5425

runspired force-pushed the runspired/v2.1-cache branch from bc7f252 to 7bc5425 Compare August 29, 2022 21:25

runspired added 2 commits August 29, 2022 15:43

fix missing methods

22a1152

remove useless tests

9b6c9b5

runspired merged commit 7255223 into master Aug 29, 2022

delete-merged-branch bot deleted the runspired/v2.1-cache branch August 29, 2022 22:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: deprecate v1 cache #8129

feat: deprecate v1 cache #8129

runspired commented Aug 17, 2022 •

edited

Loading

github-actions bot commented Aug 17, 2022 •

edited

Loading

github-actions bot commented Aug 17, 2022 •

edited

Loading

github-actions bot commented Aug 26, 2022 •

edited

Loading

feat: deprecate v1 cache #8129

feat: deprecate v1 cache #8129

Conversation

runspired commented Aug 17, 2022 • edited Loading

github-actions bot commented Aug 17, 2022 • edited Loading

github-actions bot commented Aug 17, 2022 • edited Loading

github-actions bot commented Aug 26, 2022 • edited Loading

runspired commented Aug 17, 2022 •

edited

Loading

github-actions bot commented Aug 17, 2022 •

edited

Loading

github-actions bot commented Aug 17, 2022 •

edited

Loading

github-actions bot commented Aug 26, 2022 •

edited

Loading