Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused evented infra #7970

Merged
merged 2 commits into from
Apr 23, 2022
Merged

Conversation

runspired
Copy link
Contributor

We were still running all the plumbing for firing lifecycle events on models even though we removed the Evented and trigger infra. The deletes that, saves bytes and should speed up some things.

@runspired runspired added 🎯 canary PR is targeting canary (default) 🏷️ cleanup This PR primarily removes deprecated functionality labels Apr 23, 2022
@github-actions
Copy link

github-actions bot commented Apr 23, 2022

Asset Size Report for 6e75654

Modern Builds

☑️ EmberData has not changed in size

If any packages had changed sizes they would be listed here.

Changeset



Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬──────────┐
│  (index)   │  Values  │
├────────────┼──────────┤
│   bytes    │ '0.00 B' │
│ compressed │ '1.00 B' │
│  packages  │    0     │
│  modules   │    0     │
└────────────┴──────────┘

Modern Builds (No Rollup)

☑️ EmberData has not changed in size

If any packages had changed sizes they would be listed here.

Changeset



Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬──────────┐
│  (index)   │  Values  │
├────────────┼──────────┤
│   bytes    │ '0.00 B' │
│ compressed │ '1.00 B' │
│  packages  │    0     │
│  modules   │    0     │
└────────────┴──────────┘

@github-actions
Copy link

Performance Report for 6e75654

Scenario - materialization: ☑️ Performance is stable

☑️ duration
phase no difference [-56ms to 0ms]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-14ms to 12ms]
✅ Phase [start-find-all] => [start-materialization]
phase estimated improvement -24ms [-40ms to -8ms] OR -2.28% [-3.82% to -0.81%]
✅ Phase [start-materialization] => [end-materialization]
phase estimated improvement -10ms [-21ms to 0ms] OR -1.19% [-2.45% to -0.04%]
☑️ Phase [end-materialization] => [Test End]
phase no difference [-8ms to 4ms]

Scenario - unload: ✅ Performance improved

✅ duration
phase estimated improvement -64ms [-94ms to -37ms] OR -1.95% [-2.85% to -1.12%]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-27ms to 10ms]
✅ Phase [start-push-payload] => [start-unload-records]
phase estimated improvement -43ms [-61ms to -23ms] OR -2.44% [-3.5% to -1.32%]
✅ Phase [start-unload-records] => [end-unload-records]
phase estimated improvement -13ms [-19ms to -7ms] OR -1.93% [-2.85% to -0.99%]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [-1ms to 3ms]

Scenario - destroy: ✅ Performance improved

✅ duration
phase estimated improvement -57ms [-86ms to -25ms] OR -1.53% [-2.32% to -0.68%]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-9ms to 27ms]
✅ Phase [start-push-payload] => [start-destroy-records]
phase estimated improvement -46ms [-62ms to -30ms] OR -2.66% [-3.57% to -1.71%]
✅ Phase [start-destroy-records] => [end-destroy-records]
phase estimated improvement -22ms [-34ms to -10ms] OR -1.98% [-3.13% to -0.94%]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [-1ms to 2ms]

Scenario - add-children: ✅ Performance improved

✅ duration
phase estimated improvement -47ms [-73ms to -17ms] OR -2.54% [-3.93% to -0.91%]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-27ms to 17ms]
✅ Phase [start-push-initial-payload] => [start-push-update-payload]
phase estimated improvement -25ms [-35ms to -16ms] OR -3.75% [-5.19% to -2.37%]
✅ Phase [start-push-update-payload] => [end-push-update-payload]
phase estimated improvement -10ms [-14ms to -6ms] OR -4.36% [-6.23% to -2.45%]
✅ Phase [end-push-update-payload] => [Test End]
phase estimated improvement -4ms [-7ms to -1ms] OR -3.33% [-5.21% to -1.15%]

Scenario - unused-relationships: ✅ Performance improved

✅ duration
phase estimated improvement -57ms [-89ms to -26ms] OR -2.11% [-3.3% to -0.95%]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-22ms to 15ms]
✅ Phase [start-push-payload] => [end-push-payload]
phase estimated improvement -40ms [-62ms to -18ms] OR -2.28% [-3.51% to -1.01%]
✅ Phase [end-push-payload] => [Test End]
phase estimated improvement -13ms [-16ms to -11ms] OR -8.83% [-10.83% to -7.06%]

@runspired runspired merged commit 02da1d3 into master Apr 23, 2022
@delete-merged-branch delete-merged-branch bot deleted the runspired/remove-evented-infra branch April 23, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 canary PR is targeting canary (default) 🏷️ cleanup This PR primarily removes deprecated functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant