[rfc]: deprecate RSVP.Promise #7880

snewcomer · 2022-02-17T02:35:16Z

emberjs/rfcs#796

github-actions · 2022-02-17T02:38:32Z

Asset Size Report for 1b72617

Modern Builds

EmberData increased by -17.0 B (+17.0 B compressed) which is within the allowed tolerance of 75 bytes uncompressed

Warnings

⚠️ The uncompressed size of the package @ember-data/store has increased by +17.0 B.

Changeset


EmberData +184.16 KB +17.0 B (+39.15 KB +17.0 B compressed)
    @ember-data/store +76.55 KB +17.0 B (+16.27 KB +17.0 B compressed)
        @ember-data/store/-private +75.63 KB +17.0 B (+16.08 KB +17.0 B compressed)

Full Asset Analysis (Modern)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '184.16 KB' │
│ compressed │ '39.15 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '76.55 KB' │
│  compressed  │ '16.27 KB' │
│ % Of Library │   '41.6'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 75.63 KB  | 16.08 KB   | 98.8          | 41.1
	@ember-data/store/index                           | 936.00 B  | 198.95 B   | 1.2           | 0.5

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '28.92 KB' │
│  compressed  │ '6.15 KB'  │
│ % Of Library │   '15.7'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 28.45 KB  | 6.05 KB    | 98.4          | 15.4
	@ember-data/model/index                           | 486.00 B  | 103.30 B   | 1.6           | 0.3

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '24.12 KB' │
│  compressed  │ '5.13 KB'  │
│ % Of Library │   '13.1'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 24.12 KB  | 5.13 KB    | 100.0         | 13.1

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '19.83 KB' │
│  compressed  │ '4.22 KB'  │
│ % Of Library │   '10.8'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.23 KB   | 1.54 KB    | 36.4          | 3.9
	@ember-data/serializer/-private                   | 5.54 KB   | 1.18 KB    | 27.9          | 3.0
	@ember-data/serializer/json-api                   | 3.75 KB   | 815.81 B   | 18.9          | 2.0
	@ember-data/serializer/rest                       | 2.85 KB   | 621.31 B   | 14.4          | 1.6
	@ember-data/serializer/index                      | 258.00 B  | 54.84 B    | 1.3           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 45.70 B    | 1.1           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.84 KB' │
│  compressed  │ '3.37 KB'  │
│ % Of Library │   '8.6'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 7.99 KB   | 1.70 KB    | 50.4          | 4.3
	@ember-data/adapter/-private                      | 3.79 KB   | 825.80 B   | 24.0          | 2.1
	@ember-data/adapter/error                         | 1.99 KB   | 433.41 B   | 12.6          | 1.1
	@ember-data/adapter/index                         | 1.04 KB   | 225.52 B   | 6.5           | 0.6
	@ember-data/adapter/json-api                      | 1.03 KB   | 225.10 B   | 6.5           | 0.6

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.35 KB' │
│  compressed  │ '1.99 KB' │
│ % Of Library │   '5.1'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 526.30 B   | 25.9          | 1.3
	ember-data/-private                               | 2.13 KB   | 462.95 B   | 22.8          | 1.2
	ember-data/adapters/errors                        | 1.19 KB   | 258.68 B   | 12.7          | 0.6
	ember-data/setup-container                        | 368.00 B  | 78.22 B    | 3.8           | 0.2
	ember-data/relationships                          | 318.00 B  | 67.59 B    | 3.3           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 58.24 B    | 2.9           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 53.35 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 52.07 B    | 2.6           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 51.65 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 51.65 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 51.22 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 50.37 B    | 2.5           | 0.1
	ember-data/serializer                             | 232.00 B  | 49.31 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 48.03 B    | 2.4           | 0.1
	ember-data/model                                  | 222.00 B  | 47.18 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 47.18 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 46.33 B    | 2.3           | 0.1
	ember-data/version                                | 161.00 B  | 34.22 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.74 KB' │
│  compressed  │ '1.43 KB' │
│ % Of Library │   '3.7'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 3.01 KB   | 655.11 B   | 44.7          | 1.6
	ember-inflector/lib/system/inflections            | 1.59 KB   | 345.83 B   | 23.6          | 0.9
	ember-inflector/lib/system                        | 471.00 B  | 100.11 B   | 6.8           | 0.2
	ember-inflector/index                             | 379.00 B  | 80.56 B    | 5.5           | 0.2
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 79.28 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 74.82 B    | 5.1           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 67.59 B    | 4.6           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 62.91 B    | 4.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.82 KB'  │
│  compressed  │ '613.02 B' │
│ % Of Library │   '1.5'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.32 KB   | 505.67 B   | 82.5          | 1.3
	@ember-data/debug/setup                           | 505.00 B  | 107.34 B   | 17.5          | 0.3

Modern Builds (No Rollup)

EmberData increased by -60.0 B (-2.0 B compressed) which is within the allowed tolerance of 75 bytes uncompressed

Warnings

⚠️ The uncompressed size of the package @ember-data/store has increased by +60.0 B.

Changeset


EmberData +223.02 KB +60.0 B (+42.19 KB -2.0 B compressed)
    @ember-data/store +99.51 KB +60.0 B (+18.82 KB -2.0 B compressed)
        @ember-data/store/-private/system/fetch-manager +5.29 KB +24.0 B (+1.0 KB -0.8 B compressed)
        @ember-data/store/-private/system/store/finders +3.55 KB +12.0 B (+687.78 B -0.4 B compressed)
        @ember-data/store/-private/system/store/common +628.0 B +24.0 B (+118.79 B -0.8 B compressed)

Full Asset Analysis (Modern)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '223.02 KB' │
│ compressed │ '42.19 KB'  │
│  packages  │      8      │
│  modules   │     148     │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '99.51 KB' │
│  compressed  │ '18.82 KB' │
│ % Of Library │   '44.6'   │
└──────────────┴────────────┘
	Module                                                                             | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/store/-private/system/core-store                                       | 15.42 KB  | 2.92 KB    | 15.5          | 6.9
	@ember-data/store/-private/system/model/internal-model                             | 14.65 KB  | 2.77 KB    | 14.7          | 6.6
	@ember-data/store/-private/system/model/states                                     | 5.49 KB   | 1.04 KB    | 5.5           | 2.5
	@ember-data/store/-private/system/fetch-manager                                    | 5.29 KB   | 1.00 KB    | 5.3           | 2.4
	@ember-data/store/-private/system/record-array-manager                             | 4.16 KB   | 805.81 B   | 4.2           | 1.9
	@ember-data/store/-private/identifiers/cache                                       | 3.88 KB   | 752.28 B   | 3.9           | 1.7
	@ember-data/store/-private/system/store/finders                                    | 3.55 KB   | 687.78 B   | 3.6           | 1.6
	@ember-data/store/-private/system/references/has-many                              | 3.48 KB   | 674.91 B   | 3.5           | 1.6
	@ember-data/store/-private/index                                                   | 3.35 KB   | 649.76 B   | 3.4           | 1.5
	@ember-data/store/-private/system/store/record-data-store-wrapper                  | 3.28 KB   | 635.76 B   | 3.3           | 1.5
	@ember-data/store/-private/system/snapshot                                         | 3.04 KB   | 589.60 B   | 3.1           | 1.4
	@ember-data/store/-private/system/store/internal-model-factory                     | 2.88 KB   | 557.07 B   | 2.9           | 1.3
	@ember-data/store/-private/system/references/belongs-to                            | 2.87 KB   | 555.18 B   | 2.9           | 1.3
	@ember-data/store/-private/system/references/record                                | 2.23 KB   | 431.84 B   | 2.2           | 1.0
	@ember-data/store/-private/system/record-arrays/record-array                       | 2.22 KB   | 430.52 B   | 2.2           | 1.0
	@ember-data/store/-private/system/ds-model-store                                   | 1.80 KB   | 348.99 B   | 1.8           | 0.8
	@ember-data/store/-private/system/request-cache                                    | 1.79 KB   | 346.16 B   | 1.8           | 0.8
	@ember-data/store/-private/system/schema-definition-service                        | 1.52 KB   | 293.76 B   | 1.5           | 0.7
	@ember-data/store/-private/system/model/shim-model-class                           | 1.41 KB   | 273.14 B   | 1.4           | 0.6
	@ember-data/store/-private/system/store/serializer-response                        | 1.14 KB   | 220.93 B   | 1.1           | 0.5
	@ember-data/store/-private/identifiers/utils/uuid-v4                               | 999.00 B  | 188.96 B   | 1.0           | 0.4
	@ember-data/store/index                                                            | 936.00 B  | 177.05 B   | 0.9           | 0.4
	@ember-data/store/-private/system/references/reference                             | 922.00 B  | 174.40 B   | 0.9           | 0.4
	@ember-data/store/-private/system/record-arrays/adapter-populated-record-array     | 904.00 B  | 170.99 B   | 0.9           | 0.4
	@ember-data/store/-private/system/internal-model-map                               | 886.00 B  | 167.59 B   | 0.9           | 0.4
	@ember-data/store/-private/system/promise-proxies                                  | 811.00 B  | 153.40 B   | 0.8           | 0.4
	@ember-data/store/-private/system/errors-utils                                     | 802.00 B  | 151.70 B   | 0.8           | 0.4
	@ember-data/store/-private/system/record-notification-manager                      | 783.00 B  | 148.11 B   | 0.8           | 0.3
	@ember-data/store/-private/system/snapshot-record-array                            | 769.00 B  | 145.46 B   | 0.8           | 0.3
	@ember-data/store/-private/utils/construct-resource                                | 699.00 B  | 132.22 B   | 0.7           | 0.3
	@ember-data/store/-private/system/store/common                                     | 628.00 B  | 118.79 B   | 0.6           | 0.3
	@ember-data/store/-private/system/references                                       | 598.00 B  | 113.11 B   | 0.6           | 0.3
	@ember-data/store/-private/system/coerce-id                                        | 494.00 B  | 93.44 B    | 0.5           | 0.2
	@ember-data/store/-private/system/record-arrays                                    | 487.00 B  | 92.12 B    | 0.5           | 0.2
	@ember-data/store/-private/system/identity-map                                     | 454.00 B  | 85.87 B    | 0.4           | 0.2
	@ember-data/store/-private/system/record-data-for                                  | 447.00 B  | 84.55 B    | 0.4           | 0.2
	@ember-data/store/-private/system/weak-cache                                       | 416.00 B  | 78.69 B    | 0.4           | 0.2
	@ember-data/store/-private/ts-interfaces/identifier                                | 348.00 B  | 65.82 B    | 0.3           | 0.2
	@ember-data/store/-private/ts-interfaces/fetch-manager                             | 316.00 B  | 59.77 B    | 0.3           | 0.1
	@ember-data/store/-private/identifiers/is-stable-identifier                        | 313.00 B  | 59.20 B    | 0.3           | 0.1
	@ember-data/store/-private/utils/promise-record                                    | 290.00 B  | 54.85 B    | 0.3           | 0.1
	@ember-data/store/-private/system/backburner                                       | 271.00 B  | 51.26 B    | 0.3           | 0.1
	@ember-data/store/-private/system/normalize-model-name                             | 220.00 B  | 41.61 B    | 0.2           | 0.1
	@ember-data/store/-private/utils/is-non-empty-string                               | 212.00 B  | 40.10 B    | 0.2           | 0.1
	@ember-data/store/-debug/index                                                     | 210.00 B  | 39.72 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-serializer-interface              | 169.00 B  | 31.96 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-record-wrapper                | 167.00 B  | 31.58 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-adapter-interface                 | 166.00 B  | 31.40 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-store-wrapper                 | 166.00 B  | 31.40 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/schema-definition-service                 | 166.00 B  | 31.40 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-json-api                      | 161.00 B  | 30.45 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/ember-data-json-api                       | 160.00 B  | 30.26 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-schemas                       | 160.00 B  | 30.26 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/promise-proxies                           | 156.00 B  | 29.50 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-instance                           | 156.00 B  | 29.50 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data                               | 152.00 B  | 28.75 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/ds-model                                  | 149.00 B  | 28.18 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/store                                     | 146.00 B  | 27.61 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/utils                                     | 146.00 B  | 27.61 B    | 0.1           | 0.1

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '33.00 KB' │
│  compressed  │ '6.24 KB'  │
│ % Of Library │   '14.8'   │
└──────────────┴────────────┘
	Module                                                                | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------
	@ember-data/model/-private/model                                      | 9.95 KB   | 1.88 KB    | 30.1          | 4.5
	@ember-data/model/-private/record-state                               | 6.23 KB   | 1.18 KB    | 18.9          | 2.8
	@ember-data/model/-private/system/promise-many-array                  | 3.95 KB   | 764.58 B   | 12.0          | 1.8
	@ember-data/model/-private/system/many-array                          | 2.84 KB   | 549.69 B   | 8.6           | 1.3
	@ember-data/model/-private/errors                                     | 2.05 KB   | 397.04 B   | 6.2           | 0.9
	@ember-data/model/-private/index                                      | 1.42 KB   | 275.41 B   | 4.3           | 0.6
	@ember-data/model/-private/system/relationships/relationship-meta     | 1.31 KB   | 252.90 B   | 4.0           | 0.6
	@ember-data/model/-private/attr                                       | 874.00 B  | 165.32 B   | 2.6           | 0.4
	@ember-data/model/-private/notify-changes                             | 845.00 B  | 159.83 B   | 2.5           | 0.4
	@ember-data/model/-private/belongs-to                                 | 688.00 B  | 130.14 B   | 2.0           | 0.3
	@ember-data/model/-private/has-many                                   | 648.00 B  | 122.57 B   | 1.9           | 0.3
	@ember-data/model/-private/util                                       | 526.00 B  | 99.49 B    | 1.6           | 0.2
	@ember-data/model/index                                               | 486.00 B  | 91.93 B    | 1.4           | 0.2
	@ember-data/model/-private/system/diff-array                          | 452.00 B  | 85.49 B    | 1.3           | 0.2
	@ember-data/model/-private/system/promise-belongs-to                  | 447.00 B  | 84.55 B    | 1.3           | 0.2
	@ember-data/model/-private/system/model-for-mixin                     | 427.00 B  | 80.77 B    | 1.3           | 0.2

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '31.23 KB' │
│  compressed  │ '5.91 KB'  │
│ % Of Library │   '14.0'   │
└──────────────┴────────────┘
	Module                                                                            | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private/record-data                                      | 8.29 KB   | 1.57 KB    | 26.5          | 3.7
	@ember-data/record-data/-private/graph/index                                      | 4.96 KB   | 961.11 B   | 15.9          | 2.2
	@ember-data/record-data/-private/graph/operations/replace-related-records         | 3.21 KB   | 621.19 B   | 10.3          | 1.4
	@ember-data/record-data/-private/graph/-edge-definition                           | 2.87 KB   | 556.12 B   | 9.2           | 1.3
	@ember-data/record-data/-private/relationships/state/has-many                     | 2.04 KB   | 394.39 B   | 6.5           | 0.9
	@ember-data/record-data/-private/relationships/state/belongs-to                   | 1.94 KB   | 375.29 B   | 6.2           | 0.9
	@ember-data/record-data/-private/graph/operations/update-relationship             | 1.51 KB   | 292.62 B   | 4.8           | 0.7
	@ember-data/record-data/-private/graph/operations/replace-related-record          | 1.06 KB   | 205.23 B   | 3.4           | 0.5
	@ember-data/record-data/-private/graph/-utils                                     | 1.06 KB   | 204.48 B   | 3.4           | 0.5
	@ember-data/record-data/-private/index                                            | 977.00 B  | 184.80 B   | 3.1           | 0.4
	@ember-data/record-data/-private/graph/operations/add-to-related-records          | 798.00 B  | 150.94 B   | 2.5           | 0.3
	@ember-data/record-data/-private/relationships/state/implicit                     | 692.00 B  | 130.89 B   | 2.2           | 0.3
	@ember-data/record-data/-private/graph/operations/remove-from-related-records     | 677.00 B  | 128.06 B   | 2.1           | 0.3
	@ember-data/record-data/-private/coerce-id                                        | 406.00 B  | 76.79 B    | 1.3           | 0.2
	@ember-data/record-data/-private/graph/-state                                     | 293.00 B  | 55.42 B    | 0.9           | 0.1
	@ember-data/record-data/-private/normalize-link                                   | 238.00 B  | 45.01 B    | 0.7           | 0.1
	@ember-data/record-data/-private/ts-interfaces/relationship-record-data           | 171.00 B  | 32.34 B    | 0.5           | 0.1
	@ember-data/record-data/-private/graph/-operations                                | 150.00 B  | 28.37 B    | 0.5           | 0.1

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.25 KB' │
│  compressed  │ '4.21 KB'  │
│ % Of Library │   '10.0'   │
└──────────────┴────────────┘
	Module                                                     | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                                | 7.23 KB   | 1.37 KB    | 32.5          | 3.2
	@ember-data/serializer/-private/embedded-records-mixin     | 4.43 KB   | 858.96 B   | 19.9          | 2.0
	@ember-data/serializer/json-api                            | 3.75 KB   | 725.99 B   | 16.8          | 1.7
	@ember-data/serializer/rest                                | 2.85 KB   | 552.91 B   | 12.8          | 1.3
	@ember-data/serializer/-private/index                      | 1.18 KB   | 228.88 B   | 5.3           | 0.5
	@ember-data/serializer/-private/transforms/date            | 530.00 B  | 100.25 B   | 2.3           | 0.2
	@ember-data/serializer/-private/transforms/boolean         | 511.00 B  | 96.66 B    | 2.2           | 0.2
	@ember-data/serializer/-private/transforms/number          | 453.00 B  | 85.68 B    | 2.0           | 0.2
	@ember-data/serializer/-private/transforms/string          | 381.00 B  | 72.06 B    | 1.7           | 0.2
	@ember-data/serializer/-private/utils                      | 303.00 B  | 57.31 B    | 1.3           | 0.1
	@ember-data/serializer/index                               | 258.00 B  | 48.80 B    | 1.1           | 0.1
	@ember-data/serializer/-private/transforms/transform       | 226.00 B  | 42.74 B    | 1.0           | 0.1
	@ember-data/serializer/transform                           | 215.00 B  | 40.66 B    | 0.9           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '17.97 KB' │
│  compressed  │ '3.40 KB'  │
│ % Of Library │   '8.1'    │
└──────────────┴────────────┘
	Module                                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                                      | 7.99 KB   | 1.51 KB    | 44.4          | 3.6
	@ember-data/adapter/error                                     | 1.99 KB   | 385.69 B   | 11.1          | 0.9
	@ember-data/adapter/-private/build-url-mixin                  | 1.93 KB   | 374.53 B   | 10.8          | 0.9
	@ember-data/adapter/index                                     | 1.04 KB   | 200.69 B   | 5.8           | 0.5
	@ember-data/adapter/json-api                                  | 1.03 KB   | 200.31 B   | 5.8           | 0.5
	@ember-data/adapter/-private/index                            | 1.03 KB   | 199.75 B   | 5.7           | 0.5
	@ember-data/adapter/-private/utils/serialize-query-params     | 770.00 B  | 145.65 B   | 4.2           | 0.3
	@ember-data/adapter/-private/utils/determine-body-promise     | 573.00 B  | 108.38 B   | 3.1           | 0.3
	@ember-data/adapter/-private/utils/parse-response-headers     | 494.00 B  | 93.44 B    | 2.7           | 0.2
	@ember-data/adapter/-private/utils/fetch                      | 454.00 B  | 85.87 B    | 2.5           | 0.2
	@ember-data/adapter/-private/utils/serialize-into-hash        | 367.00 B  | 69.42 B    | 2.0           | 0.2
	@ember-data/adapter/-private/utils/continue-on-reject         | 222.00 B  | 41.99 B    | 1.2           | 0.1
	@ember-data/adapter/-private/fastboot-interface               | 147.00 B  | 27.80 B    | 0.8           | 0.1

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.51 KB' │
│  compressed  │ '1.80 KB' │
│ % Of Library │   '4.3'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 468.35 B   | 25.4          | 1.1
	ember-data/-private/index                         | 1.93 KB   | 373.39 B   | 20.3          | 0.9
	ember-data/adapters/errors                        | 1.19 KB   | 230.20 B   | 12.5          | 0.5
	ember-data/-private/core                          | 368.00 B  | 69.61 B    | 3.8           | 0.2
	ember-data/setup-container                        | 368.00 B  | 69.61 B    | 3.8           | 0.2
	ember-data/relationships                          | 318.00 B  | 60.15 B    | 3.3           | 0.1
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 51.82 B    | 2.8           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 47.47 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 46.34 B    | 2.5           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 45.96 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 45.96 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 45.58 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 44.83 B    | 2.4           | 0.1
	ember-data/serializer                             | 232.00 B  | 43.88 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 42.74 B    | 2.3           | 0.1
	ember-data/model                                  | 222.00 B  | 41.99 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 41.99 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 41.23 B    | 2.2           | 0.1
	ember-data/version                                | 161.00 B  | 30.45 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.74 KB' │
│  compressed  │ '1.27 KB' │
│ % Of Library │   '3.0'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 3.01 KB   | 582.98 B   | 44.7          | 1.3
	ember-inflector/lib/system/inflections            | 1.59 KB   | 307.75 B   | 23.6          | 0.7
	ember-inflector/lib/system                        | 471.00 B  | 89.09 B    | 6.8           | 0.2
	ember-inflector/index                             | 379.00 B  | 71.69 B    | 5.5           | 0.2
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 70.55 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 66.58 B    | 5.1           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 60.15 B    | 4.6           | 0.1
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 55.99 B    | 4.3           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.82 KB'  │
│  compressed  │ '545.53 B' │
│ % Of Library │   '1.3'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.32 KB   | 450.00 B   | 82.5          | 1.0
	@ember-data/debug/setup                           | 505.00 B  | 95.52 B    | 17.5          | 0.2

github-actions · 2022-02-17T03:07:56Z

Performance Report for 51ecc7e

Scenario - materialization: ☑️ Performance is stable

☑️ duration
phase no difference [-29ms to 19ms]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-16ms to 9ms]
☑️ Phase [start-find-all] => [start-materialization]
phase no difference [-12ms to 16ms]
☑️ Phase [start-materialization] => [end-materialization]
phase no difference [-15ms to 10ms]
☑️ Phase [end-materialization] => [Test End]
phase no difference [-10ms to 3ms]

Scenario - unload: ☑️ Performance is stable

☑️ duration
phase no difference [-30ms to 19ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-20ms to 8ms]
☑️ Phase [start-push-payload] => [start-unload-records]
phase no difference [-24ms to 9ms]
⚠️ Phase [start-unload-records] => [end-unload-records]
phase estimated regression +8ms [3ms to 14ms] OR +1.31% [0.49% to 2.09%]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [0ms to 4ms]

Scenario - destroy: ☑️ Performance is stable

☑️ duration
phase no difference [-20ms to 31ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-7ms to 23ms]
☑️ Phase [start-push-payload] => [start-destroy-records]
phase no difference [-19ms to 16ms]
☑️ Phase [start-destroy-records] => [end-destroy-records]
phase no difference [-6ms to 11ms]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [-2ms to 2ms]

Scenario - add-children: ☑️ Performance is stable

☑️ duration
phase no difference [-5ms to 36ms]
⚠️ Phase [navigationStart] => [start-push-initial-payload]
phase estimated regression +22ms [5ms to 41ms] OR +2.67% [0.57% to 5.04%]
☑️ Phase [start-push-initial-payload] => [start-push-update-payload]
phase no difference [-15ms to 6ms]
☑️ Phase [start-push-update-payload] => [end-push-update-payload]
phase no difference [-3ms to 5ms]
☑️ Phase [end-push-update-payload] => [Test End]
phase no difference [-4ms to 1ms]

Scenario - unused-relationships: ☑️ Performance is stable

☑️ duration
phase no difference [-4ms to 48ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-12ms to 18ms]
⚠️ Phase [start-push-payload] => [end-push-payload]
phase estimated regression +23ms [4ms to 41ms] OR +1.33% [0.23% to 2.39%]
☑️ Phase [end-push-payload] => [Test End]
phase no difference [-2ms to 4ms]

snewcomer self-assigned this Feb 17, 2022

snewcomer force-pushed the sn/rsvp-promise branch 3 times, most recently from c96793b to 1d8d28c Compare February 19, 2022 16:01

snewcomer added 🏷️ feat This PR introduces a new feature 🎯 canary PR is targeting canary (default) labels Feb 19, 2022

snewcomer force-pushed the sn/rsvp-promise branch from 94ec680 to 9605ad1 Compare February 19, 2022 17:51

snewcomer force-pushed the sn/rsvp-promise branch from 9605ad1 to f76e22e Compare March 12, 2022 15:04

snewcomer changed the title ~~What happens without RSVP~~ [rfc]: deprecate RSVP.Promise Mar 13, 2022

snewcomer marked this pull request as ready for review March 13, 2022 14:11

snewcomer requested a review from runspired March 13, 2022 14:11

snewcomer added 15 commits March 30, 2022 22:16

What happens without RSVP

064ef9a

deprecate rsvp and see what happens

fee4374

fix

3989724

4.2 dep

2d7023f

add back return

a2caedd

assign to return value

4611b8d

add to belongsTo

4a5e2c7

deprecate if store is destroyed with hanging promise

4ee2b2a

add deprecation to fetch manager

3d0e76b

4.4

6de9b27

add deprecations

d4f5168

fix up

b892646

undo unnecessary

6bfb064

more detail in error message

f7f2d99

feedback

51ecc7e

snewcomer force-pushed the sn/rsvp-promise branch from d7c0e2e to 51ecc7e Compare March 31, 2022 03:16

craftable-bot approved these changes Mar 31, 2022

View reviewed changes

runspired approved these changes Mar 31, 2022

View reviewed changes

fix lint

1b72617

snewcomer merged commit b559cf0 into master Mar 31, 2022

delete-merged-branch bot deleted the sn/rsvp-promise branch March 31, 2022 15:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[rfc]: deprecate RSVP.Promise #7880

[rfc]: deprecate RSVP.Promise #7880

snewcomer commented Feb 17, 2022 •

edited

Loading

github-actions bot commented Feb 17, 2022 •

edited

Loading

Warnings

Warnings

github-actions bot commented Feb 17, 2022 •

edited

Loading

[rfc]: deprecate RSVP.Promise #7880

[rfc]: deprecate RSVP.Promise #7880

Conversation

snewcomer commented Feb 17, 2022 • edited Loading

github-actions bot commented Feb 17, 2022 • edited Loading

Warnings

Warnings

github-actions bot commented Feb 17, 2022 • edited Loading

snewcomer commented Feb 17, 2022 •

edited

Loading

github-actions bot commented Feb 17, 2022 •

edited

Loading

github-actions bot commented Feb 17, 2022 •

edited

Loading