Remove lint rule to prevent global Promise #7878

snewcomer · 2022-02-15T21:42:35Z

No description provided.

snewcomer · 2022-02-15T21:43:03Z

.eslintrc.js

@@ -52,7 +52,7 @@ module.exports = {
    'no-console': 'error', // no longer recommended in eslint v6, this restores it
    'no-eq-null': 'error',
    'no-eval': 'error',
-    'no-restricted-globals': ['error', { name: 'Promise', message: 'Global Promise does not work in IE11' }],
+    'no-restricted-globals': ['error', { name: 'Promise', message: 'Must use RSVP.Promise' }],


We will want to maintain this correct? Or with IE11 support dropped, can we remove this lint rule @runspired

with IE11 support dropped we can drop this

Any reason we can't look to drop rsvp? Need an RFC?

We may still rely on hooking into it to allow promise cancellation in one situation.

github-actions · 2022-02-15T21:47:01Z

Asset Size Report for 1ecc1a1

Modern Builds

☑️ EmberData has not changed in size

If any packages had changed sizes they would be listed here.

Changeset

Full Asset Analysis (Modern)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '184.01 KB' │
│ compressed │ '39.06 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '76.41 KB' │
│  compressed  │ '16.22 KB' │
│ % Of Library │   '41.5'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 75.50 KB  | 16.02 KB   | 98.8          | 41.0
	@ember-data/store/index                           | 936.00 B  | 198.66 B   | 1.2           | 0.5

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '28.97 KB' │
│  compressed  │ '6.15 KB'  │
│ % Of Library │   '15.7'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 28.50 KB  | 6.05 KB    | 98.4          | 15.5
	@ember-data/model/index                           | 486.00 B  | 103.15 B   | 1.6           | 0.3

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '24.06 KB' │
│  compressed  │ '5.11 KB'  │
│ % Of Library │   '13.1'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 24.06 KB  | 5.11 KB    | 100.0         | 13.1

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '19.83 KB' │
│  compressed  │ '4.21 KB'  │
│ % Of Library │   '10.8'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.23 KB   | 1.53 KB    | 36.4          | 3.9
	@ember-data/serializer/-private                   | 5.54 KB   | 1.18 KB    | 27.9          | 3.0
	@ember-data/serializer/json-api                   | 3.75 KB   | 814.62 B   | 18.9          | 2.0
	@ember-data/serializer/rest                       | 2.85 KB   | 620.41 B   | 14.4          | 1.6
	@ember-data/serializer/index                      | 258.00 B  | 54.76 B    | 1.3           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 45.63 B    | 1.1           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.84 KB' │
│  compressed  │ '3.36 KB'  │
│ % Of Library │   '8.6'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 7.99 KB   | 1.69 KB    | 50.4          | 4.3
	@ember-data/adapter/-private                      | 3.79 KB   | 824.60 B   | 24.0          | 2.1
	@ember-data/adapter/error                         | 1.99 KB   | 432.78 B   | 12.6          | 1.1
	@ember-data/adapter/index                         | 1.04 KB   | 225.20 B   | 6.5           | 0.6
	@ember-data/adapter/json-api                      | 1.03 KB   | 224.77 B   | 6.5           | 0.6

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.35 KB' │
│  compressed  │ '1.98 KB' │
│ % Of Library │   '5.1'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 525.53 B   | 25.9          | 1.3
	ember-data/-private                               | 2.13 KB   | 462.28 B   | 22.8          | 1.2
	ember-data/adapters/errors                        | 1.19 KB   | 258.31 B   | 12.7          | 0.6
	ember-data/setup-container                        | 368.00 B  | 78.10 B    | 3.8           | 0.2
	ember-data/relationships                          | 318.00 B  | 67.49 B    | 3.3           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 58.15 B    | 2.9           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 53.27 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 52.00 B    | 2.6           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 51.57 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 51.57 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 51.15 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 50.30 B    | 2.5           | 0.1
	ember-data/serializer                             | 232.00 B  | 49.24 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 47.96 B    | 2.4           | 0.1
	ember-data/model                                  | 222.00 B  | 47.12 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 47.12 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 46.27 B    | 2.3           | 0.1
	ember-data/version                                | 161.00 B  | 34.17 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.74 KB' │
│  compressed  │ '1.43 KB' │
│ % Of Library │   '3.7'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 3.01 KB   | 654.16 B   | 44.7          | 1.6
	ember-inflector/lib/system/inflections            | 1.59 KB   | 345.33 B   | 23.6          | 0.9
	ember-inflector/lib/system                        | 471.00 B  | 99.97 B    | 6.8           | 0.2
	ember-inflector/index                             | 379.00 B  | 80.44 B    | 5.5           | 0.2
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 79.17 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 74.71 B    | 5.1           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 67.49 B    | 4.6           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 62.82 B    | 4.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.82 KB'  │
│  compressed  │ '612.14 B' │
│ % Of Library │   '1.5'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.32 KB   | 504.95 B   | 82.5          | 1.3
	@ember-data/debug/setup                           | 505.00 B  | 107.18 B   | 17.5          | 0.3

Modern Builds (No Rollup)

☑️ EmberData has not changed in size

If any packages had changed sizes they would be listed here.

Changeset

Full Asset Analysis (Modern)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '222.62 KB' │
│ compressed │ '42.03 KB'  │
│  packages  │      8      │
│  modules   │     148     │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '99.14 KB' │
│  compressed  │ '18.72 KB' │
│ % Of Library │   '44.5'   │
└──────────────┴────────────┘
	Module                                                                             | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/store/-private/system/core-store                                       | 15.42 KB  | 2.91 KB    | 15.5          | 6.9
	@ember-data/store/-private/system/model/internal-model                             | 14.65 KB  | 2.77 KB    | 14.8          | 6.6
	@ember-data/store/-private/system/model/states                                     | 5.49 KB   | 1.04 KB    | 5.5           | 2.5
	@ember-data/store/-private/system/fetch-manager                                    | 5.26 KB   | 1017.78 B  | 5.3           | 2.4
	@ember-data/store/-private/system/record-array-manager                             | 4.16 KB   | 804.25 B   | 4.2           | 1.9
	@ember-data/store/-private/identifiers/cache                                       | 3.88 KB   | 750.82 B   | 3.9           | 1.7
	@ember-data/store/-private/system/store/finders                                    | 3.54 KB   | 684.18 B   | 3.6           | 1.6
	@ember-data/store/-private/system/references/has-many                              | 3.48 KB   | 673.61 B   | 3.5           | 1.6
	@ember-data/store/-private/system/store/record-data-store-wrapper                  | 3.28 KB   | 634.53 B   | 3.3           | 1.5
	@ember-data/store/-private/index                                                   | 3.24 KB   | 626.60 B   | 3.3           | 1.5
	@ember-data/store/-private/system/snapshot                                         | 3.04 KB   | 588.46 B   | 3.1           | 1.4
	@ember-data/store/-private/system/store/internal-model-factory                     | 2.88 KB   | 555.99 B   | 2.9           | 1.3
	@ember-data/store/-private/system/references/belongs-to                            | 2.87 KB   | 554.10 B   | 2.9           | 1.3
	@ember-data/store/-private/system/references/record                                | 2.23 KB   | 431.01 B   | 2.2           | 1.0
	@ember-data/store/-private/system/record-arrays/record-array                       | 2.22 KB   | 429.69 B   | 2.2           | 1.0
	@ember-data/store/-private/system/ds-model-store                                   | 1.80 KB   | 348.32 B   | 1.8           | 0.8
	@ember-data/store/-private/system/request-cache                                    | 1.79 KB   | 345.49 B   | 1.8           | 0.8
	@ember-data/store/-private/system/schema-definition-service                        | 1.52 KB   | 293.19 B   | 1.5           | 0.7
	@ember-data/store/-private/system/model/shim-model-class                           | 1.41 KB   | 272.61 B   | 1.4           | 0.6
	@ember-data/store/-private/system/store/serializer-response                        | 1.14 KB   | 220.51 B   | 1.2           | 0.5
	@ember-data/store/-private/identifiers/utils/uuid-v4                               | 999.00 B  | 188.60 B   | 1.0           | 0.4
	@ember-data/store/index                                                            | 936.00 B  | 176.71 B   | 0.9           | 0.4
	@ember-data/store/-private/system/references/reference                             | 922.00 B  | 174.06 B   | 0.9           | 0.4
	@ember-data/store/-private/system/record-arrays/adapter-populated-record-array     | 904.00 B  | 170.66 B   | 0.9           | 0.4
	@ember-data/store/-private/system/internal-model-map                               | 886.00 B  | 167.27 B   | 0.9           | 0.4
	@ember-data/store/-private/system/errors-utils                                     | 802.00 B  | 151.41 B   | 0.8           | 0.4
	@ember-data/store/-private/system/record-notification-manager                      | 783.00 B  | 147.82 B   | 0.8           | 0.3
	@ember-data/store/-private/system/snapshot-record-array                            | 769.00 B  | 145.18 B   | 0.8           | 0.3
	@ember-data/store/-private/utils/construct-resource                                | 699.00 B  | 131.96 B   | 0.7           | 0.3
	@ember-data/store/-private/system/promise-proxies                                  | 609.00 B  | 114.97 B   | 0.6           | 0.3
	@ember-data/store/-private/system/store/common                                     | 604.00 B  | 114.03 B   | 0.6           | 0.3
	@ember-data/store/-private/system/references                                       | 598.00 B  | 112.89 B   | 0.6           | 0.3
	@ember-data/store/-private/system/coerce-id                                        | 494.00 B  | 93.26 B    | 0.5           | 0.2
	@ember-data/store/-private/system/record-arrays                                    | 487.00 B  | 91.94 B    | 0.5           | 0.2
	@ember-data/store/-private/system/identity-map                                     | 454.00 B  | 85.71 B    | 0.4           | 0.2
	@ember-data/store/-private/system/record-data-for                                  | 447.00 B  | 84.39 B    | 0.4           | 0.2
	@ember-data/store/-private/system/weak-cache                                       | 416.00 B  | 78.53 B    | 0.4           | 0.2
	@ember-data/store/-private/ts-interfaces/identifier                                | 348.00 B  | 65.69 B    | 0.3           | 0.2
	@ember-data/store/-private/ts-interfaces/fetch-manager                             | 316.00 B  | 59.65 B    | 0.3           | 0.1
	@ember-data/store/-private/identifiers/is-stable-identifier                        | 313.00 B  | 59.09 B    | 0.3           | 0.1
	@ember-data/store/-private/utils/promise-record                                    | 290.00 B  | 54.74 B    | 0.3           | 0.1
	@ember-data/store/-private/system/backburner                                       | 271.00 B  | 51.16 B    | 0.3           | 0.1
	@ember-data/store/-private/system/normalize-model-name                             | 220.00 B  | 41.53 B    | 0.2           | 0.1
	@ember-data/store/-private/utils/is-non-empty-string                               | 212.00 B  | 40.02 B    | 0.2           | 0.1
	@ember-data/store/-debug/index                                                     | 210.00 B  | 39.64 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-serializer-interface              | 169.00 B  | 31.90 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-record-wrapper                | 167.00 B  | 31.52 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-adapter-interface                 | 166.00 B  | 31.33 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-store-wrapper                 | 166.00 B  | 31.33 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/schema-definition-service                 | 166.00 B  | 31.33 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-json-api                      | 161.00 B  | 30.39 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/ember-data-json-api                       | 160.00 B  | 30.20 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-schemas                       | 160.00 B  | 30.20 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/promise-proxies                           | 156.00 B  | 29.45 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-instance                           | 156.00 B  | 29.45 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data                               | 152.00 B  | 28.69 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/ds-model                                  | 149.00 B  | 28.13 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/store                                     | 146.00 B  | 27.56 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/utils                                     | 146.00 B  | 27.56 B    | 0.1           | 0.1

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '33.03 KB' │
│  compressed  │ '6.24 KB'  │
│ % Of Library │   '14.8'   │
└──────────────┴────────────┘
	Module                                                                | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------
	@ember-data/model/-private/model                                      | 9.97 KB   | 1.88 KB    | 30.2          | 4.5
	@ember-data/model/-private/record-state                               | 6.23 KB   | 1.18 KB    | 18.8          | 2.8
	@ember-data/model/-private/system/promise-many-array                  | 3.95 KB   | 763.10 B   | 12.0          | 1.8
	@ember-data/model/-private/system/many-array                          | 2.84 KB   | 548.63 B   | 8.6           | 1.3
	@ember-data/model/-private/errors                                     | 2.05 KB   | 396.27 B   | 6.2           | 0.9
	@ember-data/model/-private/index                                      | 1.42 KB   | 274.88 B   | 4.3           | 0.6
	@ember-data/model/-private/system/relationships/relationship-meta     | 1.31 KB   | 252.41 B   | 4.0           | 0.6
	@ember-data/model/-private/attr                                       | 874.00 B  | 165.00 B   | 2.6           | 0.4
	@ember-data/model/-private/notify-changes                             | 845.00 B  | 159.52 B   | 2.5           | 0.4
	@ember-data/model/-private/belongs-to                                 | 688.00 B  | 129.88 B   | 2.0           | 0.3
	@ember-data/model/-private/has-many                                   | 648.00 B  | 122.33 B   | 1.9           | 0.3
	@ember-data/model/-private/util                                       | 526.00 B  | 99.30 B    | 1.6           | 0.2
	@ember-data/model/index                                               | 486.00 B  | 91.75 B    | 1.4           | 0.2
	@ember-data/model/-private/system/diff-array                          | 452.00 B  | 85.33 B    | 1.3           | 0.2
	@ember-data/model/-private/system/promise-belongs-to                  | 447.00 B  | 84.39 B    | 1.3           | 0.2
	@ember-data/model/-private/system/model-for-mixin                     | 427.00 B  | 80.61 B    | 1.3           | 0.2

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '31.17 KB' │
│  compressed  │ '5.88 KB'  │
│ % Of Library │   '14.0'   │
└──────────────┴────────────┘
	Module                                                                            | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private/record-data                                      | 8.29 KB   | 1.57 KB    | 26.6          | 3.7
	@ember-data/record-data/-private/graph/index                                      | 4.96 KB   | 959.25 B   | 15.9          | 2.2
	@ember-data/record-data/-private/graph/operations/replace-related-records         | 3.15 KB   | 608.66 B   | 10.1          | 1.4
	@ember-data/record-data/-private/graph/-edge-definition                           | 2.87 KB   | 555.05 B   | 9.2           | 1.3
	@ember-data/record-data/-private/relationships/state/has-many                     | 2.04 KB   | 393.63 B   | 6.5           | 0.9
	@ember-data/record-data/-private/relationships/state/belongs-to                   | 1.94 KB   | 374.56 B   | 6.2           | 0.9
	@ember-data/record-data/-private/graph/operations/update-relationship             | 1.51 KB   | 292.06 B   | 4.8           | 0.7
	@ember-data/record-data/-private/graph/operations/replace-related-record          | 1.06 KB   | 204.84 B   | 3.4           | 0.5
	@ember-data/record-data/-private/graph/-utils                                     | 1.06 KB   | 204.08 B   | 3.4           | 0.5
	@ember-data/record-data/-private/index                                            | 977.00 B  | 184.45 B   | 3.1           | 0.4
	@ember-data/record-data/-private/graph/operations/add-to-related-records          | 798.00 B  | 150.65 B   | 2.5           | 0.4
	@ember-data/record-data/-private/relationships/state/implicit                     | 692.00 B  | 130.64 B   | 2.2           | 0.3
	@ember-data/record-data/-private/graph/operations/remove-from-related-records     | 677.00 B  | 127.81 B   | 2.1           | 0.3
	@ember-data/record-data/-private/coerce-id                                        | 406.00 B  | 76.64 B    | 1.3           | 0.2
	@ember-data/record-data/-private/graph/-state                                     | 293.00 B  | 55.31 B    | 0.9           | 0.1
	@ember-data/record-data/-private/normalize-link                                   | 238.00 B  | 44.93 B    | 0.7           | 0.1
	@ember-data/record-data/-private/ts-interfaces/relationship-record-data           | 171.00 B  | 32.28 B    | 0.5           | 0.1
	@ember-data/record-data/-private/graph/-operations                                | 150.00 B  | 28.31 B    | 0.5           | 0.1

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.25 KB' │
│  compressed  │ '4.20 KB'  │
│ % Of Library │   '10.0'   │
└──────────────┴────────────┘
	Module                                                     | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                                | 7.23 KB   | 1.36 KB    | 32.5          | 3.2
	@ember-data/serializer/-private/embedded-records-mixin     | 4.43 KB   | 857.30 B   | 19.9          | 2.0
	@ember-data/serializer/json-api                            | 3.75 KB   | 724.58 B   | 16.8          | 1.7
	@ember-data/serializer/rest                                | 2.85 KB   | 551.84 B   | 12.8          | 1.3
	@ember-data/serializer/-private/index                      | 1.18 KB   | 228.43 B   | 5.3           | 0.5
	@ember-data/serializer/-private/transforms/date            | 530.00 B  | 100.06 B   | 2.3           | 0.2
	@ember-data/serializer/-private/transforms/boolean         | 511.00 B  | 96.47 B    | 2.2           | 0.2
	@ember-data/serializer/-private/transforms/number          | 453.00 B  | 85.52 B    | 2.0           | 0.2
	@ember-data/serializer/-private/transforms/string          | 381.00 B  | 71.93 B    | 1.7           | 0.2
	@ember-data/serializer/-private/utils                      | 303.00 B  | 57.20 B    | 1.3           | 0.1
	@ember-data/serializer/index                               | 258.00 B  | 48.70 B    | 1.1           | 0.1
	@ember-data/serializer/-private/transforms/transform       | 226.00 B  | 42.66 B    | 1.0           | 0.1
	@ember-data/serializer/transform                           | 215.00 B  | 40.59 B    | 0.9           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '17.97 KB' │
│  compressed  │ '3.39 KB'  │
│ % Of Library │   '8.1'    │
└──────────────┴────────────┘
	Module                                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                                      | 7.99 KB   | 1.51 KB    | 44.4          | 3.6
	@ember-data/adapter/error                                     | 1.99 KB   | 384.94 B   | 11.1          | 0.9
	@ember-data/adapter/-private/build-url-mixin                  | 1.93 KB   | 373.80 B   | 10.8          | 0.9
	@ember-data/adapter/index                                     | 1.04 KB   | 200.30 B   | 5.8           | 0.5
	@ember-data/adapter/json-api                                  | 1.03 KB   | 199.93 B   | 5.8           | 0.5
	@ember-data/adapter/-private/index                            | 1.03 KB   | 199.36 B   | 5.7           | 0.5
	@ember-data/adapter/-private/utils/serialize-query-params     | 770.00 B  | 145.37 B   | 4.2           | 0.3
	@ember-data/adapter/-private/utils/determine-body-promise     | 573.00 B  | 108.17 B   | 3.1           | 0.3
	@ember-data/adapter/-private/utils/parse-response-headers     | 494.00 B  | 93.26 B    | 2.7           | 0.2
	@ember-data/adapter/-private/utils/fetch                      | 454.00 B  | 85.71 B    | 2.5           | 0.2
	@ember-data/adapter/-private/utils/serialize-into-hash        | 367.00 B  | 69.28 B    | 2.0           | 0.2
	@ember-data/adapter/-private/utils/continue-on-reject         | 222.00 B  | 41.91 B    | 1.2           | 0.1
	@ember-data/adapter/-private/fastboot-interface               | 147.00 B  | 27.75 B    | 0.8           | 0.1

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.51 KB' │
│  compressed  │ '1.79 KB' │
│ % Of Library │   '4.3'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 467.44 B   | 25.4          | 1.1
	ember-data/-private/index                         | 1.93 KB   | 372.67 B   | 20.3          | 0.9
	ember-data/adapters/errors                        | 1.19 KB   | 229.76 B   | 12.5          | 0.5
	ember-data/-private/core                          | 368.00 B  | 69.47 B    | 3.8           | 0.2
	ember-data/setup-container                        | 368.00 B  | 69.47 B    | 3.8           | 0.2
	ember-data/relationships                          | 318.00 B  | 60.03 B    | 3.3           | 0.1
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 51.72 B    | 2.8           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 47.38 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 46.25 B    | 2.5           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 45.87 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 45.87 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 45.49 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 44.74 B    | 2.4           | 0.1
	ember-data/serializer                             | 232.00 B  | 43.79 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 42.66 B    | 2.3           | 0.1
	ember-data/model                                  | 222.00 B  | 41.91 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 41.91 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 41.15 B    | 2.2           | 0.1
	ember-data/version                                | 161.00 B  | 30.39 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.74 KB' │
│  compressed  │ '1.27 KB' │
│ % Of Library │   '3.0'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 3.01 KB   | 581.85 B   | 44.7          | 1.4
	ember-inflector/lib/system/inflections            | 1.59 KB   | 307.16 B   | 23.6          | 0.7
	ember-inflector/lib/system                        | 471.00 B  | 88.92 B    | 6.8           | 0.2
	ember-inflector/index                             | 379.00 B  | 71.55 B    | 5.5           | 0.2
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 70.41 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 66.45 B    | 5.1           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 60.03 B    | 4.6           | 0.1
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 55.88 B    | 4.3           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.82 KB'  │
│  compressed  │ '544.47 B' │
│ % Of Library │   '1.3'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.32 KB   | 449.13 B   | 82.5          | 1.0
	@ember-data/debug/setup                           | 505.00 B  | 95.33 B    | 17.5          | 0.2

github-actions · 2022-02-15T22:08:00Z

Performance Report for 1ecc1a1

Scenario - materialization: ☑️ Performance is stable

☑️ duration
phase no difference [-45ms to 59ms]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-11ms to 12ms]
☑️ Phase [start-find-all] => [start-materialization]
phase no difference [-23ms to 15ms]
☑️ Phase [start-materialization] => [end-materialization]
phase no difference [-9ms to 17ms]
☑️ Phase [end-materialization] => [Test End]
phase no difference [-9ms to 6ms]

Scenario - unload: ☑️ Performance is stable

☑️ duration
phase no difference [-52ms to 9ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-9ms to 16ms]
☑️ Phase [start-push-payload] => [start-unload-records]
phase no difference [-26ms to 6ms]
☑️ Phase [start-unload-records] => [end-unload-records]
phase no difference [-14ms to 0ms]
✅ Phase [end-unload-records] => [Test End]
phase estimated improvement -1ms [-2ms to 0ms] OR -1.04% [-2.47% to -0.05%]

Scenario - destroy: ☑️ Performance is stable

☑️ duration
phase no difference [-43ms to 9ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-14ms to 8ms]
☑️ Phase [start-push-payload] => [start-destroy-records]
phase no difference [-26ms to 9ms]
☑️ Phase [start-destroy-records] => [end-destroy-records]
phase no difference [-9ms to 1ms]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [0ms to 1ms]

Scenario - add-children: ☑️ Performance is stable

☑️ duration
phase no difference [-10ms to 27ms]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-9ms to 17ms]
☑️ Phase [start-push-initial-payload] => [start-push-update-payload]
phase no difference [-2ms to 15ms]
☑️ Phase [start-push-update-payload] => [end-push-update-payload]
phase no difference [-5ms to 3ms]
☑️ Phase [end-push-update-payload] => [Test End]
phase no difference [-1ms to 1ms]

Scenario - unused-relationships: ☑️ Performance is stable

☑️ duration
phase no difference [-33ms to 29ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-10ms to 15ms]
☑️ Phase [start-push-payload] => [end-push-payload]
phase no difference [-25ms to 17ms]
☑️ Phase [end-push-payload] => [Test End]
phase no difference [-2ms to 3ms]

Configure lint rule message to disallow global Promises for RSVP

33f47a5

snewcomer added 🎯 canary PR is targeting canary (default) 🏷️ chore This PR primarily refactors code or updates dependencies labels Feb 15, 2022

snewcomer self-assigned this Feb 15, 2022

snewcomer commented Feb 15, 2022

View reviewed changes

Cleanup no-restricted-globals

1ecc1a1

snewcomer requested a review from runspired February 16, 2022 02:59

snewcomer changed the title ~~Configure lint rule message to disallow global Promises for RSVP~~ Remove lint rule to prevent global Promise Feb 16, 2022

runspired merged commit 69d0ad6 into master Feb 16, 2022

delete-merged-branch bot deleted the sn/change-global-promise-lint branch February 16, 2022 22:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove lint rule to prevent global Promise #7878

Remove lint rule to prevent global Promise #7878

snewcomer commented Feb 15, 2022

snewcomer Feb 15, 2022

runspired Feb 15, 2022

snewcomer Feb 16, 2022

runspired Feb 16, 2022

github-actions bot commented Feb 15, 2022 •

edited

Loading

github-actions bot commented Feb 15, 2022 •

edited

Loading

Remove lint rule to prevent global Promise #7878

Remove lint rule to prevent global Promise #7878

Conversation

snewcomer commented Feb 15, 2022

snewcomer Feb 15, 2022

Choose a reason for hiding this comment

runspired Feb 15, 2022

Choose a reason for hiding this comment

snewcomer Feb 16, 2022

Choose a reason for hiding this comment

runspired Feb 16, 2022

Choose a reason for hiding this comment

github-actions bot commented Feb 15, 2022 • edited Loading

github-actions bot commented Feb 15, 2022 • edited Loading

github-actions bot commented Feb 15, 2022 •

edited

Loading

github-actions bot commented Feb 15, 2022 •

edited

Loading