chore: remove no-longer-needed misdirection for IdentifierCache lookup #7862

runspired · 2022-02-10T19:30:41Z

This weak-map cache had been required when we had not yet activated the feature flag which added the store.identifierCache property, now that it is active we do not need the helper to access the cache.

github-actions · 2022-02-10T19:34:17Z

Asset Size Report for 7f6f0bf

Modern Builds

EmberData increased by +75.0 B uncompressed but decreased by -68.0 B compressed

Warnings

⚠️ The uncompressed size of the package @ember-data/store has increased by +75.0 B.

Changeset


EmberData +183.59 KB +75.0 B (+38.91 KB -68.0 B compressed)
    @ember-data/store +75.97 KB +75.0 B (+16.1 KB -68.0 B compressed)
        @ember-data/store/-private +75.06 KB +75.0 B (+15.91 KB -68.0 B compressed)

Full Asset Analysis (Modern)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '183.59 KB' │
│ compressed │ '38.91 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '75.97 KB' │
│  compressed  │ '16.10 KB' │
│ % Of Library │   '41.4'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 75.06 KB  | 15.91 KB   | 98.8          | 40.9
	@ember-data/store/index                           | 936.00 B  | 198.38 B   | 1.2           | 0.5

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '28.97 KB' │
│  compressed  │ '6.14 KB'  │
│ % Of Library │   '15.8'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 28.50 KB  | 6.04 KB    | 98.4          | 15.5
	@ember-data/model/index                           | 486.00 B  | 103.00 B   | 1.6           | 0.3

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '24.07 KB' │
│  compressed  │ '5.10 KB'  │
│ % Of Library │   '13.1'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 24.07 KB  | 5.10 KB    | 100.0         | 13.1

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '19.83 KB' │
│  compressed  │ '4.20 KB'  │
│ % Of Library │   '10.8'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.23 KB   | 1.53 KB    | 36.4          | 3.9
	@ember-data/serializer/-private                   | 5.54 KB   | 1.17 KB    | 27.9          | 3.0
	@ember-data/serializer/json-api                   | 3.75 KB   | 813.48 B   | 18.9          | 2.0
	@ember-data/serializer/rest                       | 2.85 KB   | 619.54 B   | 14.4          | 1.6
	@ember-data/serializer/index                      | 258.00 B  | 54.68 B    | 1.3           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 45.57 B    | 1.1           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.84 KB' │
│  compressed  │ '3.36 KB'  │
│ % Of Library │   '8.6'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 7.99 KB   | 1.69 KB    | 50.4          | 4.3
	@ember-data/adapter/-private                      | 3.79 KB   | 822.38 B   | 23.9          | 2.1
	@ember-data/adapter/error                         | 1.99 KB   | 432.17 B   | 12.6          | 1.1
	@ember-data/adapter/index                         | 1.04 KB   | 224.88 B   | 6.5           | 0.6
	@ember-data/adapter/json-api                      | 1.03 KB   | 224.45 B   | 6.5           | 0.6

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.35 KB' │
│  compressed  │ '1.98 KB' │
│ % Of Library │   '5.1'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 524.79 B   | 25.9          | 1.3
	ember-data/-private                               | 2.13 KB   | 461.63 B   | 22.8          | 1.2
	ember-data/adapters/errors                        | 1.19 KB   | 257.94 B   | 12.7          | 0.6
	ember-data/setup-container                        | 368.00 B  | 77.99 B    | 3.8           | 0.2
	ember-data/relationships                          | 318.00 B  | 67.40 B    | 3.3           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 58.07 B    | 2.9           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 53.20 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 51.92 B    | 2.6           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 51.50 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 51.50 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 51.08 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 50.23 B    | 2.5           | 0.1
	ember-data/serializer                             | 232.00 B  | 49.17 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 47.90 B    | 2.4           | 0.1
	ember-data/model                                  | 222.00 B  | 47.05 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 47.05 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 46.20 B    | 2.3           | 0.1
	ember-data/version                                | 161.00 B  | 34.12 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.74 KB' │
│  compressed  │ '1.43 KB' │
│ % Of Library │   '3.7'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 3.01 KB   | 653.24 B   | 44.7          | 1.6
	ember-inflector/lib/system/inflections            | 1.59 KB   | 344.84 B   | 23.6          | 0.9
	ember-inflector/lib/system                        | 471.00 B  | 99.83 B    | 6.8           | 0.3
	ember-inflector/index                             | 379.00 B  | 80.33 B    | 5.5           | 0.2
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 79.05 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 74.60 B    | 5.1           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 67.40 B    | 4.6           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 62.73 B    | 4.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.82 KB'  │
│  compressed  │ '611.27 B' │
│ % Of Library │   '1.5'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.32 KB   | 504.23 B   | 82.5          | 1.3
	@ember-data/debug/setup                           | 505.00 B  | 107.03 B   | 17.5          | 0.3

Modern Builds (No Rollup)

✅ EmberData shrank by -775.0 B (-67.0 B compressed)

If any packages had changed sizes they would be listed here.

Changeset


EmberData +221.43 KB -775.0 B (+41.99 KB -67.0 B compressed)
    @ember-data/store +97.99 KB -775.0 B (+18.58 KB -67.0 B compressed)
        @ember-data/store/-private/system/core-store +15.5 KB -164.0 B (+2.94 KB -14.18 B compressed)
        @ember-data/store/-private/system/model/internal-model +14.65 KB -69.0 B (+2.78 KB -5.97 B compressed)
        @ember-data/store/-private/identifiers/cache +3.84 KB -114.0 B (+744.92 B -9.86 B compressed)
        @ember-data/store/-private/system/store/record-data-store-wrapper +3.27 KB -194.0 B (+634.73 B -16.77 B compressed)
        @ember-data/store/-private/index +3.11 KB -106.0 B (+603.82 B -9.16 B compressed)
        @ember-data/store/-private/system/store/internal-model-factory +2.83 KB -59.0 B (+549.01 B -5.1 B compressed)
        @ember-data/store/-private/system/record-notification-manager +731.0 B -69.0 B (+138.62 B -5.97 B compressed)

Full Asset Analysis (Modern)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '221.43 KB' │
│ compressed │ '41.99 KB'  │
│  packages  │      8      │
│  modules   │     147     │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '97.99 KB' │
│  compressed  │ '18.58 KB' │
│ % Of Library │   '44.3'   │
└──────────────┴────────────┘
	Module                                                                             | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/store/-private/system/core-store                                       | 15.50 KB  | 2.94 KB    | 15.8          | 7.0
	@ember-data/store/-private/system/model/internal-model                             | 14.65 KB  | 2.78 KB    | 15.0          | 6.6
	@ember-data/store/-private/system/model/states                                     | 5.49 KB   | 1.04 KB    | 5.6           | 2.5
	@ember-data/store/-private/system/fetch-manager                                    | 5.21 KB   | 1011.93 B  | 5.3           | 2.4
	@ember-data/store/-private/system/record-array-manager                             | 4.11 KB   | 797.26 B   | 4.2           | 1.9
	@ember-data/store/-private/identifiers/cache                                       | 3.84 KB   | 744.92 B   | 3.9           | 1.7
	@ember-data/store/-private/system/store/finders                                    | 3.54 KB   | 687.26 B   | 3.6           | 1.6
	@ember-data/store/-private/system/store/record-data-store-wrapper                  | 3.27 KB   | 634.73 B   | 3.3           | 1.5
	@ember-data/store/-private/system/references/has-many                              | 3.23 KB   | 627.72 B   | 3.3           | 1.5
	@ember-data/store/-private/index                                                   | 3.11 KB   | 603.82 B   | 3.2           | 1.4
	@ember-data/store/-private/system/snapshot                                         | 3.09 KB   | 599.65 B   | 3.2           | 1.4
	@ember-data/store/-private/system/references/belongs-to                            | 2.87 KB   | 556.60 B   | 2.9           | 1.3
	@ember-data/store/-private/system/store/internal-model-factory                     | 2.83 KB   | 549.01 B   | 2.9           | 1.3
	@ember-data/store/-private/system/record-arrays/record-array                       | 2.22 KB   | 431.62 B   | 2.3           | 1.0
	@ember-data/store/-private/system/references/record                                | 2.02 KB   | 392.37 B   | 2.1           | 0.9
	@ember-data/store/-private/system/ds-model-store                                   | 1.92 KB   | 373.78 B   | 2.0           | 0.9
	@ember-data/store/-private/system/request-cache                                    | 1.79 KB   | 347.04 B   | 1.8           | 0.8
	@ember-data/store/-private/system/schema-definition-service                        | 1.52 KB   | 294.51 B   | 1.5           | 0.7
	@ember-data/store/-private/system/model/shim-model-class                           | 1.32 KB   | 256.20 B   | 1.3           | 0.6
	@ember-data/store/-private/system/store/serializer-response                        | 1.14 KB   | 221.50 B   | 1.2           | 0.5
	@ember-data/store/-private/identifiers/utils/uuid-v4                               | 999.00 B  | 189.45 B   | 1.0           | 0.4
	@ember-data/store/index                                                            | 936.00 B  | 177.50 B   | 0.9           | 0.4
	@ember-data/store/-private/system/references/reference                             | 916.00 B  | 173.71 B   | 0.9           | 0.4
	@ember-data/store/-private/system/record-arrays/adapter-populated-record-array     | 904.00 B  | 171.43 B   | 0.9           | 0.4
	@ember-data/store/-private/system/internal-model-map                               | 886.00 B  | 168.02 B   | 0.9           | 0.4
	@ember-data/store/-private/system/errors-utils                                     | 802.00 B  | 152.09 B   | 0.8           | 0.4
	@ember-data/store/-private/system/snapshot-record-array                            | 769.00 B  | 145.83 B   | 0.8           | 0.3
	@ember-data/store/-private/system/record-notification-manager                      | 731.00 B  | 138.62 B   | 0.7           | 0.3
	@ember-data/store/-private/utils/construct-resource                                | 699.00 B  | 132.56 B   | 0.7           | 0.3
	@ember-data/store/-private/system/promise-proxies                                  | 609.00 B  | 115.49 B   | 0.6           | 0.3
	@ember-data/store/-private/system/store/common                                     | 604.00 B  | 114.54 B   | 0.6           | 0.3
	@ember-data/store/-private/system/references                                       | 598.00 B  | 113.40 B   | 0.6           | 0.3
	@ember-data/store/-private/system/coerce-id                                        | 494.00 B  | 93.68 B    | 0.5           | 0.2
	@ember-data/store/-private/system/record-arrays                                    | 487.00 B  | 92.35 B    | 0.5           | 0.2
	@ember-data/store/-private/system/identity-map                                     | 454.00 B  | 86.09 B    | 0.5           | 0.2
	@ember-data/store/-private/system/record-data-for                                  | 392.00 B  | 74.34 B    | 0.4           | 0.2
	@ember-data/store/-private/ts-interfaces/identifier                                | 348.00 B  | 65.99 B    | 0.3           | 0.2
	@ember-data/store/-private/identifiers/is-stable-identifier                        | 329.00 B  | 62.39 B    | 0.3           | 0.1
	@ember-data/store/-private/ts-interfaces/fetch-manager                             | 316.00 B  | 59.92 B    | 0.3           | 0.1
	@ember-data/store/-private/utils/promise-record                                    | 290.00 B  | 54.99 B    | 0.3           | 0.1
	@ember-data/store/-private/system/backburner                                       | 271.00 B  | 51.39 B    | 0.3           | 0.1
	@ember-data/store/-private/system/normalize-model-name                             | 220.00 B  | 41.72 B    | 0.2           | 0.1
	@ember-data/store/-private/utils/is-non-empty-string                               | 212.00 B  | 40.20 B    | 0.2           | 0.1
	@ember-data/store/-debug/index                                                     | 210.00 B  | 39.82 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-serializer-interface              | 169.00 B  | 32.04 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-record-wrapper                | 167.00 B  | 31.67 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-adapter-interface                 | 166.00 B  | 31.48 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-store-wrapper                 | 166.00 B  | 31.48 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/schema-definition-service                 | 166.00 B  | 31.48 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-json-api                      | 161.00 B  | 30.53 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/ember-data-json-api                       | 160.00 B  | 30.34 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-schemas                       | 160.00 B  | 30.34 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/promise-proxies                           | 156.00 B  | 29.58 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-instance                           | 156.00 B  | 29.58 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data                               | 152.00 B  | 28.82 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/ds-model                                  | 149.00 B  | 28.25 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/store                                     | 146.00 B  | 27.68 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/utils                                     | 146.00 B  | 27.68 B    | 0.1           | 0.1

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '33.03 KB' │
│  compressed  │ '6.26 KB'  │
│ % Of Library │   '14.9'   │
└──────────────┴────────────┘
	Module                                                                | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------
	@ember-data/model/-private/model                                      | 9.97 KB   | 1.89 KB    | 30.2          | 4.5
	@ember-data/model/-private/record-state                               | 6.23 KB   | 1.18 KB    | 18.8          | 2.8
	@ember-data/model/-private/system/promise-many-array                  | 3.95 KB   | 766.53 B   | 12.0          | 1.8
	@ember-data/model/-private/system/many-array                          | 2.84 KB   | 551.10 B   | 8.6           | 1.3
	@ember-data/model/-private/errors                                     | 2.05 KB   | 398.06 B   | 6.2           | 0.9
	@ember-data/model/-private/index                                      | 1.42 KB   | 276.12 B   | 4.3           | 0.6
	@ember-data/model/-private/system/relationships/relationship-meta     | 1.31 KB   | 253.55 B   | 4.0           | 0.6
	@ember-data/model/-private/attr                                       | 874.00 B  | 165.74 B   | 2.6           | 0.4
	@ember-data/model/-private/notify-changes                             | 845.00 B  | 160.24 B   | 2.5           | 0.4
	@ember-data/model/-private/belongs-to                                 | 688.00 B  | 130.47 B   | 2.0           | 0.3
	@ember-data/model/-private/has-many                                   | 648.00 B  | 122.88 B   | 1.9           | 0.3
	@ember-data/model/-private/util                                       | 526.00 B  | 99.75 B    | 1.6           | 0.2
	@ember-data/model/index                                               | 486.00 B  | 92.16 B    | 1.4           | 0.2
	@ember-data/model/-private/system/diff-array                          | 452.00 B  | 85.71 B    | 1.3           | 0.2
	@ember-data/model/-private/system/promise-belongs-to                  | 447.00 B  | 84.77 B    | 1.3           | 0.2
	@ember-data/model/-private/system/model-for-mixin                     | 427.00 B  | 80.97 B    | 1.3           | 0.2

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '31.14 KB' │
│  compressed  │ '5.91 KB'  │
│ % Of Library │   '14.1'   │
└──────────────┴────────────┘
	Module                                                                            | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private/record-data                                      | 8.29 KB   | 1.57 KB    | 26.6          | 3.7
	@ember-data/record-data/-private/graph/index                                      | 4.93 KB   | 957.51 B   | 15.8          | 2.2
	@ember-data/record-data/-private/graph/operations/replace-related-records         | 3.15 KB   | 611.41 B   | 10.1          | 1.4
	@ember-data/record-data/-private/graph/-edge-definition                           | 2.87 KB   | 557.55 B   | 9.2           | 1.3
	@ember-data/record-data/-private/relationships/state/has-many                     | 2.04 KB   | 395.40 B   | 6.5           | 0.9
	@ember-data/record-data/-private/relationships/state/belongs-to                   | 1.94 KB   | 376.25 B   | 6.2           | 0.9
	@ember-data/record-data/-private/graph/operations/update-relationship             | 1.51 KB   | 293.37 B   | 4.9           | 0.7
	@ember-data/record-data/-private/graph/operations/replace-related-record          | 1.06 KB   | 205.76 B   | 3.4           | 0.5
	@ember-data/record-data/-private/graph/-utils                                     | 1.06 KB   | 205.00 B   | 3.4           | 0.5
	@ember-data/record-data/-private/index                                            | 977.00 B  | 185.28 B   | 3.1           | 0.4
	@ember-data/record-data/-private/graph/operations/add-to-related-records          | 798.00 B  | 151.33 B   | 2.5           | 0.4
	@ember-data/record-data/-private/relationships/state/implicit                     | 692.00 B  | 131.23 B   | 2.2           | 0.3
	@ember-data/record-data/-private/graph/operations/remove-from-related-records     | 677.00 B  | 128.38 B   | 2.1           | 0.3
	@ember-data/record-data/-private/coerce-id                                        | 406.00 B  | 76.99 B    | 1.3           | 0.2
	@ember-data/record-data/-private/graph/-state                                     | 293.00 B  | 55.56 B    | 0.9           | 0.1
	@ember-data/record-data/-private/normalize-link                                   | 238.00 B  | 45.13 B    | 0.7           | 0.1
	@ember-data/record-data/-private/ts-interfaces/relationship-record-data           | 171.00 B  | 32.42 B    | 0.5           | 0.1
	@ember-data/record-data/-private/graph/-operations                                | 150.00 B  | 28.44 B    | 0.5           | 0.1

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.25 KB' │
│  compressed  │ '4.22 KB'  │
│ % Of Library │   '10.1'   │
└──────────────┴────────────┘
	Module                                                     | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                                | 7.23 KB   | 1.37 KB    | 32.5          | 3.3
	@ember-data/serializer/-private/embedded-records-mixin     | 4.43 KB   | 861.17 B   | 19.9          | 2.0
	@ember-data/serializer/json-api                            | 3.75 KB   | 727.85 B   | 16.8          | 1.7
	@ember-data/serializer/rest                                | 2.85 KB   | 554.32 B   | 12.8          | 1.3
	@ember-data/serializer/-private/index                      | 1.18 KB   | 229.46 B   | 5.3           | 0.5
	@ember-data/serializer/-private/transforms/date            | 530.00 B  | 100.51 B   | 2.3           | 0.2
	@ember-data/serializer/-private/transforms/boolean         | 511.00 B  | 96.90 B    | 2.2           | 0.2
	@ember-data/serializer/-private/transforms/number          | 453.00 B  | 85.90 B    | 2.0           | 0.2
	@ember-data/serializer/-private/transforms/string          | 381.00 B  | 72.25 B    | 1.7           | 0.2
	@ember-data/serializer/-private/utils                      | 303.00 B  | 57.46 B    | 1.3           | 0.1
	@ember-data/serializer/index                               | 258.00 B  | 48.92 B    | 1.1           | 0.1
	@ember-data/serializer/-private/transforms/transform       | 226.00 B  | 42.85 B    | 1.0           | 0.1
	@ember-data/serializer/transform                           | 215.00 B  | 40.77 B    | 0.9           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '17.96 KB' │
│  compressed  │ '3.41 KB'  │
│ % Of Library │   '8.1'    │
└──────────────┴────────────┘
	Module                                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                                      | 7.99 KB   | 1.51 KB    | 44.5          | 3.6
	@ember-data/adapter/error                                     | 1.99 KB   | 386.68 B   | 11.1          | 0.9
	@ember-data/adapter/-private/build-url-mixin                  | 1.93 KB   | 375.49 B   | 10.8          | 0.9
	@ember-data/adapter/index                                     | 1.04 KB   | 201.21 B   | 5.8           | 0.5
	@ember-data/adapter/json-api                                  | 1.03 KB   | 200.83 B   | 5.8           | 0.5
	@ember-data/adapter/-private/index                            | 1.03 KB   | 200.26 B   | 5.7           | 0.5
	@ember-data/adapter/-private/utils/serialize-query-params     | 770.00 B  | 146.02 B   | 4.2           | 0.3
	@ember-data/adapter/-private/utils/determine-body-promise     | 568.00 B  | 107.71 B   | 3.1           | 0.3
	@ember-data/adapter/-private/utils/parse-response-headers     | 494.00 B  | 93.68 B    | 2.7           | 0.2
	@ember-data/adapter/-private/utils/fetch                      | 454.00 B  | 86.09 B    | 2.5           | 0.2
	@ember-data/adapter/-private/utils/serialize-into-hash        | 367.00 B  | 69.59 B    | 2.0           | 0.2
	@ember-data/adapter/-private/utils/continue-on-reject         | 222.00 B  | 42.10 B    | 1.2           | 0.1
	@ember-data/adapter/-private/fastboot-interface               | 147.00 B  | 27.87 B    | 0.8           | 0.1

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.51 KB' │
│  compressed  │ '1.80 KB' │
│ % Of Library │   '4.3'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 469.55 B   | 25.4          | 1.1
	ember-data/-private/index                         | 1.93 KB   | 374.35 B   | 20.3          | 0.9
	ember-data/adapters/errors                        | 1.19 KB   | 230.79 B   | 12.5          | 0.5
	ember-data/-private/core                          | 368.00 B  | 69.78 B    | 3.8           | 0.2
	ember-data/setup-container                        | 368.00 B  | 69.78 B    | 3.8           | 0.2
	ember-data/relationships                          | 318.00 B  | 60.30 B    | 3.3           | 0.1
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 51.96 B    | 2.8           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 47.60 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 46.46 B    | 2.5           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 46.08 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 46.08 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 45.70 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 44.94 B    | 2.4           | 0.1
	ember-data/serializer                             | 232.00 B  | 43.99 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 42.85 B    | 2.3           | 0.1
	ember-data/model                                  | 222.00 B  | 42.10 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 42.10 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 41.34 B    | 2.2           | 0.1
	ember-data/version                                | 161.00 B  | 30.53 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.74 KB' │
│  compressed  │ '1.28 KB' │
│ % Of Library │   '3.0'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 3.01 KB   | 584.48 B   | 44.7          | 1.4
	ember-inflector/lib/system/inflections            | 1.59 KB   | 308.54 B   | 23.6          | 0.7
	ember-inflector/lib/system                        | 471.00 B  | 89.32 B    | 6.8           | 0.2
	ember-inflector/index                             | 379.00 B  | 71.87 B    | 5.5           | 0.2
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 70.73 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 66.75 B    | 5.1           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 60.30 B    | 4.6           | 0.1
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 56.13 B    | 4.3           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.82 KB'  │
│  compressed  │ '546.93 B' │
│ % Of Library │   '1.3'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.32 KB   | 451.16 B   | 82.5          | 1.0
	@ember-data/debug/setup                           | 505.00 B  | 95.76 B    | 17.5          | 0.2

github-actions · 2022-02-10T20:02:56Z

Performance Report for 7f6f0bf

Scenario - materialization: ☑️ Performance is stable

☑️ duration
phase no difference [-14ms to 33ms]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-10ms to 7ms]
☑️ Phase [start-find-all] => [start-materialization]
phase no difference [-9ms to 12ms]
☑️ Phase [start-materialization] => [end-materialization]
phase no difference [-8ms to 2ms]
☑️ Phase [end-materialization] => [Test End]
phase no difference [-4ms to 9ms]

Scenario - unload: ☑️ Performance is stable

☑️ duration
phase no difference [-31ms to 9ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-13ms to 11ms]
☑️ Phase [start-push-payload] => [start-unload-records]
phase no difference [-26ms to 6ms]
☑️ Phase [start-unload-records] => [end-unload-records]
phase no difference [-8ms to 1ms]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [-1ms to 1ms]

Scenario - destroy: ✅ Performance improved

✅ duration
phase estimated improvement -34ms [-53ms to -13ms] OR -1.03% [-1.61% to -0.41%]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-18ms to 5ms]
☑️ Phase [start-push-payload] => [start-destroy-records]
phase no difference [-20ms to 6ms]
✅ Phase [start-destroy-records] => [end-destroy-records]
phase estimated improvement -21ms [-28ms to -14ms] OR -2.03% [-2.75% to -1.39%]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [0ms to 1ms]

Scenario - add-children: ☑️ Performance is stable

☑️ duration
phase no difference [-20ms to 12ms]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-8ms to 14ms]
☑️ Phase [start-push-initial-payload] => [start-push-update-payload]
phase no difference [-11ms to 6ms]
✅ Phase [start-push-update-payload] => [end-push-update-payload]
phase estimated improvement -4ms [-8ms to 0ms] OR -1.99% [-3.86% to -0.18%]
⚠️ Phase [end-push-update-payload] => [Test End]
phase estimated regression +1ms [0ms to 3ms] OR +1.32% [0.01% to 2.6%]

Scenario - unused-relationships: ✅ Performance improved

✅ duration
phase estimated improvement -26ms [-46ms to -6ms] OR -1.09% [-1.95% to -0.25%]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-7ms to 16ms]
✅ Phase [start-push-payload] => [end-push-payload]
phase estimated improvement -28ms [-41ms to -16ms] OR -1.88% [-2.74% to -1.04%]
☑️ Phase [end-push-payload] => [Test End]
phase no difference [-3ms to 1ms]

chore: remove no-longer-needed misdirection for IdentifierCache lookup

89aecec

runspired requested a review from snewcomer February 10, 2022 19:30

runspired added 🏷️ cleanup This PR primarily removes deprecated functionality 🎯 canary PR is targeting canary (default) labels Feb 10, 2022

runspired added 3 commits February 10, 2022 13:06

lint and docs fixes

fb99130

simplify prop access

e31dd28

fix tests and bump qunit/testem version

7f6f0bf

runspired merged commit 1829495 into master Feb 11, 2022

delete-merged-branch bot deleted the runspired/remove-identifier-cache-for branch February 11, 2022 02:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: remove no-longer-needed misdirection for IdentifierCache lookup #7862

chore: remove no-longer-needed misdirection for IdentifierCache lookup #7862

runspired commented Feb 10, 2022

github-actions bot commented Feb 10, 2022 •

edited

Loading

Warnings

github-actions bot commented Feb 10, 2022 •

edited

Loading

chore: remove no-longer-needed misdirection for IdentifierCache lookup #7862

chore: remove no-longer-needed misdirection for IdentifierCache lookup #7862

Conversation

runspired commented Feb 10, 2022

github-actions bot commented Feb 10, 2022 • edited Loading

Warnings

github-actions bot commented Feb 10, 2022 • edited Loading

github-actions bot commented Feb 10, 2022 •

edited

Loading

github-actions bot commented Feb 10, 2022 •

edited

Loading