Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecated assign usage from @ember/assign #7722

Merged
merged 3 commits into from
Nov 5, 2021
Merged

Fix deprecated assign usage from @ember/assign #7722

merged 3 commits into from
Nov 5, 2021

Conversation

snewcomer
Copy link
Contributor

@snewcomer snewcomer commented Oct 18, 2021 •
edited
Loading

prep for 4.0!

ref #7724

@snewcomer snewcomer self-assigned this Oct 18, 2021
@snewcomer snewcomer added 🏷️ chore This PR primarily refactors code or updates dependencies 🏷️ cleanup This PR primarily removes deprecated functionality 🎯 canary PR is targeting canary (default) labels Oct 18, 2021
@github-actions
Copy link

github-actions bot commented Oct 18, 2021 •
edited
Loading

Asset Size Report for acb3cf6

Modern Builds

✅ EmberData shrank by -147.0 B (-3.0 B compressed)

If any packages had changed sizes they would be listed here.

Changeset


EmberData +178.88 KB -147.0 B (+38.91 KB -3.0 B compressed)
    @ember-data/store +72.16 KB -72.0 B (+15.7 KB -1.47 B compressed)
        @ember-data/store/-private +71.24 KB -72.0 B (+15.5 KB -1.47 B compressed)
    @ember-data/record-data +23.74 KB -15.0 B (+5.16 KB -0.31 B compressed)
        @ember-data/record-data/-private +23.74 KB -15.0 B (+5.16 KB -0.31 B compressed)
    @ember-data/serializer +19.63 KB -20.0 B (+4.27 KB -0.41 B compressed)
        @ember-data/serializer/json +7.19 KB -20.0 B (+1.56 KB -0.41 B compressed)
    @ember-data/adapter +15.92 KB -40.0 B (+3.46 KB -0.82 B compressed)
        @ember-data/adapter/rest +8.07 KB -40.0 B (+1.76 KB -0.82 B compressed)
Full Asset Analysis (Modern) 

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '178.88 KB' │
│ compressed │ '38.91 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '72.16 KB' │
│  compressed  │ '15.70 KB' │
│ % Of Library │   '40.3'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 71.24 KB  | 15.50 KB   | 98.7          | 39.8
	@ember-data/store/index                           | 936.00 B  | 203.60 B   | 1.3           | 0.5

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '28.55 KB' │
│  compressed  │ '6.21 KB'  │
│ % Of Library │   '16.0'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 28.08 KB  | 6.11 KB    | 98.3          | 15.7
	@ember-data/model/index                           | 486.00 B  | 105.71 B   | 1.7           | 0.3

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '23.74 KB' │
│  compressed  │ '5.16 KB'  │
│ % Of Library │   '13.3'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 23.74 KB  | 5.16 KB    | 100.0         | 13.3

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '19.63 KB' │
│  compressed  │ '4.27 KB'  │
│ % Of Library │   '11.0'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.19 KB   | 1.56 KB    | 36.6          | 4.0
	@ember-data/serializer/-private                   | 5.49 KB   | 1.19 KB    | 28.0          | 3.1
	@ember-data/serializer/json-api                   | 3.73 KB   | 830.07 B   | 19.0          | 2.1
	@ember-data/serializer/rest                       | 2.76 KB   | 614.94 B   | 14.1          | 1.5
	@ember-data/serializer/index                      | 258.00 B  | 56.12 B    | 1.3           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 46.76 B    | 1.1           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.92 KB' │
│  compressed  │ '3.46 KB'  │
│ % Of Library │   '8.9'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 8.07 KB   | 1.76 KB    | 50.7          | 4.5
	@ember-data/adapter/-private                      | 3.76 KB   | 837.47 B   | 23.6          | 2.1
	@ember-data/adapter/error                         | 1.94 KB   | 432.65 B   | 12.2          | 1.1
	@ember-data/adapter/index                         | 1.10 KB   | 244.71 B   | 6.9           | 0.6
	@ember-data/adapter/json-api                      | 1.04 KB   | 232.31 B   | 6.6           | 0.6

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.36 KB' │
│  compressed  │ '2.04 KB' │
│ % Of Library │   '5.2'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 538.15 B   | 25.8          | 1.4
	ember-data/-private                               | 2.12 KB   | 472.46 B   | 22.7          | 1.2
	ember-data/adapters/errors                        | 1.19 KB   | 264.72 B   | 12.7          | 0.7
	ember-data/setup-container                        | 387.00 B  | 84.18 B    | 4.0           | 0.2
	ember-data/relationships                          | 318.00 B  | 69.17 B    | 3.3           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 59.60 B    | 2.9           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 54.59 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 53.29 B    | 2.6           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 52.85 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 52.85 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 52.42 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 51.55 B    | 2.5           | 0.1
	ember-data/serializer                             | 232.00 B  | 50.46 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 49.16 B    | 2.4           | 0.1
	ember-data/model                                  | 222.00 B  | 48.29 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 48.29 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 47.42 B    | 2.3           | 0.1
	ember-data/version                                | 162.00 B  | 35.23 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.71 KB' │
│  compressed  │ '1.46 KB' │
│ % Of Library │   '3.8'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.89 KB   | 644.74 B   | 43.1          | 1.6
	ember-inflector/lib/system/inflections            | 1.59 KB   | 353.91 B   | 23.7          | 0.9
	ember-inflector/index                             | 473.00 B  | 102.88 B   | 6.9           | 0.3
	ember-inflector/lib/system                        | 471.00 B  | 102.45 B   | 6.9           | 0.3
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 81.13 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 76.56 B    | 5.1           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 69.17 B    | 4.6           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 64.38 B    | 4.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.81 KB'  │
│  compressed  │ '625.60 B' │
│ % Of Library │   '1.6'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.32 KB   | 517.05 B   | 82.6          | 1.3
	@ember-data/debug/setup                           | 499.00 B  | 108.54 B   | 17.4          | 0.3

Modern Builds (No Rollup)

✅ EmberData shrank by -339.0 B (-26.0 B compressed)

If any packages had changed sizes they would be listed here.

Changeset


EmberData +220.29 KB -339.0 B (+42.3 KB -26.0 B compressed)
    @ember-data/store +97.68 KB -249.0 B (+18.76 KB -19.1 B compressed)
        @ember-data/store/-private/system/core-store +17.33 KB -33.0 B (+3.33 KB -2.53 B compressed)
        @ember-data/store/-private/system/model/internal-model +14.42 KB -21.0 B (+2.77 KB -1.61 B compressed)
        @ember-data/store/-private/system/store/finders +4.55 KB -20.0 B (+894.83 B -1.53 B compressed)
        @ember-data/store/-private/system/record-array-manager +4.14 KB -45.0 B (+814.56 B -3.45 B compressed)
        @ember-data/store/-private/identifiers/cache +3.95 KB -33.0 B (+776.54 B -2.53 B compressed)
        @ember-data/store/-private/system/snapshot +3.07 KB -33.0 B (+604.1 B -2.53 B compressed)
        @ember-data/store/-private/system/ds-model-store +1.94 KB -19.0 B (+382.12 B -1.46 B compressed)
        @ember-data/store/-private/system/record-arrays/adapter-populated-record-array +923.0 B -45.0 B (+177.23 B -3.45 B compressed)
    @ember-data/record-data +30.8 KB -30.0 B (+5.91 KB -2.3 B compressed)
        @ember-data/record-data/-private/record-data +8.18 KB -30.0 B (+1.57 KB -2.3 B compressed)
    @ember-data/serializer +22.06 KB -20.0 B (+4.24 KB -1.53 B compressed)
        @ember-data/serializer/json +7.19 KB -20.0 B (+1.38 KB -1.53 B compressed)
    @ember-data/adapter +18.05 KB -40.0 B (+3.47 KB -3.07 B compressed)
        @ember-data/adapter/rest +8.07 KB -40.0 B (+1.55 KB -3.07 B compressed)
Full Asset Analysis (Modern) 

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '220.29 KB' │
│ compressed │ '42.30 KB'  │
│  packages  │      8      │
│  modules   │     149     │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '97.68 KB' │
│  compressed  │ '18.76 KB' │
│ % Of Library │   '44.3'   │
└──────────────┴────────────┘
	Module                                                                             | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/store/-private/system/core-store                                       | 17.33 KB  | 3.33 KB    | 17.7          | 7.9
	@ember-data/store/-private/system/model/internal-model                             | 14.42 KB  | 2.77 KB    | 14.8          | 6.5
	@ember-data/store/-private/system/model/states                                     | 5.44 KB   | 1.04 KB    | 5.6           | 2.5
	@ember-data/store/-private/system/fetch-manager                                    | 5.09 KB   | 1001.59 B  | 5.2           | 2.3
	@ember-data/store/-private/system/store/finders                                    | 4.55 KB   | 894.83 B   | 4.7           | 2.1
	@ember-data/store/-private/system/record-array-manager                             | 4.14 KB   | 814.56 B   | 4.2           | 1.9
	@ember-data/store/-private/identifiers/cache                                       | 3.95 KB   | 776.54 B   | 4.0           | 1.8
	@ember-data/store/-private/index                                                   | 3.57 KB   | 701.84 B   | 3.7           | 1.6
	@ember-data/store/-private/system/store/record-data-store-wrapper                  | 3.41 KB   | 669.77 B   | 3.5           | 1.5
	@ember-data/store/-private/system/snapshot                                         | 3.07 KB   | 604.10 B   | 3.1           | 1.4
	@ember-data/store/-private/system/store/internal-model-factory                     | 2.83 KB   | 557.06 B   | 2.9           | 1.3
	@ember-data/store/-private/system/record-arrays/record-array                       | 2.28 KB   | 448.37 B   | 2.3           | 1.0
	@ember-data/store/-private/system/ds-model-store                                   | 1.94 KB   | 382.12 B   | 2.0           | 0.9
	@ember-data/store/-private/system/request-cache                                    | 1.89 KB   | 370.79 B   | 1.9           | 0.9
	@ember-data/store/-private/system/references/has-many                              | 1.53 KB   | 301.28 B   | 1.6           | 0.7
	@ember-data/store/-private/system/schema-definition-service                        | 1.51 KB   | 297.06 B   | 1.5           | 0.7
	@ember-data/store/-private/system/references/belongs-to                            | 1.32 KB   | 260.00 B   | 1.4           | 0.6
	@ember-data/store/-private/system/model/shim-model-class                           | 1.32 KB   | 259.04 B   | 1.3           | 0.6
	@ember-data/store/-private/system/store/serializer-response                        | 1.14 KB   | 224.28 B   | 1.2           | 0.5
	@ember-data/store/-private/identifiers/utils/uuid-v4                               | 1.05 KB   | 207.00 B   | 1.1           | 0.5
	@ember-data/store/-private/system/references/record                                | 984.00 B  | 188.95 B   | 1.0           | 0.4
	@ember-data/store/index                                                            | 936.00 B  | 179.73 B   | 0.9           | 0.4
	@ember-data/store/-private/system/references/reference                             | 934.00 B  | 179.35 B   | 0.9           | 0.4
	@ember-data/store/-private/system/record-arrays/adapter-populated-record-array     | 923.00 B  | 177.23 B   | 0.9           | 0.4
	@ember-data/store/-private/system/internal-model-map                               | 886.00 B  | 170.13 B   | 0.9           | 0.4
	@ember-data/store/-private/system/errors-utils                                     | 796.00 B  | 152.85 B   | 0.8           | 0.4
	@ember-data/store/-private/system/snapshot-record-array                            | 753.00 B  | 144.59 B   | 0.8           | 0.3
	@ember-data/store/-private/system/record-notification-manager                      | 697.00 B  | 133.84 B   | 0.7           | 0.3
	@ember-data/store/-private/utils/construct-resource                                | 695.00 B  | 133.45 B   | 0.7           | 0.3
	@ember-data/store/-private/system/promise-proxies                                  | 607.00 B  | 116.55 B   | 0.6           | 0.3
	@ember-data/store/-private/system/references                                       | 598.00 B  | 114.83 B   | 0.6           | 0.3
	@ember-data/store/-private/system/store/common                                     | 527.00 B  | 101.19 B   | 0.5           | 0.2
	@ember-data/store/-private/system/coerce-id                                        | 494.00 B  | 94.85 B    | 0.5           | 0.2
	@ember-data/store/-private/system/record-arrays                                    | 487.00 B  | 93.51 B    | 0.5           | 0.2
	@ember-data/store/-private/system/identity-map                                     | 450.00 B  | 86.41 B    | 0.4           | 0.2
	@ember-data/store/-private/ts-interfaces/identifier                                | 400.00 B  | 76.80 B    | 0.4           | 0.2
	@ember-data/store/-private/utils/symbol                                            | 392.00 B  | 75.27 B    | 0.4           | 0.2
	@ember-data/store/-private/system/record-data-for                                  | 390.00 B  | 74.88 B    | 0.4           | 0.2
	@ember-data/store/-private/identifiers/is-stable-identifier                        | 327.00 B  | 62.79 B    | 0.3           | 0.1
	@ember-data/store/-private/ts-interfaces/fetch-manager                             | 316.00 B  | 60.67 B    | 0.3           | 0.1
	@ember-data/store/-private/utils/promise-record                                    | 290.00 B  | 55.68 B    | 0.3           | 0.1
	@ember-data/store/-private/system/backburner                                       | 269.00 B  | 51.65 B    | 0.3           | 0.1
	@ember-data/store/-private/system/deprecated-evented                               | 257.00 B  | 49.35 B    | 0.3           | 0.1
	@ember-data/store/-private/system/normalize-model-name                             | 220.00 B  | 42.24 B    | 0.2           | 0.1
	@ember-data/store/-private/utils/is-non-empty-string                               | 212.00 B  | 40.70 B    | 0.2           | 0.1
	@ember-data/store/-debug/index                                                     | 210.00 B  | 40.32 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-serializer-interface              | 169.00 B  | 32.45 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-record-wrapper                | 167.00 B  | 32.06 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-adapter-interface                 | 166.00 B  | 31.87 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-store-wrapper                 | 166.00 B  | 31.87 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/schema-definition-service                 | 166.00 B  | 31.87 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-json-api                      | 161.00 B  | 30.91 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/ember-data-json-api                       | 160.00 B  | 30.72 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-schemas                       | 160.00 B  | 30.72 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/promise-proxies                           | 156.00 B  | 29.95 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-instance                           | 156.00 B  | 29.95 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data                               | 152.00 B  | 29.18 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/ds-model                                  | 149.00 B  | 28.61 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/store                                     | 146.00 B  | 28.03 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/utils                                     | 146.00 B  | 28.03 B    | 0.1           | 0.1

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '32.66 KB' │
│  compressed  │ '6.27 KB'  │
│ % Of Library │   '14.8'   │
└──────────────┴────────────┘
	Module                                                                | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------
	@ember-data/model/-private/model                                      | 9.89 KB   | 1.90 KB    | 30.3          | 4.5
	@ember-data/model/-private/record-state                               | 6.20 KB   | 1.19 KB    | 19.0          | 2.8
	@ember-data/model/-private/system/promise-many-array                  | 3.80 KB   | 747.93 B   | 11.6          | 1.7
	@ember-data/model/-private/system/many-array                          | 2.85 KB   | 560.32 B   | 8.7           | 1.3
	@ember-data/model/-private/errors                                     | 2.08 KB   | 409.77 B   | 6.4           | 0.9
	@ember-data/model/-private/index                                      | 1.42 KB   | 279.58 B   | 4.4           | 0.6
	@ember-data/model/-private/system/relationships/relationship-meta     | 1.25 KB   | 246.36 B   | 3.8           | 0.6
	@ember-data/model/-private/attr                                       | 857.00 B  | 164.56 B   | 2.6           | 0.4
	@ember-data/model/-private/notify-changes                             | 845.00 B  | 162.26 B   | 2.5           | 0.4
	@ember-data/model/-private/belongs-to                                 | 687.00 B  | 131.92 B   | 2.1           | 0.3
	@ember-data/model/-private/has-many                                   | 648.00 B  | 124.43 B   | 1.9           | 0.3
	@ember-data/model/index                                               | 486.00 B  | 93.32 B    | 1.5           | 0.2
	@ember-data/model/-private/system/promise-belongs-to                  | 447.00 B  | 85.83 B    | 1.3           | 0.2
	@ember-data/model/-private/util                                       | 442.00 B  | 84.87 B    | 1.3           | 0.2
	@ember-data/model/-private/system/diff-array                          | 438.00 B  | 84.10 B    | 1.3           | 0.2
	@ember-data/model/-private/system/model-for-mixin                     | 427.00 B  | 81.99 B    | 1.3           | 0.2

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '30.80 KB' │
│  compressed  │ '5.91 KB'  │
│ % Of Library │   '14.0'   │
└──────────────┴────────────┘
	Module                                                                            | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private/record-data                                      | 8.18 KB   | 1.57 KB    | 26.6          | 3.7
	@ember-data/record-data/-private/graph/index                                      | 4.86 KB   | 955.51 B   | 15.8          | 2.2
	@ember-data/record-data/-private/graph/operations/replace-related-records         | 3.14 KB   | 617.35 B   | 10.2          | 1.4
	@ember-data/record-data/-private/graph/-edge-definition                           | 2.81 KB   | 553.41 B   | 9.1           | 1.3
	@ember-data/record-data/-private/relationships/state/has-many                     | 2.01 KB   | 395.18 B   | 6.5           | 0.9
	@ember-data/record-data/-private/relationships/state/belongs-to                   | 1.92 KB   | 378.09 B   | 6.2           | 0.9
	@ember-data/record-data/-private/graph/operations/update-relationship             | 1.50 KB   | 295.52 B   | 4.9           | 0.7
	@ember-data/record-data/-private/graph/-utils                                     | 1.05 KB   | 206.42 B   | 3.4           | 0.5
	@ember-data/record-data/-private/graph/operations/replace-related-record          | 1.04 KB   | 203.73 B   | 3.4           | 0.5
	@ember-data/record-data/-private/index                                            | 977.00 B  | 187.60 B   | 3.1           | 0.4
	@ember-data/record-data/-private/graph/operations/add-to-related-records          | 788.00 B  | 151.31 B   | 2.5           | 0.3
	@ember-data/record-data/-private/relationships/state/implicit                     | 692.00 B  | 132.88 B   | 2.2           | 0.3
	@ember-data/record-data/-private/graph/operations/remove-from-related-records     | 667.00 B  | 128.07 B   | 2.1           | 0.3
	@ember-data/record-data/-private/coerce-id                                        | 406.00 B  | 77.96 B    | 1.3           | 0.2
	@ember-data/record-data/-private/graph/-state                                     | 293.00 B  | 56.26 B    | 0.9           | 0.1
	@ember-data/record-data/-private/normalize-link                                   | 238.00 B  | 45.70 B    | 0.8           | 0.1
	@ember-data/record-data/-private/ts-interfaces/relationship-record-data           | 171.00 B  | 32.83 B    | 0.5           | 0.1
	@ember-data/record-data/-private/graph/-operations                                | 150.00 B  | 28.80 B    | 0.5           | 0.1

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.06 KB' │
│  compressed  │ '4.24 KB'  │
│ % Of Library │   '10.0'   │
└──────────────┴────────────┘
	Module                                                     | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                                | 7.19 KB   | 1.38 KB    | 32.6          | 3.3
	@ember-data/serializer/-private/embedded-records-mixin     | 4.39 KB   | 862.37 B   | 19.9          | 2.0
	@ember-data/serializer/json-api                            | 3.73 KB   | 732.76 B   | 16.9          | 1.7
	@ember-data/serializer/rest                                | 2.76 KB   | 542.85 B   | 12.5          | 1.3
	@ember-data/serializer/-private/index                      | 1.18 KB   | 232.34 B   | 5.4           | 0.5
	@ember-data/serializer/-private/transforms/date            | 523.00 B  | 100.42 B   | 2.3           | 0.2
	@ember-data/serializer/-private/transforms/boolean         | 507.00 B  | 97.35 B    | 2.2           | 0.2
	@ember-data/serializer/-private/transforms/number          | 446.00 B  | 85.64 B    | 2.0           | 0.2
	@ember-data/serializer/-private/transforms/string          | 368.00 B  | 70.66 B    | 1.6           | 0.2
	@ember-data/serializer/-private/utils                      | 303.00 B  | 58.18 B    | 1.3           | 0.1
	@ember-data/serializer/index                               | 258.00 B  | 49.54 B    | 1.1           | 0.1
	@ember-data/serializer/-private/transforms/transform       | 257.00 B  | 49.35 B    | 1.1           | 0.1
	@ember-data/serializer/transform                           | 215.00 B  | 41.28 B    | 1.0           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '18.05 KB' │
│  compressed  │ '3.47 KB'  │
│ % Of Library │   '8.2'    │
└──────────────┴────────────┘
	Module                                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                                      | 8.07 KB   | 1.55 KB    | 44.7          | 3.7
	@ember-data/adapter/error                                     | 1.94 KB   | 381.93 B   | 10.8          | 0.9
	@ember-data/adapter/-private/build-url-mixin                  | 1.93 KB   | 378.67 B   | 10.7          | 0.9
	@ember-data/adapter/index                                     | 1.10 KB   | 216.02 B   | 6.1           | 0.5
	@ember-data/adapter/json-api                                  | 1.04 KB   | 205.08 B   | 5.8           | 0.5
	@ember-data/adapter/-private/index                            | 1.03 KB   | 202.77 B   | 5.7           | 0.5
	@ember-data/adapter/-private/utils/serialize-query-params     | 788.00 B  | 151.31 B   | 4.3           | 0.3
	@ember-data/adapter/-private/utils/determine-body-promise     | 566.00 B  | 108.68 B   | 3.1           | 0.3
	@ember-data/adapter/-private/utils/parse-response-headers     | 480.00 B  | 92.17 B    | 2.6           | 0.2
	@ember-data/adapter/-private/utils/fetch                      | 454.00 B  | 87.17 B    | 2.5           | 0.2
	@ember-data/adapter/-private/utils/serialize-into-hash        | 347.00 B  | 66.63 B    | 1.9           | 0.2
	@ember-data/adapter/-private/utils/continue-on-reject         | 222.00 B  | 42.62 B    | 1.2           | 0.1
	@ember-data/adapter/-private/fastboot-interface               | 147.00 B  | 28.22 B    | 0.8           | 0.1

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.52 KB' │
│  compressed  │ '1.83 KB' │
│ % Of Library │   '4.3'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 475.06 B   | 25.4          | 1.1
	ember-data/-private/index                         | 1.93 KB   | 379.05 B   | 20.2          | 0.9
	ember-data/adapters/errors                        | 1.19 KB   | 233.69 B   | 12.5          | 0.5
	ember-data/setup-container                        | 387.00 B  | 74.31 B    | 4.0           | 0.2
	ember-data/-private/core                          | 366.00 B  | 70.28 B    | 3.8           | 0.2
	ember-data/relationships                          | 318.00 B  | 61.06 B    | 3.3           | 0.1
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 52.61 B    | 2.8           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 48.19 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 47.04 B    | 2.5           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 46.66 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 46.66 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 46.27 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 45.50 B    | 2.4           | 0.1
	ember-data/serializer                             | 232.00 B  | 44.54 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 43.39 B    | 2.3           | 0.1
	ember-data/model                                  | 222.00 B  | 42.62 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 42.62 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 41.86 B    | 2.2           | 0.1
	ember-data/version                                | 162.00 B  | 31.10 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.71 KB' │
│  compressed  │ '1.29 KB' │
│ % Of Library │   '3.0'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.89 KB   | 569.15 B   | 43.1          | 1.3
	ember-inflector/lib/system/inflections            | 1.59 KB   | 312.42 B   | 23.7          | 0.7
	ember-inflector/index                             | 473.00 B  | 90.82 B    | 6.9           | 0.2
	ember-inflector/lib/system                        | 471.00 B  | 90.44 B    | 6.9           | 0.2
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 71.62 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 67.59 B    | 5.1           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 61.06 B    | 4.6           | 0.1
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 56.83 B    | 4.3           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.81 KB'  │
│  compressed  │ '552.26 B' │
│ % Of Library │   '1.3'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.32 KB   | 456.44 B   | 82.6          | 1.1
	@ember-data/debug/setup                           | 499.00 B  | 95.81 B    | 17.4          | 0.2

@github-actions
Copy link

github-actions bot commented Oct 18, 2021 •
edited
Loading

Performance Report for acb3cf6

Scenario - materialization: ☑️ Performance is stable

☑️ duration
phase no difference [-25ms to 25ms]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-18ms to 2ms]
☑️ Phase [start-find-all] => [start-materialization]
phase no difference [-6ms to 20ms]
☑️ Phase [start-materialization] => [end-materialization]
phase no difference [-11ms to 1ms]
☑️ Phase [end-materialization] => [Test End]
phase no difference [-2ms to 7ms]

Scenario - unload: ☑️ Performance is stable

☑️ duration
phase no difference [-19ms to 18ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-6ms to 10ms]
☑️ Phase [start-push-payload] => [start-unload-records]
phase no difference [-16ms to 9ms]
☑️ Phase [start-unload-records] => [end-unload-records]
phase no difference [-5ms to 4ms]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [-1ms to 1ms]

Scenario - destroy: ☑️ Performance is stable

☑️ duration
phase no difference [-10ms to 25ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-7ms to 9ms]
☑️ Phase [start-push-payload] => [start-destroy-records]
phase no difference [-8ms to 15ms]
☑️ Phase [start-destroy-records] => [end-destroy-records]
phase no difference [-5ms to 7ms]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [-1ms to 1ms]

Scenario - add-children: ☑️ Performance is stable

☑️ duration
phase no difference [-18ms to 7ms]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-19ms to 1ms]
☑️ Phase [start-push-initial-payload] => [start-push-update-payload]
phase no difference [-6ms to 5ms]
☑️ Phase [start-push-update-payload] => [end-push-update-payload]
phase no difference [-1ms to 4ms]
⚠️ Phase [end-push-update-payload] => [Test End]
phase estimated regression +2ms [1ms to 3ms] OR +1.75% [0.69% to 2.93%]

Scenario - unused-relationships: ☑️ Performance is stable

☑️ duration
phase no difference [-12ms to 24ms]
⚠️ Phase [navigationStart] => [start-push-payload]
phase estimated regression +9ms [1ms to 17ms] OR +1.11% [0.18% to 2.09%]
☑️ Phase [start-push-payload] => [end-push-payload]
phase no difference [-17ms to 11ms]
☑️ Phase [end-push-payload] => [Test End]
phase no difference [-2ms to 2ms]

@snewcomer snewcomer mentioned this pull request Oct 20, 2021
Closed
4 tasks
@snewcomer snewcomer force-pushed the sn/deprecated-assign branch from 291942e to 94822ef Compare November 4, 2021 21:31
@snewcomer snewcomer requested a review from igorT November 4, 2021 21:42
@snewcomer snewcomer marked this pull request as ready for review November 4, 2021 21:46
igorT
igorT approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@igorT igorT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after the spread to assign change

@snewcomer snewcomer force-pushed the sn/deprecated-assign branch from 70f0028 to acb3cf6 Compare November 5, 2021 03:28
@snewcomer snewcomer merged commit b160113 into master Nov 5, 2021
@snewcomer snewcomer deleted the sn/deprecated-assign branch November 5, 2021 04:08
@kategengler
Copy link
Member

@igorT Can this be backported to 4.0 beta? Without this, there are deprecations in brand new 4.0 apps using ember-data.

igorT pushed a commit that referenced this pull request Nov 8, 2021
@snewcomer @igorT
Fix deprecated assign usage from @ember/assign (#7722)
f636491 
* Fix deprecated assign usage from @ember/assign

* assign -> Object.assign

* fix with Object.assign
@igorT igorT mentioned this pull request Nov 8, 2021
Merged
igorT added a commit that referenced this pull request Nov 10, 2021
@igorT
Fix deprecated assign usage from @ember/assign (#7722) (#7748)
c70161f 
* Fix deprecated assign usage from @ember/assign
Co-authored-by: Scott Newcomer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorT igorT igorT approved these changes

Assignees

@snewcomer snewcomer

Labels
🎯 canary PR is targeting canary (default) 🏷️ chore This PR primarily refactors code or updates dependencies 🏷️ cleanup This PR primarily removes deprecated functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snewcomer @kategengler @igorT