Return inflight requests for findRecord when CUSTOM_MODEL_CLASS is on #7651

igorT · 2021-08-05T16:03:20Z

This broke with CUSTOM_MODEL_CLASSES as we were not caching the requests correctly.

snewcomer

This looks great! 👍

github-actions · 2021-08-05T19:11:16Z

Asset Size Report for 3fa6c19

IE11 Builds

EmberData increased by +229.0 B uncompressed but decreased by -65.0 B compressed

Warnings

⚠️ The uncompressed size of the package @ember-data/store has increased by +229.0 B.

Changeset


EmberData +198.27 KB +229.0 B (+40.75 KB -65.0 B compressed)
    @ember-data/store +81.74 KB +229.0 B (+16.8 KB -65.0 B compressed)
        @ember-data/store/-private +80.82 KB +229.0 B (+16.61 KB -65.0 B compressed)

Full Asset Analysis (IE11)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '198.27 KB' │
│ compressed │ '40.75 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '81.74 KB' │
│  compressed  │ '16.80 KB' │
│ % Of Library │   '41.2'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 80.82 KB  | 16.61 KB   | 98.9          | 40.8
	@ember-data/store/index                           | 936.00 B  | 192.37 B   | 1.1           | 0.5

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '32.11 KB' │
│  compressed  │ '6.60 KB'  │
│ % Of Library │   '16.2'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 31.63 KB  | 6.50 KB    | 98.5          | 16.0
	@ember-data/model/index                           | 486.00 B  | 99.88 B    | 1.5           | 0.2

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '25.74 KB' │
│  compressed  │ '5.29 KB'  │
│ % Of Library │   '13.0'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 25.74 KB  | 5.29 KB    | 100.0         | 13.0

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '21.13 KB' │
│  compressed  │ '4.34 KB'  │
│ % Of Library │   '10.7'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.84 KB   | 1.61 KB    | 37.1          | 4.0
	@ember-data/serializer/-private                   | 5.81 KB   | 1.19 KB    | 27.5          | 2.9
	@ember-data/serializer/json-api                   | 3.96 KB   | 832.99 B   | 18.7          | 2.0
	@ember-data/serializer/rest                       | 3.04 KB   | 640.83 B   | 14.4          | 1.5
	@ember-data/serializer/index                      | 273.00 B  | 56.10 B    | 1.3           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 44.18 B    | 1.0           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '17.93 KB' │
│  compressed  │ '3.68 KB'  │
│ % Of Library │   '9.0'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 9.23 KB   | 1.90 KB    | 51.5          | 4.7
	@ember-data/adapter/-private                      | 3.84 KB   | 808.12 B   | 21.4          | 1.9
	@ember-data/adapter/error                         | 1.98 KB   | 415.98 B   | 11.0          | 1.0
	@ember-data/adapter/index                         | 1.51 KB   | 317.94 B   | 8.4           | 0.8
	@ember-data/adapter/json-api                      | 1.37 KB   | 288.35 B   | 7.6           | 0.7

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.49 KB' │
│  compressed  │ '1.95 KB' │
│ % Of Library │   '4.8'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 508.47 B   | 25.5          | 1.2
	ember-data/-private                               | 2.12 KB   | 446.40 B   | 22.4          | 1.1
	ember-data/adapters/errors                        | 1.19 KB   | 250.12 B   | 12.5          | 0.6
	ember-data/setup-container                        | 520.00 B  | 106.87 B   | 5.4           | 0.3
	ember-data/relationships                          | 318.00 B  | 65.35 B    | 3.3           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 56.31 B    | 2.8           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 51.58 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 50.35 B    | 2.5           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 49.94 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 49.94 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 49.53 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 48.70 B    | 2.4           | 0.1
	ember-data/serializer                             | 232.00 B  | 47.68 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 46.44 B    | 2.3           | 0.1
	ember-data/model                                  | 222.00 B  | 45.62 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 45.62 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 44.80 B    | 2.2           | 0.1
	ember-data/version                                | 163.00 B  | 33.50 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '7.07 KB' │
│  compressed  │ '1.45 KB' │
│ % Of Library │   '3.6'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 3.11 KB   | 654.39 B   | 44.0          | 1.6
	ember-inflector/lib/system/inflections            | 1.59 KB   | 334.38 B   | 22.5          | 0.8
	ember-inflector/lib/helpers/pluralize             | 506.00 B  | 103.99 B   | 7.0           | 0.2
	ember-inflector/index                             | 473.00 B  | 97.21 B    | 6.5           | 0.2
	ember-inflector/lib/system                        | 471.00 B  | 96.80 B    | 6.5           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 72.34 B    | 4.9           | 0.2
	ember-inflector/lib/system/string                 | 332.00 B  | 68.23 B    | 4.6           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 60.83 B    | 4.1           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '3.07 KB'  │
│  compressed  │ '645.76 B' │
│ % Of Library │   '1.5'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.58 KB   | 542.99 B   | 84.1          | 1.3
	@ember-data/debug/setup                           | 500.00 B  | 102.76 B   | 15.9          | 0.2

Modern Builds

🛑 The size of the library EmberData has increased by +202.0 B (+17.0 B compressed) which exceeds the failure threshold of 75 bytes.

Warnings

⚠️ The uncompressed size of the package @ember-data/store has increased by +202.0 B.

Changeset


EmberData +179.1 KB +202.0 B (+39.01 KB +17.0 B compressed)
    @ember-data/store +72.14 KB +202.0 B (+15.71 KB +17.0 B compressed)
        @ember-data/store/-private +71.23 KB +202.0 B (+15.52 KB +17.0 B compressed)

Full Asset Analysis (Modern)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '179.10 KB' │
│ compressed │ '39.01 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '72.14 KB' │
│  compressed  │ '15.71 KB' │
│ % Of Library │   '40.3'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 71.23 KB  | 15.52 KB   | 98.7          | 39.8
	@ember-data/store/index                           | 936.00 B  | 203.88 B   | 1.3           | 0.5

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '28.56 KB' │
│  compressed  │ '6.22 KB'  │
│ % Of Library │   '15.9'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 28.08 KB  | 6.12 KB    | 98.3          | 15.7
	@ember-data/model/index                           | 486.00 B  | 105.86 B   | 1.7           | 0.3

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '23.77 KB' │
│  compressed  │ '5.18 KB'  │
│ % Of Library │   '13.3'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 23.77 KB  | 5.18 KB    | 100.0         | 13.3

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '19.65 KB' │
│  compressed  │ '4.28 KB'  │
│ % Of Library │   '11.0'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.21 KB   | 1.57 KB    | 36.7          | 4.0
	@ember-data/serializer/-private                   | 5.49 KB   | 1.20 KB    | 27.9          | 3.1
	@ember-data/serializer/json-api                   | 3.73 KB   | 831.23 B   | 19.0          | 2.1
	@ember-data/serializer/rest                       | 2.76 KB   | 616.01 B   | 14.1          | 1.5
	@ember-data/serializer/index                      | 258.00 B  | 56.19 B    | 1.3           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 46.83 B    | 1.1           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.98 KB' │
│  compressed  │ '3.48 KB'  │
│ % Of Library │   '8.9'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 8.13 KB   | 1.77 KB    | 50.8          | 4.5
	@ember-data/adapter/-private                      | 3.77 KB   | 841.25 B   | 23.6          | 2.1
	@ember-data/adapter/error                         | 1.94 KB   | 433.25 B   | 12.2          | 1.1
	@ember-data/adapter/index                         | 1.10 KB   | 245.05 B   | 6.9           | 0.6
	@ember-data/adapter/json-api                      | 1.04 KB   | 232.63 B   | 6.5           | 0.6

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.49 KB' │
│  compressed  │ '2.07 KB' │
│ % Of Library │   '5.3'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 538.90 B   | 25.5          | 1.3
	ember-data/-private                               | 2.12 KB   | 473.12 B   | 22.4          | 1.2
	ember-data/adapters/errors                        | 1.19 KB   | 265.09 B   | 12.5          | 0.7
	ember-data/setup-container                        | 520.00 B  | 113.27 B   | 5.4           | 0.3
	ember-data/relationships                          | 318.00 B  | 69.26 B    | 3.3           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 59.68 B    | 2.8           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 54.67 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 53.36 B    | 2.5           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 52.93 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 52.93 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 52.49 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 51.62 B    | 2.4           | 0.1
	ember-data/serializer                             | 232.00 B  | 50.53 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 49.22 B    | 2.3           | 0.1
	ember-data/model                                  | 222.00 B  | 48.35 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 48.35 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 47.48 B    | 2.2           | 0.1
	ember-data/version                                | 163.00 B  | 35.50 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.70 KB' │
│  compressed  │ '1.46 KB' │
│ % Of Library │   '3.7'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.88 KB   | 642.37 B   | 43.0          | 1.6
	ember-inflector/lib/system/inflections            | 1.59 KB   | 354.40 B   | 23.7          | 0.9
	ember-inflector/index                             | 473.00 B  | 103.03 B   | 6.9           | 0.3
	ember-inflector/lib/system                        | 471.00 B  | 102.59 B   | 6.9           | 0.3
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 81.24 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 76.67 B    | 5.1           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 69.26 B    | 4.6           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 64.47 B    | 4.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.81 KB'  │
│  compressed  │ '626.47 B' │
│ % Of Library │   '1.6'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.32 KB   | 517.77 B   | 82.6          | 1.3
	@ember-data/debug/setup                           | 499.00 B  | 108.69 B   | 17.4          | 0.3

Modern Builds (No Rollup)

🛑 The size of the library EmberData has increased by +150.0 B (+33.0 B compressed) which exceeds the failure threshold of 75 bytes.

Warnings

⚠️ The uncompressed size of the package @ember-data/store has increased by +150.0 B.

Changeset


EmberData +220.72 KB +150.0 B (+42.42 KB +33.0 B compressed)
    @ember-data/store +97.87 KB +150.0 B (+18.81 KB +33.0 B compressed)
        @ember-data/store/-private/system/core-store +17.3 KB +2.0 B (+3.33 KB +0.44 B compressed)
        @ember-data/store/-private/system/fetch-manager +5.09 KB +148.0 B (+1002.0 B +32.56 B compressed)

Full Asset Analysis (Modern)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '220.72 KB' │
│ compressed │ '42.42 KB'  │
│  packages  │      8      │
│  modules   │     149     │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '97.87 KB' │
│  compressed  │ '18.81 KB' │
│ % Of Library │   '44.3'   │
└──────────────┴────────────┘
	Module                                                                             | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/store/-private/system/core-store                                       | 17.30 KB  | 3.33 KB    | 17.7          | 7.8
	@ember-data/store/-private/system/model/internal-model                             | 14.45 KB  | 2.78 KB    | 14.8          | 6.5
	@ember-data/store/-private/system/model/states                                     | 5.44 KB   | 1.05 KB    | 5.6           | 2.5
	@ember-data/store/-private/system/fetch-manager                                    | 5.09 KB   | 1002.00 B  | 5.2           | 2.3
	@ember-data/store/-private/system/store/finders                                    | 4.57 KB   | 900.15 B   | 4.7           | 2.1
	@ember-data/store/-private/system/record-array-manager                             | 4.19 KB   | 823.85 B   | 4.3           | 1.9
	@ember-data/store/-private/identifiers/cache                                       | 3.98 KB   | 783.69 B   | 4.1           | 1.8
	@ember-data/store/-private/index                                                   | 3.57 KB   | 702.40 B   | 3.6           | 1.6
	@ember-data/store/-private/system/store/record-data-store-wrapper                  | 3.41 KB   | 670.30 B   | 3.5           | 1.5
	@ember-data/store/-private/system/snapshot                                         | 3.10 KB   | 610.92 B   | 3.2           | 1.4
	@ember-data/store/-private/system/store/internal-model-factory                     | 2.82 KB   | 555.58 B   | 2.9           | 1.3
	@ember-data/store/-private/system/record-arrays/record-array                       | 2.28 KB   | 448.92 B   | 2.3           | 1.0
	@ember-data/store/-private/system/ds-model-store                                   | 1.96 KB   | 385.88 B   | 2.0           | 0.9
	@ember-data/store/-private/system/request-cache                                    | 1.89 KB   | 371.09 B   | 1.9           | 0.9
	@ember-data/store/-private/system/references/has-many                              | 1.53 KB   | 301.52 B   | 1.6           | 0.7
	@ember-data/store/-private/system/schema-definition-service                        | 1.51 KB   | 297.68 B   | 1.5           | 0.7
	@ember-data/store/-private/system/references/belongs-to                            | 1.32 KB   | 260.20 B   | 1.4           | 0.6
	@ember-data/store/-private/system/model/shim-model-class                           | 1.32 KB   | 259.24 B   | 1.3           | 0.6
	@ember-data/store/-private/system/store/serializer-response                        | 1.14 KB   | 224.46 B   | 1.2           | 0.5
	@ember-data/store/-private/identifiers/utils/uuid-v4                               | 1.05 KB   | 207.16 B   | 1.1           | 0.5
	@ember-data/store/-private/system/references/record                                | 982.00 B  | 188.71 B   | 1.0           | 0.4
	@ember-data/store/-private/system/record-arrays/adapter-populated-record-array     | 967.00 B  | 185.83 B   | 1.0           | 0.4
	@ember-data/store/index                                                            | 936.00 B  | 179.87 B   | 0.9           | 0.4
	@ember-data/store/-private/system/references/reference                             | 934.00 B  | 179.49 B   | 0.9           | 0.4
	@ember-data/store/-private/system/internal-model-map                               | 886.00 B  | 170.26 B   | 0.9           | 0.4
	@ember-data/store/-private/system/errors-utils                                     | 798.00 B  | 153.35 B   | 0.8           | 0.4
	@ember-data/store/-private/system/snapshot-record-array                            | 753.00 B  | 144.70 B   | 0.8           | 0.3
	@ember-data/store/-private/system/record-notification-manager                      | 697.00 B  | 133.94 B   | 0.7           | 0.3
	@ember-data/store/-private/utils/construct-resource                                | 695.00 B  | 133.56 B   | 0.7           | 0.3
	@ember-data/store/-private/system/promise-proxies                                  | 607.00 B  | 116.65 B   | 0.6           | 0.3
	@ember-data/store/-private/system/references                                       | 598.00 B  | 114.92 B   | 0.6           | 0.3
	@ember-data/store/-private/system/store/common                                     | 527.00 B  | 101.27 B   | 0.5           | 0.2
	@ember-data/store/-private/system/coerce-id                                        | 496.00 B  | 95.31 B    | 0.5           | 0.2
	@ember-data/store/-private/system/record-arrays                                    | 487.00 B  | 93.58 B    | 0.5           | 0.2
	@ember-data/store/-private/system/identity-map                                     | 450.00 B  | 86.47 B    | 0.4           | 0.2
	@ember-data/store/-private/ts-interfaces/identifier                                | 400.00 B  | 76.87 B    | 0.4           | 0.2
	@ember-data/store/-private/utils/symbol                                            | 393.00 B  | 75.52 B    | 0.4           | 0.2
	@ember-data/store/-private/system/record-data-for                                  | 390.00 B  | 74.94 B    | 0.4           | 0.2
	@ember-data/store/-private/identifiers/is-stable-identifier                        | 327.00 B  | 62.84 B    | 0.3           | 0.1
	@ember-data/store/-private/ts-interfaces/fetch-manager                             | 316.00 B  | 60.72 B    | 0.3           | 0.1
	@ember-data/store/-private/utils/promise-record                                    | 290.00 B  | 55.73 B    | 0.3           | 0.1
	@ember-data/store/-private/system/backburner                                       | 269.00 B  | 51.69 B    | 0.3           | 0.1
	@ember-data/store/-private/system/deprecated-evented                               | 257.00 B  | 49.38 B    | 0.3           | 0.1
	@ember-data/store/-private/system/normalize-model-name                             | 220.00 B  | 42.27 B    | 0.2           | 0.1
	@ember-data/store/-private/utils/is-non-empty-string                               | 212.00 B  | 40.74 B    | 0.2           | 0.1
	@ember-data/store/-debug/index                                                     | 210.00 B  | 40.35 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-serializer-interface              | 169.00 B  | 32.47 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-record-wrapper                | 167.00 B  | 32.09 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-adapter-interface                 | 166.00 B  | 31.90 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-store-wrapper                 | 166.00 B  | 31.90 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/schema-definition-service                 | 166.00 B  | 31.90 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-json-api                      | 161.00 B  | 30.94 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/ember-data-json-api                       | 160.00 B  | 30.74 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-schemas                       | 160.00 B  | 30.74 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/promise-proxies                           | 156.00 B  | 29.97 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-instance                           | 156.00 B  | 29.97 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data                               | 152.00 B  | 29.21 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/ds-model                                  | 149.00 B  | 28.63 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/store                                     | 146.00 B  | 28.05 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/utils                                     | 146.00 B  | 28.05 B    | 0.1           | 0.1

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '32.67 KB' │
│  compressed  │ '6.28 KB'  │
│ % Of Library │   '14.8'   │
└──────────────┴────────────┘
	Module                                                                | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------
	@ember-data/model/-private/model                                      | 9.89 KB   | 1.90 KB    | 30.3          | 4.5
	@ember-data/model/-private/record-state                               | 6.20 KB   | 1.19 KB    | 19.0          | 2.8
	@ember-data/model/-private/system/promise-many-array                  | 3.80 KB   | 748.52 B   | 11.6          | 1.7
	@ember-data/model/-private/system/many-array                          | 2.85 KB   | 560.76 B   | 8.7           | 1.3
	@ember-data/model/-private/errors                                     | 2.08 KB   | 410.10 B   | 6.4           | 0.9
	@ember-data/model/-private/index                                      | 1.42 KB   | 279.80 B   | 4.4           | 0.6
	@ember-data/model/-private/system/relationships/relationship-meta     | 1.25 KB   | 246.56 B   | 3.8           | 0.6
	@ember-data/model/-private/attr                                       | 857.00 B  | 164.69 B   | 2.6           | 0.4
	@ember-data/model/-private/notify-changes                             | 845.00 B  | 162.38 B   | 2.5           | 0.4
	@ember-data/model/-private/belongs-to                                 | 687.00 B  | 132.02 B   | 2.1           | 0.3
	@ember-data/model/-private/has-many                                   | 648.00 B  | 124.52 B   | 1.9           | 0.3
	@ember-data/model/index                                               | 486.00 B  | 93.39 B    | 1.5           | 0.2
	@ember-data/model/-private/system/promise-belongs-to                  | 447.00 B  | 85.90 B    | 1.3           | 0.2
	@ember-data/model/-private/util                                       | 442.00 B  | 84.94 B    | 1.3           | 0.2
	@ember-data/model/-private/system/diff-array                          | 438.00 B  | 84.17 B    | 1.3           | 0.2
	@ember-data/model/-private/system/model-for-mixin                     | 431.00 B  | 82.82 B    | 1.3           | 0.2

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '30.84 KB' │
│  compressed  │ '5.93 KB'  │
│ % Of Library │   '14.0'   │
└──────────────┴────────────┘
	Module                                                                            | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private/record-data                                      | 8.21 KB   | 1.58 KB    | 26.6          | 3.7
	@ember-data/record-data/-private/graph/index                                      | 4.86 KB   | 956.26 B   | 15.8          | 2.2
	@ember-data/record-data/-private/graph/operations/replace-related-records         | 3.14 KB   | 617.84 B   | 10.2          | 1.4
	@ember-data/record-data/-private/graph/-edge-definition                           | 2.83 KB   | 556.73 B   | 9.2           | 1.3
	@ember-data/record-data/-private/relationships/state/has-many                     | 2.01 KB   | 395.49 B   | 6.5           | 0.9
	@ember-data/record-data/-private/relationships/state/belongs-to                   | 1.92 KB   | 378.39 B   | 6.2           | 0.9
	@ember-data/record-data/-private/graph/operations/update-relationship             | 1.50 KB   | 295.75 B   | 4.9           | 0.7
	@ember-data/record-data/-private/graph/-utils                                     | 1.05 KB   | 206.58 B   | 3.4           | 0.5
	@ember-data/record-data/-private/graph/operations/replace-related-record          | 1.04 KB   | 203.89 B   | 3.4           | 0.5
	@ember-data/record-data/-private/index                                            | 977.00 B  | 187.75 B   | 3.1           | 0.4
	@ember-data/record-data/-private/graph/operations/add-to-related-records          | 788.00 B  | 151.43 B   | 2.5           | 0.3
	@ember-data/record-data/-private/relationships/state/implicit                     | 692.00 B  | 132.98 B   | 2.2           | 0.3
	@ember-data/record-data/-private/graph/operations/remove-from-related-records     | 667.00 B  | 128.18 B   | 2.1           | 0.3
	@ember-data/record-data/-private/coerce-id                                        | 406.00 B  | 78.02 B    | 1.3           | 0.2
	@ember-data/record-data/-private/graph/-state                                     | 293.00 B  | 56.30 B    | 0.9           | 0.1
	@ember-data/record-data/-private/normalize-link                                   | 238.00 B  | 45.73 B    | 0.8           | 0.1
	@ember-data/record-data/-private/ts-interfaces/relationship-record-data           | 171.00 B  | 32.86 B    | 0.5           | 0.1
	@ember-data/record-data/-private/graph/-operations                                | 150.00 B  | 28.82 B    | 0.5           | 0.1

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.08 KB' │
│  compressed  │ '4.24 KB'  │
│ % Of Library │   '10.0'   │
└──────────────┴────────────┘
	Module                                                     | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                                | 7.21 KB   | 1.39 KB    | 32.7          | 3.3
	@ember-data/serializer/-private/embedded-records-mixin     | 4.39 KB   | 863.44 B   | 19.9          | 2.0
	@ember-data/serializer/json-api                            | 3.73 KB   | 733.34 B   | 16.9          | 1.7
	@ember-data/serializer/rest                                | 2.76 KB   | 543.47 B   | 12.5          | 1.3
	@ember-data/serializer/-private/index                      | 1.18 KB   | 232.53 B   | 5.4           | 0.5
	@ember-data/serializer/-private/transforms/date            | 523.00 B  | 100.50 B   | 2.3           | 0.2
	@ember-data/serializer/-private/transforms/boolean         | 507.00 B  | 97.43 B    | 2.2           | 0.2
	@ember-data/serializer/-private/transforms/number          | 446.00 B  | 85.71 B    | 2.0           | 0.2
	@ember-data/serializer/-private/transforms/string          | 368.00 B  | 70.72 B    | 1.6           | 0.2
	@ember-data/serializer/-private/utils                      | 303.00 B  | 58.22 B    | 1.3           | 0.1
	@ember-data/serializer/index                               | 258.00 B  | 49.58 B    | 1.1           | 0.1
	@ember-data/serializer/-private/transforms/transform       | 257.00 B  | 49.38 B    | 1.1           | 0.1
	@ember-data/serializer/transform                           | 215.00 B  | 41.31 B    | 1.0           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '18.11 KB' │
│  compressed  │ '3.48 KB'  │
│ % Of Library │   '8.2'    │
└──────────────┴────────────┘
	Module                                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                                      | 8.13 KB   | 1.56 KB    | 44.9          | 3.7
	@ember-data/adapter/error                                     | 1.94 KB   | 382.23 B   | 10.7          | 0.9
	@ember-data/adapter/-private/build-url-mixin                  | 1.93 KB   | 380.50 B   | 10.7          | 0.9
	@ember-data/adapter/index                                     | 1.10 KB   | 216.19 B   | 6.1           | 0.5
	@ember-data/adapter/json-api                                  | 1.04 KB   | 205.24 B   | 5.8           | 0.5
	@ember-data/adapter/-private/index                            | 1.03 KB   | 202.93 B   | 5.7           | 0.5
	@ember-data/adapter/-private/utils/serialize-query-params     | 792.00 B  | 152.20 B   | 4.3           | 0.4
	@ember-data/adapter/-private/utils/determine-body-promise     | 566.00 B  | 108.77 B   | 3.1           | 0.3
	@ember-data/adapter/-private/utils/parse-response-headers     | 480.00 B  | 92.24 B    | 2.6           | 0.2
	@ember-data/adapter/-private/utils/fetch                      | 454.00 B  | 87.24 B    | 2.4           | 0.2
	@ember-data/adapter/-private/utils/serialize-into-hash        | 347.00 B  | 66.68 B    | 1.9           | 0.2
	@ember-data/adapter/-private/utils/continue-on-reject         | 222.00 B  | 42.66 B    | 1.2           | 0.1
	@ember-data/adapter/-private/fastboot-interface               | 147.00 B  | 28.24 B    | 0.8           | 0.1

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.65 KB' │
│  compressed  │ '1.86 KB' │
│ % Of Library │   '4.4'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 475.44 B   | 25.0          | 1.1
	ember-data/-private/index                         | 1.93 KB   | 379.35 B   | 20.0          | 0.9
	ember-data/adapters/errors                        | 1.19 KB   | 233.87 B   | 12.3          | 0.5
	ember-data/setup-container                        | 520.00 B  | 99.93 B    | 5.3           | 0.2
	ember-data/-private/core                          | 366.00 B  | 70.33 B    | 3.7           | 0.2
	ember-data/relationships                          | 318.00 B  | 61.11 B    | 3.2           | 0.1
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 52.65 B    | 2.8           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 48.23 B    | 2.5           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 47.08 B    | 2.5           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 46.69 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 46.69 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 46.31 B    | 2.4           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 45.54 B    | 2.4           | 0.1
	ember-data/serializer                             | 232.00 B  | 44.58 B    | 2.3           | 0.1
	ember-data/adapter                                | 226.00 B  | 43.43 B    | 2.3           | 0.1
	ember-data/model                                  | 222.00 B  | 42.66 B    | 2.2           | 0.1
	ember-data/store                                  | 222.00 B  | 42.66 B    | 2.2           | 0.1
	ember-data/attr                                   | 218.00 B  | 41.89 B    | 2.2           | 0.1
	ember-data/version                                | 163.00 B  | 31.32 B    | 1.6           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.70 KB' │
│  compressed  │ '1.29 KB' │
│ % Of Library │   '3.0'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.88 KB   | 566.72 B   | 43.0          | 1.3
	ember-inflector/lib/system/inflections            | 1.59 KB   | 312.66 B   | 23.7          | 0.7
	ember-inflector/index                             | 473.00 B  | 90.89 B    | 6.9           | 0.2
	ember-inflector/lib/system                        | 471.00 B  | 90.51 B    | 6.9           | 0.2
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 71.68 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 67.64 B    | 5.1           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 61.11 B    | 4.6           | 0.1
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 56.88 B    | 4.3           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.81 KB'  │
│  compressed  │ '552.69 B' │
│ % Of Library │   '1.3'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.32 KB   | 456.79 B   | 82.6          | 1.1
	@ember-data/debug/setup                           | 499.00 B  | 95.89 B    | 17.4          | 0.2

github-actions · 2021-08-05T19:37:42Z

Performance Report for 3fa6c19

Scenario - materialization: ☑️ Performance is stable

☑️ duration
phase no difference [-30ms to 7ms]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-3ms to 27ms]
✅ Phase [start-find-all] => [start-materialization]
phase estimated improvement -20ms [-34ms to -6ms] OR -1.77% [-3.05% to -0.51%]
☑️ Phase [start-materialization] => [end-materialization]
phase no difference [-2ms to 5ms]
☑️ Phase [end-materialization] => [Test End]
phase no difference [-3ms to 5ms]

Scenario - unload: ☑️ Performance is stable

☑️ duration
phase no difference [-18ms to 15ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-8ms to 10ms]
☑️ Phase [start-push-payload] => [start-unload-records]
phase no difference [-12ms to 15ms]
☑️ Phase [start-unload-records] => [end-unload-records]
phase no difference [-7ms to 0ms]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [0ms to 0ms]

Scenario - destroy: ☑️ Performance is stable

☑️ duration
phase no difference [-6ms to 28ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-10ms to 8ms]
☑️ Phase [start-push-payload] => [start-destroy-records]
phase no difference [-5ms to 20ms]
⚠️ Phase [start-destroy-records] => [end-destroy-records]
phase estimated regression +5ms [1ms to 11ms] OR +0.47% [0.05% to 0.9%]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [0ms to 1ms]

Scenario - add-children: ☑️ Performance is stable

☑️ duration
phase no difference [-13ms to 15ms]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-7ms to 14ms]
☑️ Phase [start-push-initial-payload] => [start-push-update-payload]
phase no difference [-7ms to 5ms]
☑️ Phase [start-push-update-payload] => [end-push-update-payload]
phase no difference [-3ms to 3ms]
☑️ Phase [end-push-update-payload] => [Test End]
phase no difference [0ms to 1ms]

Scenario - unused-relationships: ☑️ Performance is stable

☑️ duration
phase no difference [-28ms to 11ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-13ms to 7ms]
☑️ Phase [start-push-payload] => [end-push-payload]
phase no difference [-16ms to 9ms]
☑️ Phase [end-push-payload] => [Test End]
phase no difference [-3ms to 1ms]

igorT added 2 commits August 5, 2021 09:34

wrote test

5f19dce

Return inflight requests for findRecord when CUSTOM_MODEL_CLASS is on

3fa6c19

igorT added 🎯 beta PR should be backported to beta 🏷️ bug This PR primarily fixes a reported issue labels Aug 5, 2021

snewcomer approved these changes Aug 5, 2021

View reviewed changes

igorT merged commit 804a92e into master Aug 5, 2021

delete-merged-branch bot deleted the igor/request-caching branch August 5, 2021 20:13

igorT changed the title ~~Igor/request caching~~ Return inflight requests for findRecord when CUSTOM_MODEL_CLASS is on Aug 9, 2021

This was referenced Aug 30, 2021

Failing test: findRecord should not cache if includes differ #7687

Closed

3.28: Multiple findRecord requests for the same model but with different includes get dropped #7688

Closed

ijlee2 mentioned this pull request Aug 31, 2021

Ember 3.28 release ember-learn/ember-blog#1029

Merged

40 tasks

jrjohnson added 🎯 canary PR is targeting canary (default) and removed 🎯 beta PR should be backported to beta 🎯 canary PR is targeting canary (default) labels Sep 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Return inflight requests for findRecord when CUSTOM_MODEL_CLASS is on #7651

Return inflight requests for findRecord when CUSTOM_MODEL_CLASS is on #7651

igorT commented Aug 5, 2021 •

edited

Loading

snewcomer left a comment

github-actions bot commented Aug 5, 2021

Warnings

Warnings

Warnings

github-actions bot commented Aug 5, 2021

Return inflight requests for findRecord when CUSTOM_MODEL_CLASS is on #7651

Return inflight requests for findRecord when CUSTOM_MODEL_CLASS is on #7651

Conversation

igorT commented Aug 5, 2021 • edited Loading

snewcomer left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 5, 2021

Warnings

Warnings

Warnings

github-actions bot commented Aug 5, 2021

igorT commented Aug 5, 2021 •

edited

Loading