ts: The Great Types Migration #7585

runspired · 2021-06-05T12:08:06Z

types ahoy!

One giant shove over-the-cliff for a library, one-long-review for the man.

github-actions · 2021-06-05T12:13:50Z

Asset Size Report for b09a723

IE11 Builds

🛑 The size of the library EmberData has increased by +6.35 KB (+833.0 B compressed) which exceeds the failure threshold of 75 bytes.

Warnings

⚠️ The uncompressed size of the package @ember-data/store has increased by +2.44 KB.
⚠️ The uncompressed size of the package @ember-data/model has increased by +4.16 KB.

Changeset


EmberData +204.39 KB +6.35 KB (+41.59 KB +833.0 B compressed)
    @ember-data/store +83.96 KB +2.44 KB (+17.09 KB +320.59 B compressed)
        @ember-data/store/-private +83.04 KB +2.44 KB (+16.9 KB +320.59 B compressed)
    @ember-data/model +36.27 KB +4.16 KB (+7.38 KB +546.24 B compressed)
        @ember-data/model/-private +35.8 KB +4.16 KB (+7.28 KB +546.24 B compressed)
    ember-data +9.23 KB -264.0 B (+1.88 KB -33.83 B compressed)
        ember-data/index +2.19 KB -236.0 B (+455.42 B -30.24 B compressed)
        ember-data/setup-container +492.0 B -28.0 B (+100.12 B -3.59 B compressed)

Full Asset Analysis (IE11)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '204.39 KB' │
│ compressed │ '41.59 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '83.96 KB' │
│  compressed  │ '17.09 KB' │
│ % Of Library │   '41.1'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 83.04 KB  | 16.90 KB   | 98.9          | 40.6
	@ember-data/store/index                           | 936.00 B  | 190.47 B   | 1.1           | 0.4

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '36.27 KB' │
│  compressed  │ '7.38 KB'  │
│ % Of Library │   '17.7'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 35.80 KB  | 7.28 KB    | 98.7          | 17.5
	@ember-data/model/index                           | 486.00 B  | 98.89 B    | 1.3           | 0.2

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '25.74 KB' │
│  compressed  │ '5.24 KB'  │
│ % Of Library │   '12.6'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 25.74 KB  | 5.24 KB    | 100.0         | 12.6

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '21.13 KB' │
│  compressed  │ '4.30 KB'  │
│ % Of Library │   '10.3'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.84 KB   | 1.60 KB    | 37.1          | 3.8
	@ember-data/serializer/-private                   | 5.81 KB   | 1.18 KB    | 27.5          | 2.8
	@ember-data/serializer/json-api                   | 3.96 KB   | 824.77 B   | 18.7          | 1.9
	@ember-data/serializer/rest                       | 3.04 KB   | 634.50 B   | 14.4          | 1.5
	@ember-data/serializer/index                      | 273.00 B  | 55.55 B    | 1.3           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 43.75 B    | 1.0           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '17.92 KB' │
│  compressed  │ '3.65 KB'  │
│ % Of Library │   '8.8'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 9.22 KB   | 1.88 KB    | 51.5          | 4.5
	@ember-data/adapter/-private                      | 3.84 KB   | 800.15 B   | 21.4          | 1.9
	@ember-data/adapter/error                         | 1.98 KB   | 411.87 B   | 11.0          | 1.0
	@ember-data/adapter/index                         | 1.51 KB   | 314.80 B   | 8.4           | 0.7
	@ember-data/adapter/json-api                      | 1.37 KB   | 285.50 B   | 7.6           | 0.7

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.23 KB' │
│  compressed  │ '1.88 KB' │
│ % Of Library │   '4.5'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.19 KB   | 455.42 B   | 23.7          | 1.1
	ember-data/-private                               | 2.12 KB   | 441.99 B   | 23.0          | 1.0
	ember-data/adapters/errors                        | 1.19 KB   | 247.65 B   | 12.9          | 0.6
	ember-data/setup-container                        | 492.00 B  | 100.12 B   | 5.2           | 0.2
	ember-data/relationships                          | 318.00 B  | 64.71 B    | 3.4           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 55.75 B    | 2.9           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 51.07 B    | 2.7           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 49.85 B    | 2.6           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 49.44 B    | 2.6           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 49.44 B    | 2.6           | 0.1
	ember-data/transform                              | 241.00 B  | 49.04 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 48.22 B    | 2.5           | 0.1
	ember-data/serializer                             | 232.00 B  | 47.21 B    | 2.5           | 0.1
	ember-data/adapter                                | 226.00 B  | 45.99 B    | 2.4           | 0.1
	ember-data/model                                  | 222.00 B  | 45.17 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 45.17 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 44.36 B    | 2.3           | 0.1
	ember-data/version                                | 162.00 B  | 32.96 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '7.07 KB' │
│  compressed  │ '1.44 KB' │
│ % Of Library │   '3.5'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 3.11 KB   | 647.93 B   | 44.0          | 1.5
	ember-inflector/lib/system/inflections            | 1.59 KB   | 331.08 B   | 22.5          | 0.8
	ember-inflector/lib/helpers/pluralize             | 506.00 B  | 102.96 B   | 7.0           | 0.2
	ember-inflector/index                             | 473.00 B  | 96.25 B    | 6.5           | 0.2
	ember-inflector/lib/system                        | 471.00 B  | 95.84 B    | 6.5           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 71.63 B    | 4.9           | 0.2
	ember-inflector/lib/system/string                 | 332.00 B  | 67.56 B    | 4.6           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 60.23 B    | 4.1           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '3.07 KB'  │
│  compressed  │ '639.38 B' │
│ % Of Library │   '1.5'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.58 KB   | 537.63 B   | 84.1          | 1.3
	@ember-data/debug/setup                           | 500.00 B  | 101.74 B   | 15.9          | 0.2

Modern Builds

🛑 The size of the library EmberData has increased by +2.67 KB (+467.0 B compressed) which exceeds the failure threshold of 75 bytes.

Warnings

⚠️ The uncompressed size of the package @ember-data/store has increased by +1.1 KB.
⚠️ The uncompressed size of the package @ember-data/model has increased by +1.83 KB.

Changeset


EmberData +181.57 KB +2.67 KB (+39.43 KB +467.0 B compressed)
    @ember-data/store +73.05 KB +1.1 KB (+15.86 KB +192.61 B compressed)
        @ember-data/store/-private +72.13 KB +1.1 KB (+15.66 KB +192.61 B compressed)
    @ember-data/model +30.39 KB +1.83 KB (+6.6 KB +319.47 B compressed)
        @ember-data/model/-private +29.91 KB +1.83 KB (+6.5 KB +319.47 B compressed)
    ember-data +9.23 KB -264.0 B (+2.0 KB -45.08 B compressed)
        ember-data/index +2.19 KB -236.0 B (+485.99 B -40.3 B compressed)
        ember-data/setup-container +492.0 B -28.0 B (+106.83 B -4.78 B compressed)

Full Asset Analysis (Modern)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '181.57 KB' │
│ compressed │ '39.43 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '73.05 KB' │
│  compressed  │ '15.86 KB' │
│ % Of Library │   '40.2'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 72.13 KB  | 15.66 KB   | 98.7          | 39.7
	@ember-data/store/index                           | 936.00 B  | 203.25 B   | 1.3           | 0.5

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '30.39 KB' │
│  compressed  │ '6.60 KB'  │
│ % Of Library │   '16.7'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 29.91 KB  | 6.50 KB    | 98.4          | 16.5
	@ember-data/model/index                           | 486.00 B  | 105.53 B   | 1.6           | 0.3

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '23.77 KB' │
│  compressed  │ '5.16 KB'  │
│ % Of Library │   '13.1'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 23.77 KB  | 5.16 KB    | 100.0         | 13.1

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '19.65 KB' │
│  compressed  │ '4.27 KB'  │
│ % Of Library │   '10.8'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.21 KB   | 1.57 KB    | 36.7          | 4.0
	@ember-data/serializer/-private                   | 5.49 KB   | 1.19 KB    | 27.9          | 3.0
	@ember-data/serializer/json-api                   | 3.73 KB   | 828.66 B   | 19.0          | 2.1
	@ember-data/serializer/rest                       | 2.76 KB   | 614.11 B   | 14.1          | 1.5
	@ember-data/serializer/index                      | 258.00 B  | 56.02 B    | 1.3           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 46.68 B    | 1.1           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.98 KB' │
│  compressed  │ '3.47 KB'  │
│ % Of Library │   '8.8'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 8.12 KB   | 1.76 KB    | 50.8          | 4.5
	@ember-data/adapter/-private                      | 3.77 KB   | 838.64 B   | 23.6          | 2.1
	@ember-data/adapter/error                         | 1.94 KB   | 431.91 B   | 12.2          | 1.1
	@ember-data/adapter/index                         | 1.10 KB   | 244.29 B   | 6.9           | 0.6
	@ember-data/adapter/json-api                      | 1.04 KB   | 231.92 B   | 6.5           | 0.6

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.23 KB' │
│  compressed  │ '2.00 KB' │
│ % Of Library │   '5.1'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.19 KB   | 485.99 B   | 23.7          | 1.2
	ember-data/-private                               | 2.12 KB   | 471.65 B   | 23.0          | 1.2
	ember-data/adapters/errors                        | 1.19 KB   | 264.27 B   | 12.9          | 0.7
	ember-data/setup-container                        | 492.00 B  | 106.83 B   | 5.2           | 0.3
	ember-data/relationships                          | 318.00 B  | 69.05 B    | 3.4           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 59.50 B    | 2.9           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 54.50 B    | 2.7           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 53.20 B    | 2.6           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 52.76 B    | 2.6           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 52.76 B    | 2.6           | 0.1
	ember-data/transform                              | 241.00 B  | 52.33 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 51.46 B    | 2.5           | 0.1
	ember-data/serializer                             | 232.00 B  | 50.37 B    | 2.5           | 0.1
	ember-data/adapter                                | 226.00 B  | 49.07 B    | 2.4           | 0.1
	ember-data/model                                  | 222.00 B  | 48.20 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 48.20 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 47.33 B    | 2.3           | 0.1
	ember-data/version                                | 162.00 B  | 35.17 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.70 KB' │
│  compressed  │ '1.45 KB' │
│ % Of Library │   '3.7'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.88 KB   | 640.38 B   | 43.0          | 1.6
	ember-inflector/lib/system/inflections            | 1.59 KB   | 353.30 B   | 23.7          | 0.9
	ember-inflector/index                             | 473.00 B  | 102.71 B   | 6.9           | 0.3
	ember-inflector/lib/system                        | 471.00 B  | 102.27 B   | 6.9           | 0.3
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 80.99 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 76.43 B    | 5.1           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 69.05 B    | 4.6           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 64.27 B    | 4.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.81 KB'  │
│  compressed  │ '624.53 B' │
│ % Of Library │   '1.5'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.32 KB   | 516.17 B   | 82.6          | 1.3
	@ember-data/debug/setup                           | 499.00 B  | 108.35 B   | 17.4          | 0.3

Modern Builds (No Rollup)

🛑 The size of the library EmberData has increased by +994.0 B (+161.0 B compressed) which exceeds the failure threshold of 75 bytes.

Warnings

⚠️ The uncompressed size of the package @ember-data/store has increased by +231.0 B.
⚠️ The uncompressed size of the package @ember-data/model has increased by +1.0 KB.

Changeset


EmberData +221.51 KB +994.0 B (+42.52 KB +161.0 B compressed)
    @ember-data/store +97.95 KB +231.0 B (+18.8 KB +37.42 B compressed)
        @ember-data/store/-private/system/core-store +17.16 KB -149.0 B (+3.29 KB -24.13 B compressed)
        @ember-data/store/-private/system/model/internal-model +14.55 KB +104.0 B (+2.79 KB +16.85 B compressed)
        @ember-data/store/-private/system/fetch-manager +4.96 KB +11.0 B (+974.53 B +1.78 B compressed)
        @ember-data/store/-private/system/store/record-data-store-wrapper +3.41 KB +1.0 B (+669.71 B +0.16 B compressed)
        @ember-data/store/-private/system/store/internal-model-factory +2.82 KB -2.0 B (+554.54 B -0.32 B compressed)
        @ember-data/store/-private/system/record-arrays/record-array +2.37 KB +93.0 B (+466.24 B +15.06 B compressed)
        @ember-data/store/-private/system/ds-model-store +1.97 KB +10.0 B (+387.35 B +1.62 B compressed)
        @ember-data/store/-private/system/schema-definition-service +1.46 KB -51.0 B (+287.54 B -8.26 B compressed)
        @ember-data/store/-private/system/model/shim-model-class +1.33 KB +16.0 B (+262.01 B +2.59 B compressed)
        @ember-data/store/-private/system/store/serializer-response +1.14 KB -2.0 B (+223.81 B -0.32 B compressed)
        @ember-data/store/-private/system/record-arrays/adapter-populated-record-array +950.0 B -17.0 B (+182.35 B -2.75 B compressed)
        @ember-data/store/-private/system/snapshot-record-array +604.0 B -149.0 B (+115.93 B -24.13 B compressed)
        @ember-data/store/-private/system/promise-proxies +973.0 B +366.0 B (+186.76 B +59.28 B compressed)
    @ember-data/model +33.63 KB +1.0 KB (+6.46 KB +166.35 B compressed)
        @ember-data/model/-private/system/promise-many-array +3.81 KB +4.0 B (+748.41 B +0.65 B compressed)
        @ember-data/model/-private/system/many-array +2.85 KB +3.0 B (+560.68 B +0.49 B compressed)
        @ember-data/model/-private/errors +2.66 KB +589.0 B (+522.68 B +95.4 B compressed)
        @ember-data/model/-private/system/relationships/relationship-meta +1.26 KB +4.0 B (+247.04 B +0.65 B compressed)
        @ember-data/model/-private/system/promise-belongs-to +866.0 B +419.0 B (+166.22 B +67.87 B compressed)
        @ember-data/model/-private/system/model-for-mixin +439.0 B +8.0 B (+84.26 B +1.3 B compressed)
    ember-data +9.4 KB -264.0 B (+1.8 KB -42.76 B compressed)
        ember-data/index +2.19 KB -236.0 B (+429.58 B -38.23 B compressed)
        ember-data/setup-container +492.0 B -28.0 B (+94.43 B -4.54 B compressed)

Full Asset Analysis (Modern)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '221.51 KB' │
│ compressed │ '42.52 KB'  │
│  packages  │      8      │
│  modules   │     149     │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '97.95 KB' │
│  compressed  │ '18.80 KB' │
│ % Of Library │   '44.2'   │
└──────────────┴────────────┘
	Module                                                                             | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/store/-private/system/core-store                                       | 17.16 KB  | 3.29 KB    | 17.5          | 7.7
	@ember-data/store/-private/system/model/internal-model                             | 14.55 KB  | 2.79 KB    | 14.9          | 6.6
	@ember-data/store/-private/system/model/states                                     | 5.44 KB   | 1.04 KB    | 5.6           | 2.5
	@ember-data/store/-private/system/fetch-manager                                    | 4.96 KB   | 974.53 B   | 5.1           | 2.2
	@ember-data/store/-private/system/store/finders                                    | 4.57 KB   | 899.10 B   | 4.7           | 2.1
	@ember-data/store/-private/system/record-array-manager                             | 4.19 KB   | 822.89 B   | 4.3           | 1.9
	@ember-data/store/-private/identifiers/cache                                       | 3.98 KB   | 782.77 B   | 4.1           | 1.8
	@ember-data/store/-private/index                                                   | 3.57 KB   | 701.58 B   | 3.6           | 1.6
	@ember-data/store/-private/system/store/record-data-store-wrapper                  | 3.41 KB   | 669.71 B   | 3.5           | 1.5
	@ember-data/store/-private/system/snapshot                                         | 3.10 KB   | 610.21 B   | 3.2           | 1.4
	@ember-data/store/-private/system/store/internal-model-factory                     | 2.82 KB   | 554.54 B   | 2.9           | 1.3
	@ember-data/store/-private/system/record-arrays/record-array                       | 2.37 KB   | 466.24 B   | 2.4           | 1.1
	@ember-data/store/-private/system/ds-model-store                                   | 1.97 KB   | 387.35 B   | 2.0           | 0.9
	@ember-data/store/-private/system/request-cache                                    | 1.89 KB   | 370.65 B   | 1.9           | 0.9
	@ember-data/store/-private/system/references/has-many                              | 1.53 KB   | 301.17 B   | 1.6           | 0.7
	@ember-data/store/-private/system/schema-definition-service                        | 1.46 KB   | 287.54 B   | 1.5           | 0.7
	@ember-data/store/-private/system/model/shim-model-class                           | 1.33 KB   | 262.01 B   | 1.4           | 0.6
	@ember-data/store/-private/system/references/belongs-to                            | 1.32 KB   | 259.90 B   | 1.3           | 0.6
	@ember-data/store/-private/system/store/serializer-response                        | 1.14 KB   | 223.81 B   | 1.2           | 0.5
	@ember-data/store/-private/identifiers/utils/uuid-v4                               | 1.05 KB   | 206.92 B   | 1.1           | 0.5
	@ember-data/store/-private/system/references/record                                | 982.00 B  | 188.49 B   | 1.0           | 0.4
	@ember-data/store/-private/system/promise-proxies                                  | 973.00 B  | 186.76 B   | 1.0           | 0.4
	@ember-data/store/-private/system/record-arrays/adapter-populated-record-array     | 950.00 B  | 182.35 B   | 0.9           | 0.4
	@ember-data/store/index                                                            | 936.00 B  | 179.66 B   | 0.9           | 0.4
	@ember-data/store/-private/system/references/reference                             | 934.00 B  | 179.28 B   | 0.9           | 0.4
	@ember-data/store/-private/system/internal-model-map                               | 886.00 B  | 170.06 B   | 0.9           | 0.4
	@ember-data/store/-private/system/errors-utils                                     | 798.00 B  | 153.17 B   | 0.8           | 0.4
	@ember-data/store/-private/system/record-notification-manager                      | 697.00 B  | 133.79 B   | 0.7           | 0.3
	@ember-data/store/-private/utils/construct-resource                                | 695.00 B  | 133.40 B   | 0.7           | 0.3
	@ember-data/store/-private/system/snapshot-record-array                            | 604.00 B  | 115.93 B   | 0.6           | 0.3
	@ember-data/store/-private/system/references                                       | 598.00 B  | 114.78 B   | 0.6           | 0.3
	@ember-data/store/-private/system/store/common                                     | 527.00 B  | 101.15 B   | 0.5           | 0.2
	@ember-data/store/-private/system/coerce-id                                        | 496.00 B  | 95.20 B    | 0.5           | 0.2
	@ember-data/store/-private/system/record-arrays                                    | 487.00 B  | 93.48 B    | 0.5           | 0.2
	@ember-data/store/-private/system/identity-map                                     | 450.00 B  | 86.37 B    | 0.4           | 0.2
	@ember-data/store/-private/ts-interfaces/identifier                                | 400.00 B  | 76.78 B    | 0.4           | 0.2
	@ember-data/store/-private/utils/symbol                                            | 393.00 B  | 75.43 B    | 0.4           | 0.2
	@ember-data/store/-private/system/record-data-for                                  | 390.00 B  | 74.86 B    | 0.4           | 0.2
	@ember-data/store/-private/identifiers/is-stable-identifier                        | 327.00 B  | 62.76 B    | 0.3           | 0.1
	@ember-data/store/-private/ts-interfaces/fetch-manager                             | 316.00 B  | 60.65 B    | 0.3           | 0.1
	@ember-data/store/-private/utils/promise-record                                    | 290.00 B  | 55.66 B    | 0.3           | 0.1
	@ember-data/store/-private/system/backburner                                       | 269.00 B  | 51.63 B    | 0.3           | 0.1
	@ember-data/store/-private/system/deprecated-evented                               | 257.00 B  | 49.33 B    | 0.3           | 0.1
	@ember-data/store/-private/system/normalize-model-name                             | 220.00 B  | 42.22 B    | 0.2           | 0.1
	@ember-data/store/-private/utils/is-non-empty-string                               | 212.00 B  | 40.69 B    | 0.2           | 0.1
	@ember-data/store/-debug/index                                                     | 210.00 B  | 40.30 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-serializer-interface              | 169.00 B  | 32.43 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-record-wrapper                | 167.00 B  | 32.05 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-adapter-interface                 | 166.00 B  | 31.86 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-store-wrapper                 | 166.00 B  | 31.86 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/schema-definition-service                 | 166.00 B  | 31.86 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-json-api                      | 161.00 B  | 30.90 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/ember-data-json-api                       | 160.00 B  | 30.71 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-schemas                       | 160.00 B  | 30.71 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/promise-proxies                           | 156.00 B  | 29.94 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-instance                           | 156.00 B  | 29.94 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data                               | 152.00 B  | 29.17 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/ds-model                                  | 149.00 B  | 28.60 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/store                                     | 146.00 B  | 28.02 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/utils                                     | 146.00 B  | 28.02 B    | 0.1           | 0.1

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '33.63 KB' │
│  compressed  │ '6.46 KB'  │
│ % Of Library │   '15.2'   │
└──────────────┴────────────┘
	Module                                                                | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------
	@ember-data/model/-private/model                                      | 9.89 KB   | 1.90 KB    | 29.4          | 4.5
	@ember-data/model/-private/record-state                               | 6.17 KB   | 1.18 KB    | 18.3          | 2.8
	@ember-data/model/-private/system/promise-many-array                  | 3.81 KB   | 748.41 B   | 11.3          | 1.7
	@ember-data/model/-private/system/many-array                          | 2.85 KB   | 560.68 B   | 8.5           | 1.3
	@ember-data/model/-private/errors                                     | 2.66 KB   | 522.68 B   | 7.9           | 1.2
	@ember-data/model/-private/index                                      | 1.42 KB   | 279.48 B   | 4.2           | 0.6
	@ember-data/model/-private/system/relationships/relationship-meta     | 1.26 KB   | 247.04 B   | 3.7           | 0.6
	@ember-data/model/-private/system/promise-belongs-to                  | 866.00 B  | 166.22 B   | 2.5           | 0.4
	@ember-data/model/-private/attr                                       | 857.00 B  | 164.50 B   | 2.5           | 0.4
	@ember-data/model/-private/notify-changes                             | 845.00 B  | 162.19 B   | 2.5           | 0.4
	@ember-data/model/-private/belongs-to                                 | 687.00 B  | 131.87 B   | 2.0           | 0.3
	@ember-data/model/-private/has-many                                   | 648.00 B  | 124.38 B   | 1.9           | 0.3
	@ember-data/model/index                                               | 486.00 B  | 93.28 B    | 1.4           | 0.2
	@ember-data/model/-private/util                                       | 442.00 B  | 84.84 B    | 1.3           | 0.2
	@ember-data/model/-private/system/model-for-mixin                     | 439.00 B  | 84.26 B    | 1.3           | 0.2
	@ember-data/model/-private/system/diff-array                          | 438.00 B  | 84.07 B    | 1.3           | 0.2

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '30.84 KB' │
│  compressed  │ '5.92 KB'  │
│ % Of Library │   '13.9'   │
└──────────────┴────────────┘
	Module                                                                            | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private/record-data                                      | 8.21 KB   | 1.58 KB    | 26.6          | 3.7
	@ember-data/record-data/-private/graph/index                                      | 4.86 KB   | 955.14 B   | 15.8          | 2.2
	@ember-data/record-data/-private/graph/operations/replace-related-records         | 3.14 KB   | 617.12 B   | 10.2          | 1.4
	@ember-data/record-data/-private/graph/-edge-definition                           | 2.83 KB   | 556.08 B   | 9.2           | 1.3
	@ember-data/record-data/-private/relationships/state/has-many                     | 2.01 KB   | 395.03 B   | 6.5           | 0.9
	@ember-data/record-data/-private/relationships/state/belongs-to                   | 1.92 KB   | 377.95 B   | 6.2           | 0.9
	@ember-data/record-data/-private/graph/operations/update-relationship             | 1.50 KB   | 295.41 B   | 4.9           | 0.7
	@ember-data/record-data/-private/graph/-utils                                     | 1.05 KB   | 206.34 B   | 3.4           | 0.5
	@ember-data/record-data/-private/graph/operations/replace-related-record          | 1.04 KB   | 203.66 B   | 3.4           | 0.5
	@ember-data/record-data/-private/index                                            | 977.00 B  | 187.53 B   | 3.1           | 0.4
	@ember-data/record-data/-private/graph/operations/add-to-related-records          | 788.00 B  | 151.25 B   | 2.5           | 0.3
	@ember-data/record-data/-private/relationships/state/implicit                     | 692.00 B  | 132.83 B   | 2.2           | 0.3
	@ember-data/record-data/-private/graph/operations/remove-from-related-records     | 667.00 B  | 128.03 B   | 2.1           | 0.3
	@ember-data/record-data/-private/coerce-id                                        | 406.00 B  | 77.93 B    | 1.3           | 0.2
	@ember-data/record-data/-private/graph/-state                                     | 293.00 B  | 56.24 B    | 0.9           | 0.1
	@ember-data/record-data/-private/normalize-link                                   | 238.00 B  | 45.68 B    | 0.8           | 0.1
	@ember-data/record-data/-private/ts-interfaces/relationship-record-data           | 171.00 B  | 32.82 B    | 0.5           | 0.1
	@ember-data/record-data/-private/graph/-operations                                | 150.00 B  | 28.79 B    | 0.5           | 0.1

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.08 KB' │
│  compressed  │ '4.24 KB'  │
│ % Of Library │   '10.0'   │
└──────────────┴────────────┘
	Module                                                     | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                                | 7.21 KB   | 1.38 KB    | 32.7          | 3.3
	@ember-data/serializer/-private/embedded-records-mixin     | 4.39 KB   | 862.43 B   | 19.9          | 2.0
	@ember-data/serializer/json-api                            | 3.73 KB   | 732.48 B   | 16.9          | 1.7
	@ember-data/serializer/rest                                | 2.76 KB   | 542.83 B   | 12.5          | 1.2
	@ember-data/serializer/-private/index                      | 1.18 KB   | 232.26 B   | 5.4           | 0.5
	@ember-data/serializer/-private/transforms/date            | 523.00 B  | 100.39 B   | 2.3           | 0.2
	@ember-data/serializer/-private/transforms/boolean         | 507.00 B  | 97.31 B    | 2.2           | 0.2
	@ember-data/serializer/-private/transforms/number          | 446.00 B  | 85.61 B    | 2.0           | 0.2
	@ember-data/serializer/-private/transforms/string          | 368.00 B  | 70.63 B    | 1.6           | 0.2
	@ember-data/serializer/-private/utils                      | 303.00 B  | 58.16 B    | 1.3           | 0.1
	@ember-data/serializer/index                               | 258.00 B  | 49.52 B    | 1.1           | 0.1
	@ember-data/serializer/-private/transforms/transform       | 257.00 B  | 49.33 B    | 1.1           | 0.1
	@ember-data/serializer/transform                           | 215.00 B  | 41.26 B    | 1.0           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '18.11 KB' │
│  compressed  │ '3.48 KB'  │
│ % Of Library │   '8.2'    │
└──────────────┴────────────┘
	Module                                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                                      | 8.12 KB   | 1.56 KB    | 44.8          | 3.7
	@ember-data/adapter/error                                     | 1.94 KB   | 381.79 B   | 10.7          | 0.9
	@ember-data/adapter/-private/build-url-mixin                  | 1.93 KB   | 380.06 B   | 10.7          | 0.9
	@ember-data/adapter/index                                     | 1.10 KB   | 215.94 B   | 6.1           | 0.5
	@ember-data/adapter/json-api                                  | 1.04 KB   | 205.00 B   | 5.8           | 0.5
	@ember-data/adapter/-private/index                            | 1.03 KB   | 202.70 B   | 5.7           | 0.5
	@ember-data/adapter/-private/utils/serialize-query-params     | 792.00 B  | 152.02 B   | 4.3           | 0.3
	@ember-data/adapter/-private/utils/determine-body-promise     | 566.00 B  | 108.64 B   | 3.1           | 0.2
	@ember-data/adapter/-private/utils/parse-response-headers     | 480.00 B  | 92.13 B    | 2.6           | 0.2
	@ember-data/adapter/-private/utils/fetch                      | 454.00 B  | 87.14 B    | 2.4           | 0.2
	@ember-data/adapter/-private/utils/serialize-into-hash        | 347.00 B  | 66.60 B    | 1.9           | 0.2
	@ember-data/adapter/-private/utils/continue-on-reject         | 222.00 B  | 42.61 B    | 1.2           | 0.1
	@ember-data/adapter/-private/fastboot-interface               | 147.00 B  | 28.21 B    | 0.8           | 0.1

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.40 KB' │
│  compressed  │ '1.80 KB' │
│ % Of Library │   '4.2'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.19 KB   | 429.58 B   | 23.3          | 1.0
	ember-data/-private/index                         | 1.93 KB   | 378.91 B   | 20.5          | 0.9
	ember-data/adapters/errors                        | 1.19 KB   | 233.60 B   | 12.6          | 0.5
	ember-data/setup-container                        | 492.00 B  | 94.43 B    | 5.1           | 0.2
	ember-data/-private/core                          | 366.00 B  | 70.25 B    | 3.8           | 0.2
	ember-data/relationships                          | 318.00 B  | 61.04 B    | 3.3           | 0.1
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 52.59 B    | 2.8           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 48.17 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 47.02 B    | 2.5           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 46.64 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 46.64 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 46.26 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 45.49 B    | 2.5           | 0.1
	ember-data/serializer                             | 232.00 B  | 44.53 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 43.38 B    | 2.3           | 0.1
	ember-data/model                                  | 222.00 B  | 42.61 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 42.61 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 41.84 B    | 2.3           | 0.1
	ember-data/version                                | 162.00 B  | 31.09 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.70 KB' │
│  compressed  │ '1.29 KB' │
│ % Of Library │   '3.0'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.88 KB   | 566.06 B   | 43.0          | 1.3
	ember-inflector/lib/system/inflections            | 1.59 KB   | 312.30 B   | 23.7          | 0.7
	ember-inflector/index                             | 473.00 B  | 90.79 B    | 6.9           | 0.2
	ember-inflector/lib/system                        | 471.00 B  | 90.40 B    | 6.9           | 0.2
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 71.59 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 67.56 B    | 5.1           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 61.04 B    | 4.6           | 0.1
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 56.81 B    | 4.3           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.81 KB'  │
│  compressed  │ '552.05 B' │
│ % Of Library │   '1.3'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.32 KB   | 456.26 B   | 82.6          | 1.0
	@ember-data/debug/setup                           | 499.00 B  | 95.78 B    | 17.4          | 0.2

github-actions · 2021-06-05T12:36:48Z

Performance Report for b09a723

Scenario - materialization: ☑️ Performance is stable

☑️ duration
phase no difference [-34ms to 6ms]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-10ms to 12ms]
✅ Phase [start-find-all] => [start-materialization]
phase estimated improvement -21ms [-35ms to -10ms] OR -2.3% [-3.83% to -1.07%]
☑️ Phase [start-materialization] => [end-materialization]
phase no difference [-8ms to 3ms]
⚠️ Phase [end-materialization] => [Test End]
phase estimated regression +4ms [1ms to 6ms] OR +5.43% [1.52% to 9.38%]

Scenario - unload: ☑️ Performance is stable

☑️ duration
phase no difference [-20ms to 13ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-3ms to 11ms]
☑️ Phase [start-push-payload] => [start-unload-records]
phase no difference [-13ms to 6ms]
☑️ Phase [start-unload-records] => [end-unload-records]
phase no difference [-8ms to 3ms]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [-1ms to 1ms]

Scenario - destroy: ☑️ Performance is stable

☑️ duration
phase no difference [-31ms to 17ms]
✅ Phase [navigationStart] => [start-push-payload]
phase estimated improvement -10ms [-20ms to -2ms] OR -1.35% [-2.53% to -0.22%]
☑️ Phase [start-push-payload] => [start-destroy-records]
phase no difference [-12ms to 17ms]
☑️ Phase [start-destroy-records] => [end-destroy-records]
phase no difference [-8ms to 6ms]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [-1ms to 0ms]

Scenario - add-children: ☑️ Performance is stable

☑️ duration
phase no difference [-17ms to 10ms]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-9ms to 13ms]
☑️ Phase [start-push-initial-payload] => [start-push-update-payload]
phase no difference [-8ms to 1ms]
☑️ Phase [start-push-update-payload] => [end-push-update-payload]
phase no difference [-3ms to 1ms]
☑️ Phase [end-push-update-payload] => [Test End]
phase no difference [0ms to 1ms]

Scenario - unused-relationships: ⚠️ Performance regressed

⚠️ duration
phase estimated regression +18ms [3ms to 32ms] OR +0.8% [0.13% to 1.42%]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-4ms to 10ms]
☑️ Phase [start-push-payload] => [end-push-payload]
phase no difference [-1ms to 20ms]
⚠️ Phase [end-push-payload] => [Test End]
phase estimated regression +2ms [1ms to 3ms] OR +2.06% [1.07% to 3.09%]

runspired · 2021-06-09T00:56:29Z

packages/store/addon/-private/system/model/internal-model.ts

-        // and for currentState.stateName to be constructed from flag state.
-        // Probably just port this work from ember-m3
-        // After that we can eliminate this.
+      if (this.hasRecord && isDSModel(this._record)) {


reminder to discuss with @igorT

* port more types work over * fix types * progress, needs fixes * get it working * fix code stripping * fix assert * end demo

runspired added 2 commits June 5, 2021 05:05

ts: the great migration

4bc0ad4

more nice things

b09a723

runspired added ts-review 🎯 canary PR is targeting canary (default) typescript For issues and PRs relating to typescript convertion labels Jun 5, 2021

runspired requested review from igorT and snewcomer June 5, 2021 12:08

runspired changed the base branch from master to runspired/type-evented June 5, 2021 12:10

runspired mentioned this pull request Jun 5, 2021

Some usages of assert are incorrectly specifying a third param #7580

Closed

runspired added 4 commits June 8, 2021 16:37

ts is happy

af654ce

are we complete, or are we tangled

d6e5558

into the thick of it

ff025ce

fix docs test

cacfeb1

runspired commented Jun 9, 2021

View reviewed changes

delete-merged-branch bot deleted the branch runspired/type-evented April 15, 2022 08:56

runspired added a commit that referenced this pull request Apr 16, 2022

port more types work over from #7585 (#7954)

faf6ed5

* port more types work over * fix types * progress, needs fixes * get it working * fix code stripping * fix assert * end demo

runspired closed this Nov 18, 2022

runspired deleted the runspired/the-great-types-migration branch November 20, 2024 05:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ts: The Great Types Migration #7585

ts: The Great Types Migration #7585

runspired commented Jun 5, 2021

github-actions bot commented Jun 5, 2021

Warnings

Warnings

Warnings

github-actions bot commented Jun 5, 2021

runspired Jun 9, 2021

ts: The Great Types Migration #7585

ts: The Great Types Migration #7585

Conversation

runspired commented Jun 5, 2021

github-actions bot commented Jun 5, 2021

Warnings

Warnings

Warnings

github-actions bot commented Jun 5, 2021

runspired Jun 9, 2021

Choose a reason for hiding this comment