-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: activate all feature flags related to custom model classes #7510
Conversation
Asset Size Report for 8f061f1 IE11 Builds 🛑 The size of the library EmberData has increased by +8.44 KB (+1.63 KB compressed) which exceeds the failure threshold of 75 bytes.Warnings
Changeset
Full Asset Analysis (IE11)
Modern Builds 🛑 The size of the library EmberData has increased by +7.84 KB (+1.57 KB compressed) which exceeds the failure threshold of 75 bytes.Warnings
Changeset
Full Asset Analysis (Modern)
Modern Builds (No Rollup) 🛑 The size of the library EmberData has increased by +1.47 KB (+243.0 B compressed) which exceeds the failure threshold of 75 bytes.Warnings
Changeset
Full Asset Analysis (Modern)
|
Performance Report for 8f061f1 Scenario - materialization:
|
Ilios has 3 test failures, seem to all be in the same unit test module. Will investigate Friday afternoon. |
The perf jitter here is minimal enough outside of the destroy case that I'm not concerned. The destroy case should be at least offset if not fully addressed and then improved by #7505 The file size increase is slightly concerning: it seems likely we did not flag for removal enough of the old code paths. Hopefully once we begin cleanup where we missed things will become evident. |
f112e95
to
c318a06
Compare
Not sure why the prod IE11 scenario failed here, can't spot anything that specifically seems IE11 problematic, don't have easy access to a VM with IE11 to debug either. |
Activates all Features for 3.28