Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] burndown of InternalModel methods that can be eliminated safely #7453

Merged
merged 21 commits into from
Apr 16, 2021

Conversation

runspired
Copy link
Contributor

@runspired runspired commented Apr 9, 2021

Each commit here removes a method or property from InternalModel for which either a different InternalModel codepath is just as efficient to use OR the codepath is unused OR the codepath has a non InternalModel equivalent of the same efficiency.

The motivation is to shrink the surface area of InternalModel until what remains is logic we need to move elsewhere, helping us get a clearer picture of what InternalModel is still handling for us. It comes with the added win of reducing our payload size slightly.

@runspired runspired marked this pull request as draft April 9, 2021 21:05
@github-actions
Copy link

github-actions bot commented Apr 9, 2021

Performance Report for a95973e

Relationship Analysis
                        -------------

__/\\\\\\\\\\\\\____/\\\\____________/\\\\____/\\\\\\\\\_____
 _\/\\\/////////\\\_\/\\\\\\________/\\\\\\__/\\\///////\\\___
  _\/\\\_______\/\\\_\/\\\//\\\____/\\\//\\\_\///______\//\\\__
   _\/\\\\\\\\\\\\\/__\/\\\\///\\\/\\\/_\/\\\___________/\\\/___
    _\/\\\/////////____\/\\\__\///\\\/___\/\\\________/\\\//_____
     _\/\\\_____________\/\\\____\///_____\/\\\_____/\\\//________
      _\/\\\_____________\/\\\_____________\/\\\___/\\\/___________
       _\/\\\_____________\/\\\_____________\/\\\__/\\\\\\\\\\\\\\\_
        _\///______________\///______________\///__\///////////////__


                          Runtime Edition

        PM2 is a Production Process Manager for Node.js applications
                     with a built-in Load Balancer.

                Start and Daemonize any application:
                $ pm2 start app.js

                Load Balance 4 instances of api.js:
                $ pm2 start api.js -i 4

                Monitor in production:
                $ pm2 monitor

                Make pm2 auto-boot at server restart:
                $ pm2 startup

                To go further checkout:
                http://pm2.io/


                        -------------

[PM2] Spawning PM2 daemon with pm2_home=/home/runner/.pm2
[PM2] PM2 Successfully daemonized
[PM2] Starting /home/runner/work/data/data/bin/relationship-performance-tracking/src/har-remix.js in fork_mode (1 instance)
[PM2] Done.
┌─────┬────────────┬─────────────┬─────────┬─────────┬──────────┬────────┬──────┬───────────┬──────────┬──────────┬──────────┬──────────┐
│ id  │ name       │ namespace   │ version │ mode    │ pid      │ uptime │ ↺    │ status    │ cpu      │ mem      │ user     │ watching │
├─────┼────────────┼─────────────┼─────────┼─────────┼──────────┼────────┼──────┼───────────┼──────────┼──────────┼──────────┼──────────┤
│ 0   │ control    │ default     │ N/A     │ fork    │ 1894     │ 0s     │ 0    │ online    │ 0%       │ 66.5mb   │ runner   │ disabled │
└─────┴────────────┴─────────────┴─────────┴─────────┴──────────┴────────┴──────┴───────────┴──────────┴──────────┴──────────┴──────────┘
[PM2] Starting /home/runner/work/data/data/bin/relationship-performance-tracking/src/har-remix.js in fork_mode (1 instance)
[PM2] Done.
┌─────┬───────────────┬─────────────┬─────────┬─────────┬──────────┬────────┬──────┬───────────┬──────────┬──────────┬──────────┬──────────┐
│ id  │ name          │ namespace   │ version │ mode    │ pid      │ uptime │ ↺    │ status    │ cpu      │ mem      │ user     │ watching │
├─────┼───────────────┼─────────────┼─────────┼─────────┼──────────┼────────┼──────┼───────────┼──────────┼──────────┼──────────┼──────────┤
│ 0   │ control       │ default     │ N/A     │ fork    │ 1894     │ 0s     │ 0    │ online    │ 0%       │ 66.5mb   │ runner   │ disabled │
│ 1   │ experiment    │ default     │ N/A     │ fork    │ 1918     │ 0s     │ 0    │ online    │ 0%       │ 29.2mb   │ runner   │ disabled │
└─────┴───────────────┴─────────────┴─────────┴─────────┴──────────┴────────┴──────┴───────────┴──────────┴──────────┴──────────┴──────────┘
01-materialization: computing results...

===============================================================================
Processing CHANGELOG.md CODE_OF_CONDUCT.md CONTRIBUTING.md README.md RELEASE.md bin lerna.json node_modules package.json packages tmp tsconfig.json yarn.lock
[PM2] Applying action deleteProcessId on app [all](ids: [ 0, 1 ])
[PM2] [control](0) ✓
[PM2] [experiment](1) ✓
[PM2] [v] All Applications Stopped
[PM2] [v] PM2 Daemon Stopped

@github-actions
Copy link

github-actions bot commented Apr 9, 2021

Asset Size Report for c0cbdae

IE11 Builds

✅ EmberData shrank by -1.16 KB (-172.0 B compressed)

If any packages had changed sizes they would be listed here.

Changeset


EmberData +177.16 KB -1.16 KB (+36.26 KB -172.0 B compressed)
    @ember-data/store +76.61 KB -1023.0 B (+15.68 KB -148.49 B compressed)
        @ember-data/store/-private +75.69 KB -1023.0 B (+15.49 KB -148.49 B compressed)
    @ember-data/model +15.8 KB -162.0 B (+3.23 KB -23.51 B compressed)
        @ember-data/model/-private +15.32 KB -162.0 B (+3.14 KB -23.51 B compressed)

Full Asset Analysis (IE11)

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '177.16 KB' │
│ compressed │ '36.26 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '76.61 KB' │
│  compressed  │ '15.68 KB' │
│ % Of Library │   '43.2'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 75.69 KB  | 15.49 KB   | 98.8          | 42.7
	@ember-data/store/index                           | 936.00 B  | 191.59 B   | 1.2           | 0.5

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '25.09 KB' │
│  compressed  │ '5.14 KB'  │
│ % Of Library │   '14.2'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 25.09 KB  | 5.14 KB    | 100.0         | 14.2

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '20.84 KB' │
│  compressed  │ '4.27 KB'  │
│ % Of Library │   '11.8'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.75 KB   | 1.59 KB    | 37.2          | 4.4
	@ember-data/serializer/-private                   | 5.69 KB   | 1.16 KB    | 27.3          | 3.2
	@ember-data/serializer/json-api                   | 3.95 KB   | 827.60 B   | 18.9          | 2.2
	@ember-data/serializer/rest                       | 3.00 KB   | 628.02 B   | 14.4          | 1.7
	@ember-data/serializer/index                      | 258.00 B  | 52.81 B    | 1.2           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 44.01 B    | 1.0           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '18.47 KB' │
│  compressed  │ '3.78 KB'  │
│ % Of Library │   '10.4'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 9.31 KB   | 1.91 KB    | 50.4          | 5.3
	@ember-data/adapter/-private                      | 3.80 KB   | 797.51 B   | 20.6          | 2.1
	@ember-data/adapter/error                         | 1.95 KB   | 408.17 B   | 10.5          | 1.1
	@ember-data/adapter/index                         | 1.81 KB   | 378.69 B   | 9.8           | 1.0
	@ember-data/adapter/json-api                      | 1.60 KB   | 336.11 B   | 8.7           | 0.9

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.80 KB' │
│  compressed  │ '3.23 KB'  │
│ % Of Library │   '8.9'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 15.32 KB  | 3.14 KB    | 97.0          | 8.6
	@ember-data/model/index                           | 486.00 B  | 99.48 B    | 3.0           | 0.3

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.24 KB' │
│  compressed  │ '1.89 KB' │
│ % Of Library │   '5.2'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.32 KB   | 486.98 B   | 25.1          | 1.3
	ember-data/-private                               | 1.98 KB   | 415.33 B   | 21.4          | 1.1
	ember-data/adapters/errors                        | 1.19 KB   | 249.12 B   | 12.9          | 0.7
	ember-data/setup-container                        | 503.00 B  | 102.96 B   | 5.3           | 0.3
	ember-data/relationships                          | 318.00 B  | 65.09 B    | 3.4           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 56.08 B    | 2.9           | 0.2
	ember-data/serializers/json-api                   | 251.00 B  | 51.37 B    | 2.7           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 50.15 B    | 2.6           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 49.74 B    | 2.6           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 49.74 B    | 2.6           | 0.1
	ember-data/transform                              | 241.00 B  | 49.33 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 48.51 B    | 2.5           | 0.1
	ember-data/serializer                             | 232.00 B  | 47.49 B    | 2.5           | 0.1
	ember-data/adapter                                | 226.00 B  | 46.26 B    | 2.4           | 0.1
	ember-data/model                                  | 222.00 B  | 45.44 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 45.44 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 44.62 B    | 2.3           | 0.1
	ember-data/version                                | 162.00 B  | 33.16 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '8.15 KB' │
│  compressed  │ '1.67 KB' │
│ % Of Library │   '4.6'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 3.11 KB   | 651.76 B   | 38.1          | 1.8
	ember-inflector/lib/helpers/pluralize             | 1.62 KB   | 339.39 B   | 19.9          | 0.9
	ember-inflector/lib/system/inflections            | 1.59 KB   | 333.04 B   | 19.5          | 0.9
	ember-inflector/index                             | 473.00 B  | 96.82 B    | 5.7           | 0.3
	ember-inflector/lib/system                        | 471.00 B  | 96.41 B    | 5.6           | 0.3
	ember-inflector/lib/system/string                 | 332.00 B  | 67.96 B    | 4.0           | 0.2
	ember-inflector/lib/utils/make-helper             | 308.00 B  | 63.04 B    | 3.7           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 60.59 B    | 3.5           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.96 KB'  │
│  compressed  │ '620.44 B' │
│ % Of Library │   '1.7'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.47 KB   | 518.09 B   | 83.5          | 1.4
	@ember-data/debug/setup                           | 500.00 B  | 102.34 B   | 16.5          | 0.3

Modern Builds

✅ EmberData shrank by -909.0 B (-175.0 B compressed)

If any packages had changed sizes they would be listed here.

Changeset


EmberData +157.88 KB -909.0 B (+34.16 KB -175.0 B compressed)
    @ember-data/store +67.5 KB -765.0 B (+14.61 KB -147.28 B compressed)
        @ember-data/store/-private +66.59 KB -765.0 B (+14.41 KB -147.28 B compressed)
    @ember-data/model +14.4 KB -144.0 B (+3.12 KB -27.72 B compressed)
        @ember-data/model/-private +13.92 KB -144.0 B (+3.01 KB -27.72 B compressed)

Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '157.88 KB' │
│ compressed │ '34.16 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '67.50 KB' │
│  compressed  │ '14.61 KB' │
│ % Of Library │   '42.8'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 66.59 KB  | 14.41 KB   | 98.6          | 42.2
	@ember-data/store/index                           | 936.00 B  | 202.54 B   | 1.4           | 0.6

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.00 KB' │
│  compressed  │ '4.76 KB'  │
│ % Of Library │   '13.9'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 22.00 KB  | 4.76 KB    | 100.0         | 13.9

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '19.37 KB' │
│  compressed  │ '4.19 KB'  │
│ % Of Library │   '12.3'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.12 KB   | 1.54 KB    | 36.8          | 4.5
	@ember-data/serializer/-private                   | 5.37 KB   | 1.16 KB    | 27.7          | 3.4
	@ember-data/serializer/json-api                   | 3.72 KB   | 823.58 B   | 19.2          | 2.4
	@ember-data/serializer/rest                       | 2.71 KB   | 601.13 B   | 14.0          | 1.7
	@ember-data/serializer/index                      | 243.00 B  | 52.58 B    | 1.2           | 0.2
	@ember-data/serializer/transform                  | 215.00 B  | 46.52 B    | 1.1           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '16.02 KB' │
│  compressed  │ '3.47 KB'  │
│ % Of Library │   '10.1'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 8.37 KB   | 1.81 KB    | 52.2          | 5.3
	@ember-data/adapter/-private                      | 3.58 KB   | 794.15 B   | 22.4          | 2.3
	@ember-data/adapter/error                         | 1.91 KB   | 423.91 B   | 11.9          | 1.2
	@ember-data/adapter/index                         | 1.14 KB   | 251.87 B   | 7.1           | 0.7
	@ember-data/adapter/json-api                      | 1.02 KB   | 225.69 B   | 6.4           | 0.6

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '14.40 KB' │
│  compressed  │ '3.12 KB'  │
│ % Of Library │   '9.1'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 13.92 KB  | 3.01 KB    | 96.7          | 8.8
	@ember-data/model/index                           | 486.00 B  | 105.16 B   | 3.3           | 0.3

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.24 KB' │
│  compressed  │ '2.00 KB' │
│ % Of Library │   '5.9'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.32 KB   | 514.79 B   | 25.1          | 1.5
	ember-data/-private                               | 1.98 KB   | 439.05 B   | 21.4          | 1.3
	ember-data/adapters/errors                        | 1.19 KB   | 263.34 B   | 12.9          | 0.8
	ember-data/setup-container                        | 503.00 B  | 108.84 B   | 5.3           | 0.3
	ember-data/relationships                          | 318.00 B  | 68.81 B    | 3.4           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 59.29 B    | 2.9           | 0.2
	ember-data/serializers/json-api                   | 251.00 B  | 54.31 B    | 2.7           | 0.2
	ember-data/adapters/json-api                      | 245.00 B  | 53.01 B    | 2.6           | 0.2
	ember-data/serializers/json                       | 243.00 B  | 52.58 B    | 2.6           | 0.2
	ember-data/serializers/rest                       | 243.00 B  | 52.58 B    | 2.6           | 0.2
	ember-data/transform                              | 241.00 B  | 52.15 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 51.28 B    | 2.5           | 0.1
	ember-data/serializer                             | 232.00 B  | 50.20 B    | 2.5           | 0.1
	ember-data/adapter                                | 226.00 B  | 48.90 B    | 2.4           | 0.1
	ember-data/model                                  | 222.00 B  | 48.03 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 48.03 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 47.17 B    | 2.3           | 0.1
	ember-data/version                                | 162.00 B  | 35.05 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.66 KB' │
│  compressed  │ '1.44 KB' │
│ % Of Library │   '4.2'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.88 KB   | 638.13 B   | 43.3          | 1.8
	ember-inflector/lib/system/inflections            | 1.59 KB   | 352.06 B   | 23.9          | 1.0
	ember-inflector/index                             | 473.00 B  | 102.35 B   | 6.9           | 0.3
	ember-inflector/lib/system                        | 471.00 B  | 101.91 B   | 6.9           | 0.3
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 80.71 B    | 5.5           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 68.81 B    | 4.7           | 0.2
	ember-inflector/lib/utils/make-helper             | 308.00 B  | 66.64 B    | 4.5           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 64.05 B    | 4.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.70 KB'  │
│  compressed  │ '598.32 B' │
│ % Of Library │   '1.7'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.21 KB   | 490.34 B   | 82.0          | 1.4
	@ember-data/debug/setup                           | 499.00 B  | 107.97 B   | 18.0          | 0.3

Modern Builds (No Rollup)

✅ EmberData shrank by -913.0 B (-192.0 B compressed)

If any packages had changed sizes they would be listed here.

Changeset


EmberData +201.96 KB -913.0 B (+38.61 KB -192.0 B compressed)
    @ember-data/store +98.84 KB -770.0 B (+18.9 KB -161.93 B compressed)
        @ember-data/store/-private/system/core-store +17.12 KB +114.0 B (+3.27 KB +23.97 B compressed)
        @ember-data/store/-private/system/model/internal-model +15.33 KB -1009.0 B (+2.93 KB -212.19 B compressed)
        @ember-data/store/-private/system/model/states +5.47 KB +30.0 B (+1.05 KB +6.31 B compressed)
        @ember-data/store/-private/system/store/finders +4.37 KB +17.0 B (+855.6 B +3.58 B compressed)
        @ember-data/store/-private/system/store/record-data-store-wrapper +3.37 KB +45.0 B (+659.63 B +9.46 B compressed)
        @ember-data/store/-private/system/references/has-many +1.52 KB +11.0 B (+296.92 B +2.31 B compressed)
        @ember-data/store/-private/system/references/belongs-to +1.25 KB +11.0 B (+244.15 B +2.31 B compressed)
        @ember-data/store/-private/system/references/record +979.0 B +11.0 B (+187.18 B +2.31 B compressed)
    @ember-data/model +18.72 KB -143.0 B (+3.58 KB -30.07 B compressed)
        @ember-data/model/-private/model +6.2 KB -114.0 B (+1.19 KB -23.97 B compressed)
        @ember-data/model/-private/system/many-array +2.41 KB +22.0 B (+472.06 B +4.63 B compressed)
        @ember-data/model/-private/attr +673.0 B -51.0 B (+128.67 B -10.73 B compressed)

Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '201.96 KB' │
│ compressed │ '38.61 KB'  │
│  packages  │      8      │
│  modules   │     143     │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '98.84 KB' │
│  compressed  │ '18.90 KB' │
│ % Of Library │   '48.9'   │
└──────────────┴────────────┘
	Module                                                                             | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/store/-private/system/core-store                                       | 17.12 KB  | 3.27 KB    | 17.3          | 8.5
	@ember-data/store/-private/system/model/internal-model                             | 15.33 KB  | 2.93 KB    | 15.5          | 7.6
	@ember-data/store/-private/system/model/states                                     | 5.47 KB   | 1.05 KB    | 5.5           | 2.7
	@ember-data/store/-private/system/fetch-manager                                    | 4.96 KB   | 971.47 B   | 5.0           | 2.5
	@ember-data/store/-private/system/record-array-manager                             | 4.47 KB   | 874.34 B   | 4.5           | 2.2
	@ember-data/store/-private/system/store/finders                                    | 4.37 KB   | 855.60 B   | 4.4           | 2.2
	@ember-data/store/-private/index                                                   | 4.16 KB   | 814.50 B   | 4.2           | 2.1
	@ember-data/store/-private/identifiers/cache                                       | 3.86 KB   | 755.99 B   | 3.9           | 1.9
	@ember-data/store/-private/system/store/record-data-store-wrapper                  | 3.37 KB   | 659.63 B   | 3.4           | 1.7
	@ember-data/store/-private/system/store/internal-model-factory                     | 2.91 KB   | 569.95 B   | 2.9           | 1.4
	@ember-data/store/-private/system/snapshot                                         | 2.85 KB   | 558.10 B   | 2.9           | 1.4
	@ember-data/store/-private/system/record-arrays/record-array                       | 2.25 KB   | 440.32 B   | 2.3           | 1.1
	@ember-data/store/-private/system/ds-model-store                                   | 1.99 KB   | 389.66 B   | 2.0           | 1.0
	@ember-data/store/-private/system/request-cache                                    | 1.89 KB   | 369.20 B   | 1.9           | 0.9
	@ember-data/store/-private/system/references/has-many                              | 1.52 KB   | 296.92 B   | 1.5           | 0.8
	@ember-data/store/-private/system/schema-definition-service                        | 1.47 KB   | 288.51 B   | 1.5           | 0.7
	@ember-data/store/-private/system/model/shim-model-class                           | 1.27 KB   | 248.55 B   | 1.3           | 0.6
	@ember-data/store/-private/system/references/belongs-to                            | 1.25 KB   | 244.15 B   | 1.3           | 0.6
	@ember-data/store/-private/system/store/serializer-response                        | 1.12 KB   | 220.06 B   | 1.1           | 0.6
	@ember-data/store/-private/identifiers/utils/uuid-v4                               | 1.05 KB   | 206.11 B   | 1.1           | 0.5
	@ember-data/store/-private/system/internal-model-map                               | 983.00 B  | 187.94 B   | 1.0           | 0.5
	@ember-data/store/-private/system/references/record                                | 979.00 B  | 187.18 B   | 1.0           | 0.5
	@ember-data/store/index                                                            | 936.00 B  | 178.96 B   | 0.9           | 0.5
	@ember-data/store/-private/system/references/reference                             | 917.00 B  | 175.32 B   | 0.9           | 0.4
	@ember-data/store/-private/system/record-arrays/adapter-populated-record-array     | 892.00 B  | 170.54 B   | 0.9           | 0.4
	@ember-data/store/-private/system/model/notify-changes                             | 866.00 B  | 165.57 B   | 0.9           | 0.4
	@ember-data/store/-private/system/errors-utils                                     | 764.00 B  | 146.07 B   | 0.8           | 0.4
	@ember-data/store/-private/system/snapshot-record-array                            | 753.00 B  | 143.97 B   | 0.7           | 0.4
	@ember-data/store/-private/system/record-notification-manager                      | 689.00 B  | 131.73 B   | 0.7           | 0.3
	@ember-data/store/-private/system/references                                       | 598.00 B  | 114.33 B   | 0.6           | 0.3
	@ember-data/store/-private/system/promise-proxies                                  | 556.00 B  | 106.30 B   | 0.5           | 0.3
	@ember-data/store/-private/utils/construct-resource                                | 506.00 B  | 96.74 B    | 0.5           | 0.2
	@ember-data/store/-private/system/store/common                                     | 505.00 B  | 96.55 B    | 0.5           | 0.2
	@ember-data/store/-private/system/coerce-id                                        | 496.00 B  | 94.83 B    | 0.5           | 0.2
	@ember-data/store/-private/system/record-arrays                                    | 487.00 B  | 93.11 B    | 0.5           | 0.2
	@ember-data/store/-private/system/identity-map                                     | 450.00 B  | 86.03 B    | 0.4           | 0.2
	@ember-data/store/-private/system/diff-array                                       | 438.00 B  | 83.74 B    | 0.4           | 0.2
	@ember-data/store/-private/ts-interfaces/identifier                                | 400.00 B  | 76.47 B    | 0.4           | 0.2
	@ember-data/store/-private/utils/symbol                                            | 393.00 B  | 75.14 B    | 0.4           | 0.2
	@ember-data/store/-private/identifiers/is-stable-identifier                        | 327.00 B  | 62.52 B    | 0.3           | 0.2
	@ember-data/store/-private/ts-interfaces/fetch-manager                             | 316.00 B  | 60.41 B    | 0.3           | 0.2
	@ember-data/store/-private/utils/promise-record                                    | 290.00 B  | 55.44 B    | 0.3           | 0.1
	@ember-data/store/-private/system/backburner                                       | 268.00 B  | 51.24 B    | 0.3           | 0.1
	@ember-data/store/-private/utils/brand                                             | 258.00 B  | 49.32 B    | 0.3           | 0.1
	@ember-data/store/-private/system/record-data-for                                  | 235.00 B  | 44.93 B    | 0.2           | 0.1
	@ember-data/store/-private/system/ts-upgrade-map                                   | 234.00 B  | 44.74 B    | 0.2           | 0.1
	@ember-data/store/-private/system/normalize-model-name                             | 220.00 B  | 42.06 B    | 0.2           | 0.1
	@ember-data/store/-private/utils/is-non-empty-string                               | 212.00 B  | 40.53 B    | 0.2           | 0.1
	@ember-data/store/-debug/index                                                     | 193.00 B  | 36.90 B    | 0.2           | 0.1
	@ember-data/store/-private/system/deprecated-evented                               | 190.00 B  | 36.32 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-store-wrapper                 | 136.00 B  | 26.00 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-serializer-interface              | 98.00 B   | 18.73 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data-record-wrapper                | 96.00 B   | 18.35 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/minimum-adapter-interface                 | 95.00 B   | 18.16 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/schema-definition-service                 | 95.00 B   | 18.16 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data-json-api                      | 90.00 B   | 17.20 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/ember-data-json-api                       | 89.00 B   | 17.01 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data-schemas                       | 89.00 B   | 17.01 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/promise-proxies                           | 85.00 B   | 16.25 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-instance                           | 85.00 B   | 16.25 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data                               | 81.00 B   | 15.48 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/ds-model                                  | 78.00 B   | 14.91 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/utils                                     | 75.00 B   | 14.33 B    | 0.1           | 0.0

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '25.64 KB' │
│  compressed  │ '4.90 KB'  │
│ % Of Library │   '12.7'   │
└──────────────┴────────────┘
	Module                                                                      | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private/relationships/state/relationship           | 7.90 KB   | 1.51 KB    | 30.8          | 3.9
	@ember-data/record-data/-private/record-data                                | 7.76 KB   | 1.48 KB    | 30.3          | 3.8
	@ember-data/record-data/-private/relationships/state/belongs-to             | 2.92 KB   | 572.63 B   | 11.4          | 1.4
	@ember-data/record-data/-private/relationships/state/has-many               | 2.67 KB   | 522.73 B   | 10.4          | 1.3
	@ember-data/record-data/-private/ordered-set                                | 1.14 KB   | 223.70 B   | 4.5           | 0.6
	@ember-data/record-data/-private/relationships/state/create                 | 1.05 KB   | 205.15 B   | 4.1           | 0.5
	@ember-data/record-data/-private/index                                      | 1017.00 B | 194.44 B   | 3.9           | 0.5
	@ember-data/record-data/-private/accessors                                  | 475.00 B  | 90.81 B    | 1.8           | 0.2
	@ember-data/record-data/-private/coerce-id                                  | 406.00 B  | 77.62 B    | 1.5           | 0.2
	@ember-data/record-data/-private/normalize-link                             | 249.00 B  | 47.60 B    | 0.9           | 0.1
	@ember-data/record-data/-private/ts-interfaces/relationship-record-data     | 100.00 B  | 19.11 B    | 0.4           | 0.0

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '21.76 KB' │
│  compressed  │ '4.16 KB'  │
│ % Of Library │   '10.8'   │
└──────────────┴────────────┘
	Module                                                     | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                                | 7.12 KB   | 1.36 KB    | 32.7          | 3.5
	@ember-data/serializer/-private/embedded-records-mixin     | 4.30 KB   | 841.64 B   | 19.8          | 2.1
	@ember-data/serializer/json-api                            | 3.72 KB   | 727.69 B   | 17.1          | 1.8
	@ember-data/serializer/rest                                | 2.71 KB   | 531.14 B   | 12.5          | 1.3
	@ember-data/serializer/-private/index                      | 1.18 KB   | 231.34 B   | 5.4           | 0.6
	@ember-data/serializer/-private/transforms/date            | 523.00 B  | 99.99 B    | 2.3           | 0.3
	@ember-data/serializer/-private/transforms/boolean         | 490.00 B  | 93.68 B    | 2.2           | 0.2
	@ember-data/serializer/-private/transforms/number          | 446.00 B  | 85.27 B    | 2.0           | 0.2
	@ember-data/serializer/-private/transforms/string          | 351.00 B  | 67.11 B    | 1.6           | 0.2
	@ember-data/serializer/-private/utils                      | 286.00 B  | 54.68 B    | 1.3           | 0.1
	@ember-data/serializer/index                               | 243.00 B  | 46.46 B    | 1.1           | 0.1
	@ember-data/serializer/-private/transforms/transform       | 242.00 B  | 46.26 B    | 1.1           | 0.1
	@ember-data/serializer/transform                           | 215.00 B  | 41.10 B    | 1.0           | 0.1

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '18.72 KB' │
│  compressed  │ '3.58 KB'  │
│ % Of Library │   '9.3'    │
└──────────────┴────────────┘
	Module                                                                | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------
	@ember-data/model/-private/model                                      | 6.20 KB   | 1.19 KB    | 33.1          | 3.1
	@ember-data/model/-private/system/many-array                          | 2.41 KB   | 472.06 B   | 12.9          | 1.2
	@ember-data/model/-private/errors                                     | 2.03 KB   | 398.07 B   | 10.9          | 1.0
	@ember-data/model/-private/system/relationships/relationship-meta     | 1.30 KB   | 254.86 B   | 7.0           | 0.6
	@ember-data/model/-private/index                                      | 1.29 KB   | 252.57 B   | 6.9           | 0.6
	@ember-data/model/-private/system/relationships/ext                   | 1.23 KB   | 240.90 B   | 6.6           | 0.6
	@ember-data/model/-private/attr                                       | 673.00 B  | 128.67 B   | 3.5           | 0.3
	@ember-data/model/-private/belongs-to                                 | 663.00 B  | 126.76 B   | 3.5           | 0.3
	@ember-data/model/-private/system/promise-many-array                  | 642.00 B  | 122.74 B   | 3.3           | 0.3
	@ember-data/model/-private/has-many                                   | 626.00 B  | 119.68 B   | 3.3           | 0.3
	@ember-data/model/index                                               | 486.00 B  | 92.92 B    | 2.5           | 0.2
	@ember-data/model/-private/util                                       | 442.00 B  | 84.50 B    | 2.3           | 0.2
	@ember-data/model/-private/system/promise-belongs-to                  | 412.00 B  | 78.77 B    | 2.1           | 0.2
	@ember-data/model/-private/system/model-for-mixin                     | 408.00 B  | 78.00 B    | 2.1           | 0.2

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '18.14 KB' │
│  compressed  │ '3.47 KB'  │
│ % Of Library │   '9.0'    │
└──────────────┴────────────┘
	Module                                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                                      | 8.37 KB   | 1.60 KB    | 46.1          | 4.1
	@ember-data/adapter/error                                     | 1.91 KB   | 374.55 B   | 10.5          | 0.9
	@ember-data/adapter/-private/build-url-mixin                  | 1.82 KB   | 356.96 B   | 10.1          | 0.9
	@ember-data/adapter/index                                     | 1.14 KB   | 222.55 B   | 6.3           | 0.6
	@ember-data/adapter/-private/index                            | 1.03 KB   | 201.90 B   | 5.7           | 0.5
	@ember-data/adapter/json-api                                  | 1.02 KB   | 199.41 B   | 5.6           | 0.5
	@ember-data/adapter/-private/utils/serialize-query-params     | 792.00 B  | 151.42 B   | 4.3           | 0.4
	@ember-data/adapter/-private/utils/determine-body-promise     | 549.00 B  | 104.96 B   | 3.0           | 0.3
	@ember-data/adapter/-private/utils/parse-response-headers     | 480.00 B  | 91.77 B    | 2.6           | 0.2
	@ember-data/adapter/-private/utils/fetch                      | 454.00 B  | 86.80 B    | 2.4           | 0.2
	@ember-data/adapter/-private/utils/serialize-into-hash        | 347.00 B  | 66.34 B    | 1.9           | 0.2
	@ember-data/adapter/-private/utils/continue-on-reject         | 219.00 B  | 41.87 B    | 1.2           | 0.1
	@ember-data/adapter/-private/fastboot-interface               | 76.00 B   | 14.53 B    | 0.4           | 0.0

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.50 KB' │
│  compressed  │ '1.82 KB' │
│ % Of Library │   '4.7'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.32 KB   | 454.85 B   | 24.5          | 1.2
	ember-data/-private/index                         | 1.93 KB   | 377.42 B   | 20.3          | 1.0
	ember-data/adapters/errors                        | 1.19 KB   | 232.68 B   | 12.5          | 0.6
	ember-data/setup-container                        | 503.00 B  | 96.17 B    | 5.2           | 0.2
	ember-data/-private/core                          | 321.00 B  | 61.37 B    | 3.3           | 0.2
	ember-data/relationships                          | 318.00 B  | 60.80 B    | 3.3           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 52.38 B    | 2.8           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 47.99 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 46.84 B    | 2.5           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 46.46 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 46.46 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 46.07 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 45.31 B    | 2.4           | 0.1
	ember-data/serializer                             | 232.00 B  | 44.35 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 43.21 B    | 2.3           | 0.1
	ember-data/model                                  | 222.00 B  | 42.44 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 42.44 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 41.68 B    | 2.2           | 0.1
	ember-data/version                                | 162.00 B  | 30.97 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.66 KB' │
│  compressed  │ '1.27 KB' │
│ % Of Library │   '3.3'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.88 KB   | 563.84 B   | 43.3          | 1.4
	ember-inflector/lib/system/inflections            | 1.59 KB   | 311.07 B   | 23.9          | 0.8
	ember-inflector/index                             | 473.00 B  | 90.43 B    | 6.9           | 0.2
	ember-inflector/lib/system                        | 471.00 B  | 90.05 B    | 6.9           | 0.2
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 71.31 B    | 5.5           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 60.80 B    | 4.7           | 0.2
	ember-inflector/lib/utils/make-helper             | 308.00 B  | 58.88 B    | 4.5           | 0.1
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 56.59 B    | 4.3           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.70 KB'  │
│  compressed  │ '528.66 B' │
│ % Of Library │   '1.3'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.21 KB   | 433.25 B   | 82.0          | 1.1
	@ember-data/debug/setup                           | 499.00 B  | 95.40 B    | 18.0          | 0.2

@runspired runspired force-pushed the runspired/im-burndown branch 2 times, most recently from 89d0656 to b7d50e9 Compare April 9, 2021 23:11
@runspired runspired added the 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166 label Apr 10, 2021
@runspired runspired marked this pull request as ready for review April 10, 2021 01:07
@runspired runspired requested a review from igorT April 10, 2021 01:11
Copy link
Contributor

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What an easy PR to review! Thanks for making this as easy to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants