-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHORE] burndown of InternalModel methods that can be eliminated safely #7453
Conversation
Performance Report for a95973e Relationship Analysis
|
Asset Size Report for c0cbdae IE11 Builds ✅ EmberData shrank by -1.16 KB (-172.0 B compressed)If any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis (IE11)
Modern Builds ✅ EmberData shrank by -909.0 B (-175.0 B compressed)If any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis (Modern)
Modern Builds (No Rollup) ✅ EmberData shrank by -913.0 B (-192.0 B compressed)If any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis (Modern)
|
89d0656
to
b7d50e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What an easy PR to review! Thanks for making this as easy to review.
a95973e
to
c0cbdae
Compare
Each commit here removes a method or property from InternalModel for which either a different InternalModel codepath is just as efficient to use OR the codepath is unused OR the codepath has a non InternalModel equivalent of the same efficiency.
The motivation is to shrink the surface area of InternalModel until what remains is logic we need to move elsewhere, helping us get a clearer picture of what InternalModel is still handling for us. It comes with the added win of reducing our payload size slightly.