[Chore]: convert adapters to class syntax #7350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Performance Report for 2f223c7 Relationship Analysis |
|
Asset Size Report for 2f223c7 IE11 Builds The size of the library EmberData has increased by 617.0 B (199.0 B compressed) which exceeds the failure threshold of 15 bytes.WarningsThe uncompressed size of the package @ember-data/adapter has increased by 617.0 B. Changeset Full Asset Analysis (IE11)Modern Builds The size of the library EmberData has increased by 617.0 B (199.0 B compressed) which exceeds the failure threshold of 15 bytes.WarningsThe uncompressed size of the package @ember-data/adapter has increased by 617.0 B. Changeset Full Asset Analysis (Modern)Modern Builds (No Rollup) The size of the library EmberData has increased by 617.0 B (198.0 B compressed) which exceeds the failure threshold of 15 bytes.WarningsThe uncompressed size of the package @ember-data/adapter has increased by 617.0 B. Changeset Full Asset Analysis (Modern) |
snewcomer
commented
Oct 14, 2020
packages/adapter/addon/index.ts
Outdated
| @@ -321,7 +316,6 @@ export default EmberObject.extend({ | |||
| @param {Snapshot} snapshot | |||
| @return {Promise} promise | |||
| */ | |||
| createRecord: null, | |||
There was a problem hiding this comment.
I removed this because this should be typed as a function. Looking at moving these to ts in this PR or another.
andreyfel
reviewed
Oct 14, 2020
packages/adapter/addon/index.ts
Outdated
| @@ -55,7 +55,7 @@ import EmberObject from '@ember/object'; | |||
| @class Adapter | |||
| @extends EmberObject | |||
| */ | |||
| export default EmberObject.extend({ | |||
| export default class Adapter extends EmberObject { | |||
There was a problem hiding this comment.
Does it have to extend EmberObject now?
There was a problem hiding this comment.
I bet imagine for many users, this would be an unnoticeable change. However, technically this would be a breaking change.
|
@snewcomer discussed this in the weekly meeting, will split into a class refactor and a TS refactor. |
snewcomer
force-pushed
the
sn/adapter-classes
branch
from
f711f7c
to
2f223c7
Compare
snewcomer
commented
Oct 15, 2020
| @@ -321,7 +316,6 @@ export default EmberObject.extend({ | |||
| @param {Snapshot} snapshot | |||
| @return {Promise} promise | |||
| */ | |||
| createRecord: null, | |||
There was a problem hiding this comment.
We have to remove these because this will take precedence over prototypal methods defined on our own adapters that extend this class or user defined ones.
There was a problem hiding this comment.
Let me know if we should replace these with a function + assert or if we would be better served in the ts migration.
There was a problem hiding this comment.
Not quite sure what you mean by
We have to remove these because this will take precedence over prototypal methods defined on our own adapters that extend this class or user defined ones.
Can you please explain more?
There was a problem hiding this comment.
TS playground example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outstanding question - should I convert to
tsbefore merging?