Ensure adapters and serializers are destroyed upon store destruction. #7020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
added
lts-target
🎯 beta
rwjblue
force-pushed
the
ensure-adapter-serializer-destruction
branch
from
b02e70e to
dab0d9c
Compare
runspired
reviewed
Jan 30, 2020
| * @public | ||
| * @optional | ||
| */ | ||
| destroy?(): void; |
runspired
approved these changes
Jan 30, 2020
Prior to this change, adapters and serializers were never destroyed. Commonly (and anecdotally) this is "fine" (heck this is the first report of the issue in years!), but it is pretty common for adapters to do async of their own (e.g. tracking adapter responses, exponential backoffs, etc) and without `.destroy()` being called on them there is no way for those adapters/serializer to ensure that async is canceled appropriately.
rwjblue
force-pushed
the
ensure-adapter-serializer-destruction
branch
from
dab0d9c to
bf459de
Compare
krisselden
approved these changes
Jan 30, 2020
HeroicEric
added
🎯 lts
HeroicEric
pushed a commit
that referenced
this pull request
Feb 27, 2020
…#7020) Prior to this change, adapters and serializers were never destroyed. Commonly (and anecdotally) this is "fine" (heck this is the first report of the issue in years!), but it is pretty common for adapters to do async of their own (e.g. tracking adapter responses, exponential backoffs, etc) and without `.destroy()` being called on them there is no way for those adapters/serializer to ensure that async is canceled appropriately.
Merged
HeroicEric
pushed a commit
to HeroicEric/data
that referenced
this pull request
Feb 27, 2020
…emberjs#7020) Prior to this change, adapters and serializers were never destroyed. Commonly (and anecdotally) this is "fine" (heck this is the first report of the issue in years!), but it is pretty common for adapters to do async of their own (e.g. tracking adapter responses, exponential backoffs, etc) and without `.destroy()` being called on them there is no way for those adapters/serializer to ensure that async is canceled appropriately.
Merged
igorT
pushed a commit
that referenced
this pull request
Feb 28, 2020
…#7020) Prior to this change, adapters and serializers were never destroyed. Commonly (and anecdotally) this is "fine" (heck this is the first report of the issue in years!), but it is pretty common for adapters to do async of their own (e.g. tracking adapter responses, exponential backoffs, etc) and without `.destroy()` being called on them there is no way for those adapters/serializer to ensure that async is canceled appropriately.
igorT
pushed a commit
that referenced
this pull request
Feb 28, 2020
…#7020) Prior to this change, adapters and serializers were never destroyed. Commonly (and anecdotally) this is "fine" (heck this is the first report of the issue in years!), but it is pretty common for adapters to do async of their own (e.g. tracking adapter responses, exponential backoffs, etc) and without `.destroy()` being called on them there is no way for those adapters/serializer to ensure that async is canceled appropriately.
HeroicEric
removed
🎯 release
HeroicEric
pushed a commit
to HeroicEric/data
that referenced
this pull request
Mar 6, 2020
…emberjs#7020) Prior to this change, adapters and serializers were never destroyed. Commonly (and anecdotally) this is "fine" (heck this is the first report of the issue in years!), but it is pretty common for adapters to do async of their own (e.g. tracking adapter responses, exponential backoffs, etc) and without `.destroy()` being called on them there is no way for those adapters/serializer to ensure that async is canceled appropriately.
HeroicEric
pushed a commit
to HeroicEric/data
that referenced
this pull request
Mar 6, 2020
…emberjs#7020) Prior to this change, adapters and serializers were never destroyed. Commonly (and anecdotally) this is "fine" (heck this is the first report of the issue in years!), but it is pretty common for adapters to do async of their own (e.g. tracking adapter responses, exponential backoffs, etc) and without `.destroy()` being called on them there is no way for those adapters/serializer to ensure that async is canceled appropriately.
Merged
igorT
pushed a commit
to HeroicEric/data
that referenced
this pull request
Mar 9, 2020
…emberjs#7020) Prior to this change, adapters and serializers were never destroyed. Commonly (and anecdotally) this is "fine" (heck this is the first report of the issue in years!), but it is pretty common for adapters to do async of their own (e.g. tracking adapter responses, exponential backoffs, etc) and without `.destroy()` being called on them there is no way for those adapters/serializer to ensure that async is canceled appropriately.
igorT
pushed a commit
that referenced
this pull request
Mar 9, 2020
…#7020) Prior to this change, adapters and serializers were never destroyed. Commonly (and anecdotally) this is "fine" (heck this is the first report of the issue in years!), but it is pretty common for adapters to do async of their own (e.g. tracking adapter responses, exponential backoffs, etc) and without `.destroy()` being called on them there is no way for those adapters/serializer to ensure that async is canceled appropriately.
|
@rwjblue can we back port this fix to at least 3.11? |
|
@kiwiupover 3.11 isn't an lts, would 3.12 work for you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, adapters and serializers were never destroyed. Commonly (and anecdotally) this is "fine" (heck this is the first report of the issue in years!), but it is pretty common for adapters to do async of their own (e.g. tracking adapter responses, exponential backoffs, etc) and without
.destroy()being called on them there is no way for those adapters/serializer to ensure that async is canceled appropriately.Fixes #7018