3.15.x release backports #7002
Merged
3.15.x release backports #7002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjdivad
force-pushed
the
hjdivad/release-backports
branch
from
9857ec9 to
ba88806
Compare
hjdivad
force-pushed
the
hjdivad/release-backports
branch
from
ba88806 to
d83e3d5
Compare
ignore other dist output dirs too (cherry picked from commit 2a1c1e9)
hjdivad
force-pushed
the
hjdivad/release-backports
branch
from
ea7d796 to
8a0c220
Compare
hjdivad
force-pushed
the
hjdivad/release-backports
branch
from
bac6916 to
318915b
Compare
runspired
approved these changes
Jan 24, 2020
packages/unpublished-relationship-performance-test-app/app/routes/application.js
Show resolved
Hide resolved
|
The LTS failure here is due to ember-beta (because the current bug would affect all known versions of ember-data) |
runspired
requested changes
Jan 24, 2020
There was a problem hiding this comment.
After reviewing the failure log the Travis-web external partner test failure is unexpected. Likely because the fix being backported uses a typescript feature for which our ts dependencies need to be version bumped. This version bump should already have occurred on master (and I believe on beta as well).
hjdivad
force-pushed
the
hjdivad/release-backports
branch
from
318915b to
0af31ab
Compare
(cherry picked from commit 46085de)
Co-Authored-By: David J. Hamilton <[email protected]> (cherry picked from commit f95c2ba)
This is needed for the assertion function `assertInDebug`
hjdivad
force-pushed
the
hjdivad/release-backports
branch
from
0af31ab to
2715efe
Compare
Test is automatically re-enabled for 3.17.x. We can re-enable it once the upstream failure (glimmerjs/glimmer-vm#1010) is resolved and into ember-source. (cherry picked from commit 10ad35f)
hjdivad
force-pushed
the
hjdivad/release-backports
branch
from
cf1f996 to
91e2db0
Compare
This fixes an issue with the resolution of babel plugins when they're added to the host addon, which could get us babel parse errors for downstream consumers (eg travis-web) who have their own, older, @babel/plugin-transform-typescript.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport #6960 #6985