[DEPRECATION] deprecate intimate Reference.internalModel #6889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gaurav0
force-pushed
the
deprecate_reference_internal_model
branch
3 times, most recently
from
1840ad4 to
2588555
Compare
runspired
reviewed
Apr 9, 2020
runspired
reviewed
Apr 9, 2020
runspired
reviewed
Apr 9, 2020
runspired
reviewed
Apr 9, 2020
runspired
reviewed
Apr 9, 2020
runspired
reviewed
Apr 9, 2020
runspired
reviewed
Apr 9, 2020
runspired
requested changes
Apr 9, 2020
Gaurav0
force-pushed
the
deprecate_reference_internal_model
branch
from
72f85d3 to
157eaff
Compare
runspired
approved these changes
Apr 22, 2020
snewcomer
added
the
🌲 Project Trim 🌲
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #6166
@runspired I was able to refactor record-reference.ts to use public api but stuck on the rest here.