-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] ensure handleResponse always called in rest adapter #6871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gaurav0
changed the title
[BUGFIX] ensure handleREsponse always called in rest adapter
[BUGFIX] ensure handleResponse always called in rest adapter
Dec 9, 2019
Gaurav0
force-pushed
the
handle_response_Test
branch
2 times, most recently
from
December 9, 2019 11:51
7118266
to
8dbd498
Compare
runspired
reviewed
Dec 11, 2019
packages/-ember-data/tests/integration/adapter/handle-response-test.js
Outdated
Show resolved
Hide resolved
runspired
reviewed
Dec 11, 2019
packages/-ember-data/tests/unit/utils/determine-body-promise-test.js
Outdated
Show resolved
Hide resolved
packages/-ember-data/tests/unit/utils/determine-body-promise-test.js
Outdated
Show resolved
Hide resolved
packages/-ember-data/tests/integration/adapter/rest-adapter-test.js
Outdated
Show resolved
Hide resolved
Gaurav0
force-pushed
the
handle_response_Test
branch
from
December 11, 2019 16:00
bc77bf1
to
70f9d34
Compare
runspired
force-pushed
the
handle_response_Test
branch
from
December 12, 2019 18:46
70f9d34
to
e5f51d1
Compare
Gaurav0
force-pushed
the
handle_response_Test
branch
2 times, most recently
from
December 12, 2019 20:51
abcb3d8
to
79dbbdf
Compare
Gaurav0
force-pushed
the
handle_response_Test
branch
from
December 12, 2019 20:59
79dbbdf
to
87ee008
Compare
runspired
added
🏷️ bug
This PR primarily fixes a reported issue
Octane
🎯 beta
PR should be backported to beta
labels
Dec 13, 2019
Do we want this on the LTS? |
igorT
pushed a commit
that referenced
this pull request
Dec 14, 2019
Co-authored-by: Chris Thoburn <[email protected]>
igorT
pushed a commit
that referenced
this pull request
Dec 18, 2019
Co-authored-by: Chris Thoburn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #6851