Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nightly.yml #6857

Merged
merged 7 commits into from
Dec 5, 2019
Merged

fix nightly.yml #6857

merged 7 commits into from
Dec 5, 2019

Conversation

Gaurav0
Copy link
Contributor

@Gaurav0 Gaurav0 commented Dec 5, 2019

I wish I could figure out how to test this.

@runspired
Copy link
Contributor

@Gaurav0 maybe we should make it run on PRs while we get it working? now that it's on master likely it will trigger

@@ -3,15 +3,9 @@ name: 'Nightly'
on:
schedule:
- cron: '* 14 * * *' # 14:00 in UTC is 6am PST
branches:
- master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's bring this back, we still only want to run this on master we just also wanted to run it during PR while deving

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NVM:

You can schedule a workflow to run at specific UTC times using POSIX cron syntax. Scheduled workflows run on the latest commit on the default or base branch. The shortest interval you can run scheduled workflows is once every 5 minutes.

https://help.github.com/en/actions/automating-your-workflow-with-github-actions/events-that-trigger-workflows#scheduled-events-schedule

We don't need the branch specifier

@runspired runspired merged commit 0fa5e3d into emberjs:master Dec 5, 2019
@Gaurav0 Gaurav0 deleted the fix_nightly branch December 6, 2019 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants