-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHORE] IE11 Testing #6830
[CHORE] IE11 Testing #6830
Conversation
Asset Size Report for 16159b9 IE11 Builds EmberData has not changed in sizeIf any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis (IE11)
Modern Builds EmberData has not changed in sizeIf any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis (Modern)
Modern Builds (No Rollup) EmberData increased by 290.0 B uncompressed but decreased by 14.0 B compressedWarningsThe uncompressed size of the package @ember-data/store has increased by 290.0 B. Changeset
Full Asset Analysis (Modern)
|
Performance Report for 16159b9 Relationship Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looking good to me.
@@ -1,6 +1,13 @@ | |||
import { removeObserver, addObserver } from '@ember/object/observers'; | |||
import QUnit from 'qunit'; | |||
|
|||
function freeze(obj) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's import this function from one freeze.ts file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to do this long term but we would have a separate util for runtime vs tests. currently we only use freeze in one location in tests (here) and two locations in store. The locations in store could possible share a definition but both are DEBUG only and thus stripped away, likely we'll refactor it to a util if we hit a third case.
I don't accept this statement, please file issues for anything you ran into. |
Will need a local version to do that but it is definitely the case that DEBUG is a minefield of external issues, mostly with Proxy and string methods |
We're still a ways (if ever) from being able to run the full test suite in IE11 https://github.com/emberjs/data/pull/6830/checks?check_run_id=327832618
But this lets us run the production tests.
The small number of changes to EmberData itself are mostly for dev-time support of IE11 (which I got pretty far with but ultimately the widespread lack of support for IE11 at dev time in Ember itself prevents us from getting any further).
Some of the changes will affect prod builds but only once feature flags are turned on (request-state cache for instance).