-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHORE] Fix workflow and enable partner test debugging #6828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset Size Report for a4c0e11 IE11 Builds EmberData has not changed in sizeIf any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis (IE11)
Modern Builds EmberData has not changed in sizeIf any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis (Modern)
Modern Builds (No Rollup) EmberData has not changed in sizeIf any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis (Modern)
|
Performance Report for a4c0e11 Relationship Analysis
|
runspired
force-pushed
the
fix/observer
branch
from
December 1, 2019 02:07
7d77976
to
30a98ad
Compare
runspired
changed the title
enable debugging
[CHORE] Fix workflow and enable partner test debugging
Dec 1, 2019
Looks fine to me, but not sure, what are we fixing here? |
@igorT updated description for you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #6825
This PR
Why EmberObserver was Timing Out in Github Actions only
This turned out to be a canary-only dev-build-only transpilation bug that only affects partners transpiling for IE11 in their tests.
The primary difference between Travis/Azure and Github Actions is that in Github Actions we correctly set
env
to includeCI=true
. This causes ember-observer to targetie11
, whichintroduces a transpilation bug when using
typeof
.Our code in
canary-features
(this is stripped in production and non-canary builds)Due to this default babel plugin https://babeljs.io/docs/en/babel-plugin-transform-typeof-symbol
this is transpiled to
The above is an error because we call
_typeof
withEmberDataENV
when it is potentially undefined. We don't hit this in our ownmax-transpilation-test
because our tests always have this variable defined via the test'sindex.html
file.Changing the check to this removes the transpilation as we no longer need to check for
symbol
Here we are more loosely assuming that if we are defined and not null we are an object, but given the very narrow set of things that hit this code path this seems ok.