Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX TEST] relationships tests for adapter enapsulation side quest #6797

Merged
merged 7 commits into from
Nov 26, 2019
Merged

[BUGFIX TEST] relationships tests for adapter enapsulation side quest #6797

merged 7 commits into from
Nov 26, 2019

Conversation

Gaurav0
Copy link
Contributor

@Gaurav0 Gaurav0 commented Nov 25, 2019 •
edited
Loading

For #6666

@Gaurav0 Gaurav0 changed the title [TEST] relationships tests for adapter enapsulation side quest [BUGFIX TEST] relationships tests for adapter enapsulation side quest Nov 25, 2019
runspired
runspired approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@runspired runspired left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits on test markup to improve, otherwise 👍

A huge thanks for wading through all these different scenarios.

packages/unpublished-adapter-encapsulation-test-app/tests/integration/belongs-to-test.js Outdated Show resolved Hide resolved
packages/unpublished-adapter-encapsulation-test-app/tests/integration/has-many-test.js Outdated Show resolved Hide resolved
@runspired runspired added 🏷️ test This PR primarily adds tests for a feature 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166 🌲 📦 Encapsulation & Interface Tests 📦 🌲 labels Nov 26, 2019
@runspired runspired merged commit 0524099 into emberjs:master Nov 26, 2019
@Gaurav0 Gaurav0 deleted the relationships_tests branch November 27, 2019 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runspired runspired runspired approved these changes

Assignees
No one assigned
Labels
🏷️ test This PR primarily adds tests for a feature 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gaurav0 @runspired