Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip FeatureFlagged code in non canary builds #6742

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Conversation

igorT
Copy link
Member

@igorT igorT commented Nov 14, 2019

Also changes isCanary to not be a function and fixes the bug with the function not being invoked

@igorT igorT requested review from runspired and rwjblue November 14, 2019 22:17
@github-actions
Copy link

Asset Size Report for d909401

EmberData has not changed in size

If any packages had changed sizes they would be listed here.

Changeset



Full Asset Analysis

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '177.47 KB' │
│ compressed │ '37.39 KB'  │
│  packages  │     10      │
│  modules   │     49      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '85.07 KB' │
│  compressed  │ '17.92 KB' │
│ % Of Library │   '47.9'   │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                    | 84.15 KB  | 17.73 KB   | 98.9          | 47.4
	@ember-data/store/index                       | 936.00 B  | 197.18 B   | 1.1           | 0.5

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '23.51 KB' │
│  compressed  │ '4.95 KB'  │
│ % Of Library │   '13.2'   │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private              | 23.51 KB  | 4.95 KB    | 100.0         | 13.2

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '19.36 KB' │
│  compressed  │ '4.08 KB'  │
│ % Of Library │   '10.9'   │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                   | 7.10 KB   | 1.50 KB    | 36.7          | 4.0
	@ember-data/serializer/-private               | 5.36 KB   | 1.13 KB    | 27.7          | 3.0
	@ember-data/serializer/json-api               | 3.77 KB   | 813.37 B   | 19.5          | 2.1
	@ember-data/serializer/rest                   | 2.68 KB   | 577.85 B   | 13.8          | 1.5
	@ember-data/serializer/index                  | 243.00 B  | 51.19 B    | 1.2           | 0.1
	@ember-data/serializer/transform              | 215.00 B  | 45.29 B    | 1.1           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '14.57 KB' │
│  compressed  │ '3.07 KB'  │
│ % Of Library │   '8.2'    │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                      | 7.65 KB   | 1.61 KB    | 52.5          | 4.3
	@ember-data/adapter/-private                  | 3.50 KB   | 755.02 B   | 24.0          | 2.0
	@ember-data/adapter/error                     | 1.91 KB   | 412.69 B   | 13.1          | 1.1
	@ember-data/adapter/json-api                  | 830.00 B  | 174.85 B   | 5.6           | 0.5
	@ember-data/adapter/index                     | 719.00 B  | 151.46 B   | 4.8           | 0.4

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '12.37 KB' │
│  compressed  │ '2.61 KB'  │
│ % Of Library │   '7.0'    │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                    | 11.90 KB  | 2.51 KB    | 96.2          | 6.7
	@ember-data/model/index                       | 486.00 B  | 102.38 B   | 3.8           | 0.3

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.72 KB' │
│  compressed  │ '2.05 KB' │
│ % Of Library │   '5.5'   │
└──────────────┴───────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                              | 2.42 KB   | 522.23 B   | 24.9          | 1.4
	ember-data/-private                           | 1.98 KB   | 427.43 B   | 20.4          | 1.1
	ember-data/adapters/errors                    | 1.19 KB   | 256.37 B   | 12.2          | 0.7
	ember-data/setup-container                    | 503.00 B  | 105.96 B   | 5.1           | 0.3
	ember-data/store                              | 406.00 B  | 85.52 B    | 4.1           | 0.2
	ember-data/relationships                      | 318.00 B  | 66.99 B    | 3.2           | 0.2
	ember-data/serializers/embedded-records-mixin | 274.00 B  | 57.72 B    | 2.8           | 0.2
	ember-data/serializers/json-api               | 251.00 B  | 52.87 B    | 2.5           | 0.1
	ember-data/adapters/json-api                  | 245.00 B  | 51.61 B    | 2.5           | 0.1
	ember-data/serializers/json                   | 243.00 B  | 51.19 B    | 2.4           | 0.1
	ember-data/serializers/rest                   | 243.00 B  | 51.19 B    | 2.4           | 0.1
	ember-data/transform                          | 241.00 B  | 50.77 B    | 2.4           | 0.1
	ember-data/adapters/rest                      | 237.00 B  | 49.92 B    | 2.4           | 0.1
	ember-data/serializer                         | 232.00 B  | 48.87 B    | 2.3           | 0.1
	ember-data/adapter                            | 226.00 B  | 47.61 B    | 2.3           | 0.1
	ember-data/model                              | 222.00 B  | 46.76 B    | 2.2           | 0.1
	ember-data/attr                               | 218.00 B  | 45.92 B    | 2.2           | 0.1
	ember-data/initialize-store-service           | 207.00 B  | 43.60 B    | 2.1           | 0.1
	ember-data/version                            | 162.00 B  | 34.12 B    | 1.6           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '7.90 KB' │
│  compressed  │ '1.66 KB' │
│ % Of Library │   '4.5'   │
└──────────────┴───────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector          | 2.75 KB   | 593.44 B   | 34.8          | 1.6
	ember-inflector/lib/system/inflections        | 1.57 KB   | 339.16 B   | 19.9          | 0.9
	ember-inflector/index                         | 1.12 KB   | 241.84 B   | 14.2          | 0.6
	ember-inflector/lib/ext/string                | 783.00 B  | 164.95 B   | 9.7           | 0.4
	ember-inflector/lib/system                    | 452.00 B  | 95.22 B    | 5.6           | 0.2
	ember-inflector/lib/system/string             | 351.00 B  | 73.94 B    | 4.3           | 0.2
	ember-inflector/lib/helpers/pluralize         | 348.00 B  | 73.31 B    | 4.3           | 0.2
	ember-inflector/lib/utils/make-helper         | 308.00 B  | 64.88 B    | 3.8           | 0.2
	ember-inflector/lib/helpers/singularize       | 271.00 B  | 57.08 B    | 3.4           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.68 KB'  │
│  compressed  │ '577.85 B' │
│ % Of Library │   '1.5'    │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                       | 2.19 KB   | 472.73 B   | 81.8          | 1.2
	@ember-data/debug/setup                       | 499.00 B  | 105.12 B   | 18.2          | 0.3

Package: @ember-data/canary-features
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '1.24 KB'  │
│  compressed  │ '266.49 B' │
│ % Of Library │   '0.7'    │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/canary-features/index             | 927.00 B  | 195.28 B   | 73.3          | 0.5
	@ember-data/canary-features/default-features  | 338.00 B  | 71.20 B    | 26.7          | 0.2

Package: @ember/ordered-set
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '1.05 KB'  │
│  compressed  │ '227.09 B' │
│ % Of Library │   '0.6'    │
└──────────────┴────────────┘
	Module                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember/ordered-set/index                      | 1.05 KB   | 227.09 B   | 100.0         | 0.6

@runspired runspired added 🏷️ bug This PR primarily fixes a reported issue Feature 🎯 beta PR should be backported to beta 🎯 canary PR is targeting canary (default) 🎯 lts The PR should be backported to the most recent LTS 🎯 release PR should be backported to release 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166 labels Nov 14, 2019
@igorT igorT removed 🎯 lts The PR should be backported to the most recent LTS 🎯 release PR should be backported to release 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166 labels Nov 14, 2019
@runspired runspired added the 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166 label Nov 14, 2019
@rwjblue rwjblue merged commit 8bf2da7 into master Nov 15, 2019
@delete-merged-branch delete-merged-branch bot deleted the igor/small-ff-fix branch November 15, 2019 00:08
@igorT igorT added 🎯 release PR should be backported to release and removed 🎯 beta PR should be backported to beta 🎯 release PR should be backported to release labels Dec 14, 2019
@runspired runspired removed the 🎯 canary PR is targeting canary (default) label May 27, 2021
@runspired runspired added the 🏷️ feat This PR introduces a new feature label Sep 10, 2023
@runspired runspired removed the Feature label Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bug This PR primarily fixes a reported issue 🏷️ feat This PR introduces a new feature 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants