-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strip FeatureFlagged code in non canary builds #6742
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset Size Report for d909401 EmberData has not changed in sizeIf any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis
|
runspired
approved these changes
Nov 14, 2019
runspired
added
🏷️ bug
This PR primarily fixes a reported issue
Feature
🎯 beta
PR should be backported to beta
🎯 canary
PR is targeting canary (default)
🎯 lts
The PR should be backported to the most recent LTS
🎯 release
PR should be backported to release
🌲 Project Trim 🌲
PRs related to https://github.com/emberjs/data/issues/6166
labels
Nov 14, 2019
igorT
removed
🎯 lts
The PR should be backported to the most recent LTS
🎯 release
PR should be backported to release
🌲 Project Trim 🌲
PRs related to https://github.com/emberjs/data/issues/6166
labels
Nov 14, 2019
runspired
added
the
🌲 Project Trim 🌲
PRs related to https://github.com/emberjs/data/issues/6166
label
Nov 14, 2019
rwjblue
approved these changes
Nov 15, 2019
igorT
added
🎯 release
PR should be backported to release
and removed
🎯 beta
PR should be backported to beta
🎯 release
PR should be backported to release
labels
Dec 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🏷️ bug
This PR primarily fixes a reported issue
🏷️ feat
This PR introduces a new feature
🌲 Project Trim 🌲
PRs related to https://github.com/emberjs/data/issues/6166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changes
isCanary
to not be a function and fixes the bug with the function not being invoked