-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHORE] refactor: Remove runloop usage in integration tests for store/ find All module #6712
Merged
runspired
merged 5 commits into
emberjs:master
from
dmuneras:refactor/find-all-model-in-store-integration-test
Nov 13, 2019
Merged
[CHORE] refactor: Remove runloop usage in integration tests for store/ find All module #6712
runspired
merged 5 commits into
emberjs:master
from
dmuneras:refactor/find-all-model-in-store-integration-test
Nov 13, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmuneras
changed the title
chore: refactor: Remove runloop usage in integration tests for store/ find All module
[chore] : refactor: Remove runloop usage in integration tests for store/ find All module
Nov 10, 2019
dmuneras
changed the title
[chore] : refactor: Remove runloop usage in integration tests for store/ find All module
[chore] refactor: Remove runloop usage in integration tests for store/ find All module
Nov 10, 2019
dmuneras
changed the title
[chore] refactor: Remove runloop usage in integration tests for store/ find All module
[CHORE] refactor: Remove runloop usage in integration tests for store/ find All module
Nov 10, 2019
runspired
reviewed
Nov 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is good but I don't think we should introduce the "escape the microtask queue" trick for tests that don't need it.
e.g. this
await new Promise(resolve => setTimeout(resolve, 1));
lets refactor these to just return resolve( ...payload... )
vs the async/await with the timeout
…and remove duplicated expectation that doesn't seem required
runspired
reviewed
Nov 11, 2019
runspired
added
🏷️ test
This PR primarily adds tests for a feature
🎯 canary
PR is targeting canary (default)
🔌 Project Unplug 🔌
labels
Nov 11, 2019
dmuneras
force-pushed
the
refactor/find-all-model-in-store-integration-test
branch
from
November 12, 2019 18:17
5e6f887
to
dd756c7
Compare
runspired
approved these changes
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description