Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Return pushPayload result #6484

Conversation

esbanarango
Copy link
Contributor

This PR adds a return value (the record(s) that was created or updated) to pushPayload.

This was already done here: https://github.com/emberjs/data/pull/5265/files but apparently was mistakenly removed here https://github.com/emberjs/data/pull/5384/files

@jonnii
Copy link

jonnii commented Sep 22, 2019

I think this was feature flagged and removed on purpose if my memory serves correctly.

@runspired
Copy link
Contributor

@jonnii is correct. This feature never landed and we decided not to push it forward.

@runspired runspired closed this Sep 23, 2019
@esbanarango
Copy link
Contributor Author

@runspired do we have any context on why the decision was made?

@runspired
Copy link
Contributor

@esbanarango many factors

  • the implementation had gone stale and didn't have a champion
  • the change is complicated semantically as there's no ability to determine whether primary or all records should be returned
  • we want to move away from pushPayload entirely
  • a public API for this already exists

@esbanarango
Copy link
Contributor Author

@runspired Thank you 🙏

@runspired
Copy link
Contributor

@esbanarango there is even an open PR atm that will update the docs to actively discourage use of it: #6451 (comment) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants