Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set group name to relationship.kind #6349

Merged
merged 2 commits into from
Aug 20, 2019
Merged

Conversation

RobbieTheWagner
Copy link
Member

This fixes a bug in inspector where the groups are named the model name instead of the relationship type.

This fixes a bug in inspector where the groups are named the model name instead of the relationship type.
@igorT
Copy link
Member

igorT commented Aug 19, 2019

@rwwagner90 thanks for the fix? Any chance you could update a test to cover this please? We have some in https://github.com/emberjs/data/blob/master/packages/-ember-data/tests/integration/debug-adapter-test.js

@RobbieTheWagner
Copy link
Member Author

@igorT I just updated the existing tests to check the correct relationship types as the names for the groups. There seem to be other failures, but I don't know if they are related to my change or not.

@runspired runspired merged commit 9d18bd2 into emberjs:master Aug 20, 2019
@RobbieTheWagner
Copy link
Member Author

Thanks for merging! What release will this make it into?

@igorT
Copy link
Member

igorT commented Aug 20, 2019

@rwwagner90 is this actively broken in the wild? We could backport as well and make sure it goes into beta

@RobbieTheWagner
Copy link
Member Author

@igorT yeah, inspector has been showing the wrong names for the groups for quite awhile. Not sure when exactly it started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants