[BUGFIX] Includes yuidoc's output data.json to published package #6252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
approved these changes
Jul 16, 2019
|
Thank you for digging into this! |
|
CI is failing for canary at the moment, will dig into it separately. |
|
@rwjblue @runspired can we get a 3.11 patch release with this commit? |
runspired
pushed a commit
that referenced
this pull request
Jul 20, 2019
[BUGFIX] Includes yuidoc's output data.json to published package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
.npmignorefile entry that includes thedata.jsonfile generated by yuidoc doesn't seem to work after the package movement. I usedyarn packto verify that this includes the file as a part of the published package.We need a patch release of 3.11 with this commit.