Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yuidoc setup to support the split packages #6153

Merged
merged 2 commits into from
Jun 12, 2019
Merged

Fix yuidoc setup to support the split packages #6153

merged 2 commits into from
Jun 12, 2019

Conversation

sivakumar-kailasam
Copy link
Member

When trying to view the latest doc changes on the API docs app, I noticed that the setup is borked.

With these changes, you can view the latest docs from this branch by following the instructions in https://github.com/ember-learn/ember-jsonapi-docs#generating-api-documentation-and-testing-api-docs-locally.

This is for #6016

Copy link
Member

@bmac bmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rwjblue
Copy link
Member

rwjblue commented Jun 7, 2019

I think this will need to be cherry-picked into beta as well, @runspired can you confirm?

@runspired
Copy link
Contributor

@rwjblue confirm, needs to be cherry-picked

@runspired runspired merged commit 553a88f into master Jun 12, 2019
@runspired runspired deleted the fix/yuidoc branch June 25, 2019 21:59
runspired pushed a commit that referenced this pull request Jun 25, 2019
* [CHORE] Igore docs folder

* [DOC @ember-data packages] fix yuidoc generation
runspired added a commit that referenced this pull request Jun 25, 2019
* [CHORE] Igore docs folder

* [DOC @ember-data packages] fix yuidoc generation
pete-the-pete pushed a commit to pete-the-pete/data that referenced this pull request Jul 23, 2019
* [CHORE] Igore docs folder

* [DOC @ember-data packages] fix yuidoc generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants