Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Add Reference doc and AdapterError uses #5736

Merged
merged 1 commit into from
Nov 3, 2018
Merged

[DOC] Add Reference doc and AdapterError uses #5736

merged 1 commit into from
Nov 3, 2018

Conversation

spruce
Copy link
Contributor

@spruce spruce commented Nov 3, 2018

As mentioned in a previous PR this fixes some missing Docs.

Should the Reference Doc somehow be rewritten?

@runspired
Copy link
Contributor

Should the Reference Doc somehow be rewritten?

I don't believe so. Reference is essentially an abstract base class that users shouldn't ever have access to or need to know about. The documentation should live in the sub-classes. We recently did a Typescript based cleanup of Reference that should help with this :) See #5730

@runspired runspired merged commit 0986ed1 into emberjs:master Nov 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spruce @runspired