Use _scheduleFetch instead of _fetchRecord for belongsTo relationship #5671
Conversation
In order to ensure coalesceFindRequests works for this case.
|
I added tests for this case - I hope in the right place, I wasn't entirely sure where to put this. |
| assert.equal(type.modelName, 'tag', 'modelName is tag'); | ||
|
|
||
| if (id === '3') { | ||
| return { |
There was a problem hiding this comment.
return resolve(...data...) will make this appropriately return a promise.
| }, | ||
| }; | ||
| } else if (id === '4') { | ||
| return { |
There was a problem hiding this comment.
same as above, return a resolved promise
| } | ||
| }; | ||
|
|
||
| return run(() => { |
There was a problem hiding this comment.
using async ... await instead of lots of run loops would clean this up nicely
|
|
||
| env.adapter.coalesceFindRequests = false; | ||
|
|
||
| run(() => { |
There was a problem hiding this comment.
if we make this an async test there is no need to wrap store.push in run()
mydea
force-pushed
the
use-schedule-fetch-for-belongs-to
branch
from
9c6f59f to
bd92a47
Compare
|
I made the requested changes to the test (to be honest, I only used to non-async-await syntax because I tried to stick to the same test style as the existing tests in the file. async-await is soo much nicer)! |
mydea
force-pushed
the
use-schedule-fetch-for-belongs-to
branch
from
bd92a47 to
10acf7f
Compare
…#5671) * Use _scheduleFetch instead of _fetchRecord for belongsTo relationship In order to ensure coalesceFindRequests works for this case. * Add tests for coalescing of belongsTo relationships
…#5671) * Use _scheduleFetch instead of _fetchRecord for belongsTo relationship In order to ensure coalesceFindRequests works for this case. * Add tests for coalescing of belongsTo relationships
…#5671) * Use _scheduleFetch instead of _fetchRecord for belongsTo relationship In order to ensure coalesceFindRequests works for this case. * Add tests for coalescing of belongsTo relationships
In order to ensure coalesceFindRequests works for this case.
Without this, it would trigger one find-request per belongsTo relationship, instead of correctly coalescing them together.
I have stumbled over this while trying to debug something else, and was pretty puzzled as to why it wasn't working as expected. Changing this fixed the issue for me - not sure if there is something I'm not seeing there, though.