[CHORE] removes deprecated Store.filter feature #5437
Conversation
| @@ -514,6 +358,8 @@ function updateLiveRecordArray(array, internalModels) { | |||
|
|
|||
| if (modelsToAdd.length > 0) { array._pushInternalModels(modelsToAdd); } | |||
| if (modelsToRemove.length > 0) { array._removeInternalModels(modelsToRemove); } | |||
|
|
|||
| return modelsToAdd || modelsToRemove; | |||
There was a problem hiding this comment.
A minor perf optimization for the addon-based filter implementation. This essentially lets us know when none of the internal model changes were an addition or a remove, which tells the addon that it definitely needs to signal a recalculation. Without this we blindly signal, leading to the occasional double notification.
There was a problem hiding this comment.
I'll leave a note as to why and also that it can be removed in the follow up refactor to eliminate the unnecessary record-array-manager notifications post 3.5
|
Are there tests that assert the record array manager behavior the addon relies on? |
|
@igorT I thought there was one (but without a description), but looking back it seems not.I'll add one with a note as to purpose. |
runspired
force-pushed
the
remove-filter
branch
from
b62897e to
ec9acba
Compare
|
@igorT added tests and code comments |
runspired
force-pushed
the
remove-filter
branch
from
ec9acba to
9297ccc
Compare
See ember-data/ember-data-filter#12 for path forward for folks still using this long-since gated feature.
This approach relies on the fact that we still notify
record-array-manageron any change to aninternal-model, even if it isn't an addition or removal from aLiveRecordArray. Once the deprecation cycle is complete (3.5target), we can do an additional cleanup phase in which we no longer will be required to noisily notify therecord-array-managerof every change.Associated deprecation RFC: emberjs/rfcs#326