Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix npmignore and cleanup test artifacts before publishing #5412

Merged
merged 2 commits into from
Apr 3, 2018
Merged

Fix npmignore and cleanup test artifacts before publishing #5412

merged 2 commits into from
Apr 3, 2018

Conversation

runspired
Copy link
Contributor

@runspired runspired requested a review from rwjblue April 3, 2018 20:11
bmac
bmac approved these changes Apr 3, 2018
View reviewed changes
Copy link
Member

@bmac bmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rwjblue
Copy link
Member

rwjblue commented Apr 3, 2018

Sorry 😭 about missing this during the Travis setup refactor ....

@runspired runspired merged commit ce92a77 into emberjs:master Apr 3, 2018
@runspired runspired deleted the fix-npmignore branch April 3, 2018 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmac bmac bmac approved these changes

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@runspired @rwjblue @bmac