[BUGFIX release] Fix Model.modelName inheritance with Ember 3.2+.
#5406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
approved these changes
Mar 30, 2018
|
Changing the check to the below will fix the tests for pre ember canary: if (!klass.modelName || !klass.hasOwnProperty('modelName')) {
klass.modelName = modelName;
} |
runspired
requested changes
Mar 30, 2018
On Ember 3.2 and higher, Ember uses "real" inheritance when an `Ember.Object` is `.extend()`ed. This means that in 3.2 and higher the `ModelClassHere.modelName` property is now being inherited (where previously each `.extend()` reset the value to `null`). The fix here ensures that each `ModelClass.extend()` gets its own `modelName`...
This test was attempting to ensure that the records guid was included in the `record.toString()` output, but changes in Ember 3.2+ changed the default output of the class / constructor name portion (therefore failing the assertion in a useless way). This updates the test to add a custom `toString` to the model class so that we can be decoupled from how Ember `.toString()`'s classes when there is no custom `.toString` setup (because this is actually fairly unstable version over version).
rwjblue
force-pushed
the
fix-model-name-with-canary
branch
from
89f9dd4
to
342de27
Compare
runspired
approved these changes
Mar 30, 2018
hjdivad
approved these changes
Mar 30, 2018
This was referenced Aug 21, 2018
runspired
added a commit
that referenced
this pull request
Aug 28, 2018
* [BUGFIX release] Fix `Model.modelName` inheritance with Ember 3.2+. On Ember 3.2 and higher, Ember uses "real" inheritance when an `Ember.Object` is `.extend()`ed. This means that in 3.2 and higher the `ModelClassHere.modelName` property is now being inherited (where previously each `.extend()` reset the value to `null`). The fix here ensures that each `ModelClass.extend()` gets its own `modelName`... * [BUGFIX release] Fix toString test to work with Ember 3.2+. This test was attempting to ensure that the records guid was included in the `record.toString()` output, but changes in Ember 3.2+ changed the default output of the class / constructor name portion (therefore failing the assertion in a useless way). This updates the test to add a custom `toString` to the model class so that we can be decoupled from how Ember `.toString()`'s classes when there is no custom `.toString` setup (because this is actually fairly unstable version over version). * fix branch
runspired
added a commit
that referenced
this pull request
Aug 28, 2018
* [BUGFIX release] Fix `Model.modelName` inheritance with Ember 3.2+. On Ember 3.2 and higher, Ember uses "real" inheritance when an `Ember.Object` is `.extend()`ed. This means that in 3.2 and higher the `ModelClassHere.modelName` property is now being inherited (where previously each `.extend()` reset the value to `null`). The fix here ensures that each `ModelClass.extend()` gets its own `modelName`... * [BUGFIX release] Fix toString test to work with Ember 3.2+. This test was attempting to ensure that the records guid was included in the `record.toString()` output, but changes in Ember 3.2+ changed the default output of the class / constructor name portion (therefore failing the assertion in a useless way). This updates the test to add a custom `toString` to the model class so that we can be decoupled from how Ember `.toString()`'s classes when there is no custom `.toString` setup (because this is actually fairly unstable version over version). * fix branch
runspired
added a commit
that referenced
this pull request
Aug 28, 2018
* [BUGFIX release] Fix `Model.modelName` inheritance with Ember 3.2+. On Ember 3.2 and higher, Ember uses "real" inheritance when an `Ember.Object` is `.extend()`ed. This means that in 3.2 and higher the `ModelClassHere.modelName` property is now being inherited (where previously each `.extend()` reset the value to `null`). The fix here ensures that each `ModelClass.extend()` gets its own `modelName`... * [BUGFIX release] Fix toString test to work with Ember 3.2+. This test was attempting to ensure that the records guid was included in the `record.toString()` output, but changes in Ember 3.2+ changed the default output of the class / constructor name portion (therefore failing the assertion in a useless way). This updates the test to add a custom `toString` to the model class so that we can be decoupled from how Ember `.toString()`'s classes when there is no custom `.toString` setup (because this is actually fairly unstable version over version). * fix branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Ember 3.2 and higher, Ember uses "real" inheritance when an
Ember.Objectis.extend()ed. This means that in 3.2 and higher theModelClassHere.modelNameproperty is now being inherited (where previously each.extend()reset the value tonull).The fix here ensures that each
ModelClass.extend()gets its ownmodelName...